From a1937757ce39ef31ab2991635f775cff845746bf Mon Sep 17 00:00:00 2001 From: Oliver Klee Date: Mon, 24 Feb 2025 15:00:35 +0100 Subject: [PATCH 1/2] [TASK] Add a dedicated testcase for the abstract `CSSBlockList` --- tests/Unit/CSSList/AtRuleBlockListTest.php | 11 +++++ tests/Unit/CSSList/CSSBlockListTest.php | 47 +++++++++++++++++++ tests/Unit/CSSList/DocumentTest.php | 11 +++++ .../CSSList/Fixtures/ConcreteCSSBlockList.php | 21 +++++++++ 4 files changed, 90 insertions(+) create mode 100644 tests/Unit/CSSList/CSSBlockListTest.php create mode 100644 tests/Unit/CSSList/Fixtures/ConcreteCSSBlockList.php diff --git a/tests/Unit/CSSList/AtRuleBlockListTest.php b/tests/Unit/CSSList/AtRuleBlockListTest.php index 86411142d..1e587f8e9 100644 --- a/tests/Unit/CSSList/AtRuleBlockListTest.php +++ b/tests/Unit/CSSList/AtRuleBlockListTest.php @@ -7,6 +7,7 @@ use PHPUnit\Framework\TestCase; use Sabberworm\CSS\Comment\Commentable; use Sabberworm\CSS\CSSList\AtRuleBlockList; +use Sabberworm\CSS\CSSList\CSSBlockList; use Sabberworm\CSS\CSSList\CSSList; use Sabberworm\CSS\Renderable; @@ -51,6 +52,16 @@ public function implementsCommentable(): void self::assertInstanceOf(Commentable::class, $subject); } + /** + * @test + */ + public function isCSSBLockList(): void + { + $subject = new AtRuleBlockList('supports'); + + self::assertInstanceOf(CSSBlockList::class, $subject); + } + /** * @test */ diff --git a/tests/Unit/CSSList/CSSBlockListTest.php b/tests/Unit/CSSList/CSSBlockListTest.php new file mode 100644 index 000000000..eb7c8fd09 --- /dev/null +++ b/tests/Unit/CSSList/CSSBlockListTest.php @@ -0,0 +1,47 @@ + Date: Mon, 24 Feb 2025 20:50:21 +0100 Subject: [PATCH 2/2] Check for the correct class --- tests/Unit/CSSList/CSSBlockListTest.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/Unit/CSSList/CSSBlockListTest.php b/tests/Unit/CSSList/CSSBlockListTest.php index eb7c8fd09..9d7ef076b 100644 --- a/tests/Unit/CSSList/CSSBlockListTest.php +++ b/tests/Unit/CSSList/CSSBlockListTest.php @@ -6,6 +6,7 @@ use PHPUnit\Framework\TestCase; use Sabberworm\CSS\Comment\Commentable; +use Sabberworm\CSS\CSSList\CSSList; use Sabberworm\CSS\Renderable; use Sabberworm\CSS\Tests\Unit\CSSList\Fixtures\ConcreteCSSBlockList; @@ -42,6 +43,6 @@ public function isCSSList(): void { $subject = new ConcreteCSSBlockList(); - self::assertInstanceOf(ConcreteCSSBlockList::class, $subject); + self::assertInstanceOf(CSSList::class, $subject); } }