Ping var evalution has been updated to latest ansible commands

Author: sathiya-nhs

ansible/deploy-apigee-proxy.yml

@@ -10,7 +10,7 @@
     APIGEE_ORGANIZATION: "{{ lookup('env', 'APIGEE_ORGANIZATION') }}"
     APIGEE_ACCESS_TOKEN: "{{ lookup('env', 'APIGEE_ACCESS_TOKEN') }}"
     PROXY_DIR: "{{ lookup('env', 'PROXY_DIR') }}"
-    PING: "{{ (lookup('env', 'PING') | length > 0) | ternary(lookup('env', 'PING'), 'true') }}"
+    PING: "{{ (lookup('env', 'PING') | default('true')) | bool }}"
 
   pre_tasks:
     - name: check FULLY_QUALIFIED_SERVICE_NAME

ansible/roles/deploy-apigee-proxy/tasks/main.yml

@@ -57,14 +57,14 @@
     url: "{{ api_uri }}/_ping"
     return_content: yes
   register: proxy_ping_response
-  when: PING | bool
+  when: PING
 
 - name: set proxy_deployed_revision
   set_fact:
     proxy_deployed_revision: "{{ (proxy_ping_response.content | from_json).revision }}"
-  when: PING | bool
+  when: PING
 
 - name: check correct revision was deployed
   fail:
     msg: "Incorrect revision {{ proxy_deployed_revision }}, was expecting {{ revision }}"
-  when: PING | bool and proxy_deployed_revision != revision
+  when: PING and proxy_deployed_revision != revision