From 70a764b78b51ab16f836316cc7b50ce9367562b4 Mon Sep 17 00:00:00 2001
From: Maciej Murawski <maciej.murawski@nordcloud.com>
Date: Fri, 29 Aug 2025 11:52:30 +0100
Subject: [PATCH] fix: removing the deprecated enabled value for diagnostic
 settings metrics

---
 infrastructure/modules/api-management/main.tf             | 1 -
 infrastructure/modules/cdn-frontdoor-profile/main.tf      | 1 -
 infrastructure/modules/cdn-frontdoor-profile/variables.tf | 6 ------
 infrastructure/modules/key-vault/main.tf                  | 1 -
 infrastructure/modules/key-vault/variables.tf             | 6 ------
 5 files changed, 15 deletions(-)

diff --git a/infrastructure/modules/api-management/main.tf b/infrastructure/modules/api-management/main.tf
index 0155ea57..59e1865f 100644
--- a/infrastructure/modules/api-management/main.tf
+++ b/infrastructure/modules/api-management/main.tf
@@ -153,6 +153,5 @@ module "diagnostic-settings" {
   log_analytics_workspace_id = var.log_analytics_workspace_id
   enabled_log                = var.monitor_diagnostic_setting_apim_enabled_logs
   enabled_metric             = var.monitor_diagnostic_setting_apim_metrics
-  metric_enabled             = var.metric_enabled
 
 }
diff --git a/infrastructure/modules/cdn-frontdoor-profile/main.tf b/infrastructure/modules/cdn-frontdoor-profile/main.tf
index baf1ff83..375a4ff3 100644
--- a/infrastructure/modules/cdn-frontdoor-profile/main.tf
+++ b/infrastructure/modules/cdn-frontdoor-profile/main.tf
@@ -40,6 +40,5 @@ module "diagnostic-settings" {
   log_analytics_workspace_id = var.log_analytics_workspace_id
   enabled_log                = var.monitor_diagnostic_setting_frontdoor_enabled_logs
   enabled_metric             = var.monitor_diagnostic_setting_frontdoor_metrics
-  metric_enabled             = var.metric_enabled
 
 }
diff --git a/infrastructure/modules/cdn-frontdoor-profile/variables.tf b/infrastructure/modules/cdn-frontdoor-profile/variables.tf
index 409a5a1b..aa5e1b6c 100644
--- a/infrastructure/modules/cdn-frontdoor-profile/variables.tf
+++ b/infrastructure/modules/cdn-frontdoor-profile/variables.tf
@@ -19,12 +19,6 @@ variable "log_analytics_workspace_id" {
   default     = null
 }
 
-variable "metric_enabled" {
-  type        = bool
-  description = "Enables retention for diagnostic settings metric"
-  default     = true
-}
-
 variable "monitor_diagnostic_setting_frontdoor_enabled_logs" {
   type        = list(string)
   description = "Controls which logs will be enabled for the Front Door profile"
diff --git a/infrastructure/modules/key-vault/main.tf b/infrastructure/modules/key-vault/main.tf
index 06b2b7d0..de1a812f 100644
--- a/infrastructure/modules/key-vault/main.tf
+++ b/infrastructure/modules/key-vault/main.tf
@@ -60,7 +60,6 @@ module "diagnostic-settings" {
   log_analytics_workspace_id = var.log_analytics_workspace_id
   enabled_log                = var.monitor_diagnostic_setting_keyvault_enabled_logs
   enabled_metric             = var.monitor_diagnostic_setting_keyvault_metrics
-  metric_enabled             = var.metric_enabled
 }
 
 data "azurerm_client_config" "current" {}
diff --git a/infrastructure/modules/key-vault/variables.tf b/infrastructure/modules/key-vault/variables.tf
index 4e09fa37..2f586da3 100644
--- a/infrastructure/modules/key-vault/variables.tf
+++ b/infrastructure/modules/key-vault/variables.tf
@@ -19,12 +19,6 @@ variable "log_analytics_workspace_id" {
   description = "id of the log analytics workspace to send resource logging to via diagnostic settings"
 }
 
-variable "metric_enabled" {
-  type        = bool
-  description = "to enable retention for diagnostic settings metric"
-  default     = true
-}
-
 variable "monitor_diagnostic_setting_keyvault_enabled_logs" {
   type        = list(string)
   description = "Controls what logs will be enabled for the keyvault"