add sonar analysis (#23)

## Summary

- Routine Change

### Details

- enable sonar analysis

Author: anthony-nhs

.github/workflows/quality_checks.yml

@@ -10,6 +10,10 @@ jobs:
   quality_checks:
     runs-on: ubuntu-latest
     steps:
+      - uses: actions/setup-java@v3
+        with:
+          java-version: '21'
+          distribution: 'adopt'
       - name: Checkout code
         uses: actions/checkout@v4
         with:
@@ -48,11 +52,12 @@ jobs:
       - name: run lint
         run: make lint
 
-      - name: run unit tests
-        run: make test
-
-#      - name: SonarCloud Scan
-#        uses: SonarSource/sonarcloud-github-action@master
-#        env:
-#          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-#          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+      - name: run tests and Sonar scan
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}  # Needed to get PR information, if any
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+        run: |
+          # shellcheck source=/dev/null
+          . ~/.asdf/plugins/java/set-java-home.bash
+          make download-dependencies
+          mvn -B verify org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Dsonar.projectKey=NHSDigital_eps-FHIR-validator-lambda

.github/workflows/sam_package_code.yml

@@ -11,6 +11,10 @@ jobs:
       contents: read
       packages: read
     steps:
+      - uses: actions/setup-java@v3
+        with:
+          java-version: '21'
+          distribution: 'adopt'
       - name: Checkout code
         uses: actions/checkout@v4
         with:
@@ -57,4 +61,3 @@ jobs:
           name: packaged_code
           path: |
             .aws-sam/build
-

.tool-versions

@@ -1,7 +1,7 @@
 maven 3.9.0
-java openjdk-21.0.2
+java adoptopenjdk-21.0.2+13.0.LTS
 python 3.8.15
 poetry 1.6.1
 shellcheck 0.9.0
 direnv 2.32.2
-actionlint 1.6.26
+actionlint 1.6.26

SAMtemplates/main_template.yaml

@@ -84,4 +84,3 @@ Outputs:
     Value: !GetAtt FHIRValidator.Arn
     Export:
       Name: !Join [":", [!Ref "AWS::StackName", "FHIRValidatorLambdaArn"]]
-

pom.xml

@@ -16,6 +16,8 @@
         <fhir.version>5.5.0</fhir.version>
         <log4j.version>2.23.0</log4j.version>
         <fasterxml.version>2.16.1</fasterxml.version>
+        <sonar.organization>nhsdigital</sonar.organization>
+        <sonar.host.url>https://sonarcloud.io</sonar.host.url>
     </properties>
     <dependencyManagement>
         <dependencies>