Skip to content

Commit 86cc7bd

Browse files
authored
Merge branch 'main' into aea-4506-communal-qc
2 parents 3ff9a03 + 3b8f23e commit 86cc7bd

File tree

10 files changed

+99
-27
lines changed

10 files changed

+99
-27
lines changed

.github/actions/mark_jira_released/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ runs:
1616
with:
1717
aws-region: eu-west-2
1818
role-to-assume: ${{ inputs.DEV_CLOUD_FORMATION_EXECUTE_LAMBDA_ROLE }}
19-
role-session-name: account-resources-release-notes-run-lambda
19+
role-session-name: fhir-validator-lambda-release-notes-run-lambda
2020

2121
- name: call markJiraReleased lambda
2222
shell: bash

.github/actions/update_confluence_jira/action.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ runs:
3232
with:
3333
aws-region: eu-west-2
3434
role-to-assume: ${{ inputs.TARGET_CLOUD_FORMATION_CHECK_VERSION_ROLE }}
35-
role-session-name: account-resources-release-notes-target
35+
role-session-name: fhir-validator-lambda-release-notes-target
3636

3737
- name: Get deployed tag on target
3838
shell: bash
@@ -46,7 +46,7 @@ runs:
4646
with:
4747
aws-region: eu-west-2
4848
role-to-assume: ${{ inputs.DEV_CLOUD_FORMATION_CHECK_VERSION_ROLE }}
49-
role-session-name: account-resources-release-notes-dev
49+
role-session-name: fhir-validator-lambda-release-notes-dev
5050

5151
- name: get current dev tag
5252
shell: bash
@@ -58,7 +58,7 @@ runs:
5858
with:
5959
aws-region: eu-west-2
6060
role-to-assume: ${{ inputs.DEV_CLOUD_FORMATION_EXECUTE_LAMBDA_ROLE }}
61-
role-session-name: account-resources-release-notes-run-lambda
61+
role-session-name: fhir-validator-lambda-release-notes-run-lambda
6262
unset-current-credentials: true
6363

6464
- name: create int release notes

.github/workflows/delete_old_cloudformation_stacks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
with:
3131
aws-region: eu-west-2
3232
role-to-assume: ${{ secrets.DEV_CLOUD_FORMATION_DEPLOY_ROLE }}
33-
role-session-name: github-actions
33+
role-session-name: fhir-validator-lambda-delete-old-stacks
3434

3535
- name: delete stacks
3636
shell: bash

.github/workflows/sam_release_code.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ jobs:
8888
with:
8989
aws-region: eu-west-2
9090
role-to-assume: ${{ secrets.CLOUD_FORMATION_DEPLOY_ROLE }}
91-
role-session-name: github-actions
91+
role-session-name: fhir-validator-lambda-release-code
9292

9393
- name: download build artifact
9494
uses: actions/download-artifact@v4

poetry.lock

Lines changed: 11 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
<maven.compiler.source>21</maven.compiler.source>
1919
<maven.compiler.target>21</maven.compiler.target>
2020
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
21-
<fhir.version>7.4.5</fhir.version>
22-
<log4j.version>2.24.1</log4j.version>
21+
<fhir.version>7.6.0</fhir.version>
22+
<log4j.version>2.24.2</log4j.version>
2323
<fasterxml.version>2.18.1</fasterxml.version>
2424
<sonar.organization>nhsdigital</sonar.organization>
2525
<sonar.host.url>https://sonarcloud.io</sonar.host.url>
@@ -40,7 +40,7 @@
4040
<dependency>
4141
<groupId>io.github.hakky54</groupId>
4242
<artifactId>logcaptor</artifactId>
43-
<version>2.9.3</version>
43+
<version>2.10.0</version>
4444
<scope>test</scope>
4545
</dependency>
4646
<!--The

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ requests = "^2.32.3"
2828
flake8 = "^7.1.1"
2929
pip-licenses = "^4.5.1"
3030
pre-commit = "^3.5.0"
31-
cfn-lint = "^1.18.4"
31+
cfn-lint = "^1.20.1"
3232

3333
[tool.poetry.scripts]
3434

src/test/resources/results/invalidBundle.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@
216216
"valueString": "Terminology_PassThrough_TX_Message"
217217
}
218218
],
219-
"severity": "information",
219+
"severity": "warning",
220220
"code": "processing",
221221
"details": {
222222
"coding": [
@@ -247,7 +247,7 @@
247247
"valueString": "Terminology_PassThrough_TX_Message"
248248
}
249249
],
250-
"severity": "information",
250+
"severity": "warning",
251251
"code": "processing",
252252
"details": {
253253
"coding": [

src/test/resources/results/searchSet.json

Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,10 +153,22 @@
153153
{
154154
"url": "http://hl7.org/fhir/StructureDefinition/operationoutcome-issue-col",
155155
"valueInteger": 499
156+
},
157+
{
158+
"url": "http://hl7.org/fhir/StructureDefinition/operationoutcome-message-id",
159+
"valueString": "This_element_does_not_match_any_known_slice_"
156160
}
157161
],
158162
"severity": "information",
159163
"code": "processing",
164+
"details": {
165+
"coding": [
166+
{
167+
"system": "http://hl7.org/fhir/java-core-messageId",
168+
"code": "This_element_does_not_match_any_known_slice_"
169+
}
170+
]
171+
},
160172
"diagnostics": "This element does not match any known slice defined in the profile https://fhir.nhs.uk/StructureDefinition/NHSDigital-MedicationRequest-CodeableConcept (this may not be a problem, but you should check that it's not intended to match a slice) - Bundle.entry[0].resource/*MedicationRequest/null*/.medication.ofType(CodeableConcept).coding[0]: Does not match slice 'SNOMED' (discriminator: ('http://snomed.info/sct' in system))",
161173
"location": [
162174
"Bundle.entry[0].resource/*MedicationRequest/null*/.medication.ofType(CodeableConcept).coding[0]",
@@ -501,10 +513,22 @@
501513
{
502514
"url": "http://hl7.org/fhir/StructureDefinition/operationoutcome-issue-col",
503515
"valueInteger": 1598
516+
},
517+
{
518+
"url": "http://hl7.org/fhir/StructureDefinition/operationoutcome-message-id",
519+
"valueString": "This_element_does_not_match_any_known_slice_"
504520
}
505521
],
506522
"severity": "information",
507523
"code": "processing",
524+
"details": {
525+
"coding": [
526+
{
527+
"system": "http://hl7.org/fhir/java-core-messageId",
528+
"code": "This_element_does_not_match_any_known_slice_"
529+
}
530+
]
531+
},
508532
"diagnostics": "This element does not match any known slice defined in the profile https://fhir.nhs.uk/StructureDefinition/NHSDigital-MedicationRequest-CodeableConcept (this may not be a problem, but you should check that it's not intended to match a slice) - Bundle.entry[1].resource/*MedicationRequest/null*/.medication.ofType(CodeableConcept).coding[0]: Does not match slice 'SNOMED' (discriminator: ('http://snomed.info/sct' in system))",
509533
"location": [
510534
"Bundle.entry[1].resource/*MedicationRequest/null*/.medication.ofType(CodeableConcept).coding[0]",
@@ -849,10 +873,22 @@
849873
{
850874
"url": "http://hl7.org/fhir/StructureDefinition/operationoutcome-issue-col",
851875
"valueInteger": 2710
876+
},
877+
{
878+
"url": "http://hl7.org/fhir/StructureDefinition/operationoutcome-message-id",
879+
"valueString": "This_element_does_not_match_any_known_slice_"
852880
}
853881
],
854882
"severity": "information",
855883
"code": "processing",
884+
"details": {
885+
"coding": [
886+
{
887+
"system": "http://hl7.org/fhir/java-core-messageId",
888+
"code": "This_element_does_not_match_any_known_slice_"
889+
}
890+
]
891+
},
856892
"diagnostics": "This element does not match any known slice defined in the profile https://fhir.nhs.uk/StructureDefinition/NHSDigital-MedicationRequest-CodeableConcept (this may not be a problem, but you should check that it's not intended to match a slice) - Bundle.entry[2].resource/*MedicationRequest/null*/.medication.ofType(CodeableConcept).coding[0]: Does not match slice 'SNOMED' (discriminator: ('http://snomed.info/sct' in system))",
857893
"location": [
858894
"Bundle.entry[2].resource/*MedicationRequest/null*/.medication.ofType(CodeableConcept).coding[0]",
@@ -1197,10 +1233,22 @@
11971233
{
11981234
"url": "http://hl7.org/fhir/StructureDefinition/operationoutcome-issue-col",
11991235
"valueInteger": 3810
1236+
},
1237+
{
1238+
"url": "http://hl7.org/fhir/StructureDefinition/operationoutcome-message-id",
1239+
"valueString": "This_element_does_not_match_any_known_slice_"
12001240
}
12011241
],
12021242
"severity": "information",
12031243
"code": "processing",
1244+
"details": {
1245+
"coding": [
1246+
{
1247+
"system": "http://hl7.org/fhir/java-core-messageId",
1248+
"code": "This_element_does_not_match_any_known_slice_"
1249+
}
1250+
]
1251+
},
12041252
"diagnostics": "This element does not match any known slice defined in the profile https://fhir.nhs.uk/StructureDefinition/NHSDigital-MedicationRequest-CodeableConcept (this may not be a problem, but you should check that it's not intended to match a slice) - Bundle.entry[3].resource/*MedicationRequest/null*/.medication.ofType(CodeableConcept).coding[0]: Does not match slice 'SNOMED' (discriminator: ('http://snomed.info/sct' in system))",
12051253
"location": [
12061254
"Bundle.entry[3].resource/*MedicationRequest/null*/.medication.ofType(CodeableConcept).coding[0]",
@@ -1621,10 +1669,22 @@
16211669
{
16221670
"url": "http://hl7.org/fhir/StructureDefinition/operationoutcome-issue-col",
16231671
"valueInteger": 495
1672+
},
1673+
{
1674+
"url": "http://hl7.org/fhir/StructureDefinition/operationoutcome-message-id",
1675+
"valueString": "This_element_does_not_match_any_known_slice_"
16241676
}
16251677
],
16261678
"severity": "information",
16271679
"code": "processing",
1680+
"details": {
1681+
"coding": [
1682+
{
1683+
"system": "http://hl7.org/fhir/java-core-messageId",
1684+
"code": "This_element_does_not_match_any_known_slice_"
1685+
}
1686+
]
1687+
},
16281688
"diagnostics": "This element does not match any known slice defined in the profile https://fhir.nhs.uk/StructureDefinition/NHSDigital-MedicationRequest-CodeableConcept (this may not be a problem, but you should check that it's not intended to match a slice) - Bundle.entry[0].resource/*MedicationRequest/null*/.medication.ofType(CodeableConcept).coding[0]: Does not match slice 'SNOMED' (discriminator: ('http://snomed.info/sct' in system))",
16291689
"location": [
16301690
"Bundle.entry[0].resource/*MedicationRequest/null*/.medication.ofType(CodeableConcept).coding[0]",
@@ -2048,10 +2108,22 @@
20482108
{
20492109
"url": "http://hl7.org/fhir/StructureDefinition/operationoutcome-issue-col",
20502110
"valueInteger": 499
2111+
},
2112+
{
2113+
"url": "http://hl7.org/fhir/StructureDefinition/operationoutcome-message-id",
2114+
"valueString": "This_element_does_not_match_any_known_slice_"
20512115
}
20522116
],
20532117
"severity": "information",
20542118
"code": "processing",
2119+
"details": {
2120+
"coding": [
2121+
{
2122+
"system": "http://hl7.org/fhir/java-core-messageId",
2123+
"code": "This_element_does_not_match_any_known_slice_"
2124+
}
2125+
]
2126+
},
20552127
"diagnostics": "This element does not match any known slice defined in the profile https://fhir.nhs.uk/StructureDefinition/NHSDigital-MedicationRequest-CodeableConcept (this may not be a problem, but you should check that it's not intended to match a slice) - Bundle.entry[0].resource/*MedicationRequest/null*/.medication.ofType(CodeableConcept).coding[0]: Does not match slice 'SNOMED' (discriminator: ('http://snomed.info/sct' in system))",
20562128
"location": [
20572129
"Bundle.entry[0].resource/*MedicationRequest/null*/.medication.ofType(CodeableConcept).coding[0]",

src/test/resources/results/validBundle.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@
135135
"valueString": "Terminology_PassThrough_TX_Message"
136136
}
137137
],
138-
"severity": "information",
138+
"severity": "warning",
139139
"code": "processing",
140140
"details": {
141141
"coding": [
@@ -266,7 +266,7 @@
266266
"valueString": "Terminology_PassThrough_TX_Message"
267267
}
268268
],
269-
"severity": "information",
269+
"severity": "warning",
270270
"code": "processing",
271271
"details": {
272272
"coding": [
@@ -397,7 +397,7 @@
397397
"valueString": "Terminology_PassThrough_TX_Message"
398398
}
399399
],
400-
"severity": "information",
400+
"severity": "warning",
401401
"code": "processing",
402402
"details": {
403403
"coding": [
@@ -528,7 +528,7 @@
528528
"valueString": "Terminology_PassThrough_TX_Message"
529529
}
530530
],
531-
"severity": "information",
531+
"severity": "warning",
532532
"code": "processing",
533533
"details": {
534534
"coding": [

0 commit comments

Comments
 (0)