From a862233e2cca7002e4771c11b6f3eaf548c35f26 Mon Sep 17 00:00:00 2001 From: Anthony Brown Date: Fri, 21 Nov 2025 12:38:08 +0000 Subject: [PATCH 1/3] fail job on bad pr format --- .github/workflows/pr_title_check.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pr_title_check.yml b/.github/workflows/pr_title_check.yml index 780ded7..332aaf0 100644 --- a/.github/workflows/pr_title_check.yml +++ b/.github/workflows/pr_title_check.yml @@ -11,7 +11,6 @@ jobs: steps: - name: Check PR Title is Prefixed with Change Type id: check_prefix - continue-on-error: true env: PR_TITLE: ${{ github.event.pull_request.title }} run: | @@ -86,3 +85,9 @@ jobs: See the contributing guide for more details: https://github.com/NHSDigital/eps-common-workflows/blob/main/CONTRIBUTING.md comment-tag: pr-link + + - name: Fail job due to invalid PR title format + if: steps.check_prefix.outcome != 'success' || steps.check_ticket_reference.outcome != 'success' + run: | + echo "Job failed due to invalid PR title format." + exit 1 From ace1f3b2c7fe8a69a2889fd645815569a55eb305 Mon Sep 17 00:00:00 2001 From: Anthony Brown Date: Fri, 21 Nov 2025 12:41:56 +0000 Subject: [PATCH 2/3] make sure comment is added --- .github/workflows/pr_title_check.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/pr_title_check.yml b/.github/workflows/pr_title_check.yml index 332aaf0..f8fb08e 100644 --- a/.github/workflows/pr_title_check.yml +++ b/.github/workflows/pr_title_check.yml @@ -11,6 +11,7 @@ jobs: steps: - name: Check PR Title is Prefixed with Change Type id: check_prefix + continue-on-error: true env: PR_TITLE: ${{ github.event.pull_request.title }} run: | From 383cf2847307cc0d4a2a44d20db9c24ef6365b6e Mon Sep 17 00:00:00 2001 From: Anthony Brown Date: Fri, 21 Nov 2025 12:43:01 +0000 Subject: [PATCH 3/3] trigger build