Skip to content

Commit dd6e7e0

Browse files
committed
[PRMP-1080] Fixed formatting
1 parent d1a55b0 commit dd6e7e0

File tree

2 files changed

+23
-19
lines changed

2 files changed

+23
-19
lines changed

lambdas/services/document_review_processor_service.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,11 @@
44

55
from botocore.exceptions import ClientError
66
from enums.document_review_status import DocumentReviewStatus
7-
from models.document_reference import DocumentReferenceMetadataFields
87
from models.document_review import (
98
DocumentReviewFileDetails,
109
DocumentUploadReviewReference,
1110
)
1211
from models.sqs.review_message_body import ReviewMessageBody
13-
from services.base.dynamo_service import DynamoDBService
1412
from services.base.s3_service import S3Service
1513
from services.document_upload_review_service import DocumentUploadReviewService
1614
from utils.audit_logging_setup import LoggingService
@@ -54,11 +52,9 @@ def process_review_message(self, review_message: ReviewMessageBody) -> None:
5452
document_upload_review = self._build_review_record(
5553
review_message, review_id, review_files
5654
)
57-
55+
5856
try:
59-
self.review_document_service.create_dynamo_entry(
60-
document_upload_review
61-
)
57+
self.review_document_service.create_dynamo_entry(document_upload_review)
6258
except ClientError as e:
6359
if e.response["Error"]["Code"] == "ConditionalCheckFailedException":
6460
logger.info("Entry already exists on Document Review table")

lambdas/tests/unit/services/test_document_review_processor_service.py

Lines changed: 21 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@ def mock_s3_service(mocker):
1717

1818
@pytest.fixture
1919
def mock_document_review_service(mocker):
20-
return mocker.patch("services.document_review_processor_service.DocumentUploadReviewService")
20+
return mocker.patch(
21+
"services.document_review_processor_service.DocumentUploadReviewService"
22+
)
2123

2224

2325
@pytest.fixture
@@ -151,9 +153,11 @@ def test_process_review_message_dynamo_error_not_precondition(
151153
)
152154
],
153155
)
154-
service_under_test.review_document_service.create_dynamo_entry.side_effect = ClientError(
155-
{"Error": {"Code": "InternalServerError", "Message": "DynamoDB error"}},
156-
"PutItem",
156+
service_under_test.review_document_service.create_dynamo_entry.side_effect = (
157+
ClientError(
158+
{"Error": {"Code": "InternalServerError", "Message": "DynamoDB error"}},
159+
"PutItem",
160+
)
157161
)
158162

159163
with pytest.raises(ClientError):
@@ -175,14 +179,16 @@ def test_process_review_message_continues_dynamo_conditional_check_failure(
175179
],
176180
)
177181
mocker.patch.object(service_under_test, "_delete_files_from_staging")
178-
service_under_test.review_document_service.create_dynamo_entry.side_effect = ClientError(
179-
{
180-
"Error": {
181-
"Code": "ConditionalCheckFailedException",
182-
"Message": "DynamoDB error",
183-
}
184-
},
185-
"PutItem",
182+
service_under_test.review_document_service.create_dynamo_entry.side_effect = (
183+
ClientError(
184+
{
185+
"Error": {
186+
"Code": "ConditionalCheckFailedException",
187+
"Message": "DynamoDB error",
188+
}
189+
},
190+
"PutItem",
191+
)
186192
)
187193

188194
service_under_test.process_review_message(sample_review_message)
@@ -418,5 +424,7 @@ def test_workflow_handles_multiple_different_patients(service_under_test):
418424
for message in messages:
419425
service_under_test.process_review_message(message)
420426

421-
assert service_under_test.review_document_service.create_dynamo_entry.call_count == 3
427+
assert (
428+
service_under_test.review_document_service.create_dynamo_entry.call_count == 3
429+
)
422430
assert service_under_test.s3_service.copy_across_bucket.call_count == 3

0 commit comments

Comments
 (0)