From cae6d7aa230421c10f2a272be0ce31fdfab56b67 Mon Sep 17 00:00:00 2001 From: bhansell1 Date: Thu, 18 Dec 2025 15:31:07 +0000 Subject: [PATCH 1/2] CCM-13038: pact test fix --- package-lock.json | 8 ++++---- .../supplier-api-letter-request-prepared.json | 2 +- tests/package.json | 2 +- .../letter-request-prepared.consumer.pact.test.ts | 2 +- .../letter-request-prepared.provider.pact.test.ts | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/package-lock.json b/package-lock.json index 9816f763..f8f11e82 100644 --- a/package-lock.json +++ b/package-lock.json @@ -7517,9 +7517,9 @@ } }, "node_modules/@nhsdigital/nhs-notify-event-schemas-letter-rendering": { - "version": "2.0.0", - "resolved": "https://npm.pkg.github.com/download/@nhsdigital/nhs-notify-event-schemas-letter-rendering/2.0.0/329230fced77de6141adb0fb991023d7f8ae10b7", - "integrity": "sha512-rTkq199jGm8+fMoB/3uvYOOiVCgYn9vN4LBBdCVB7cTnskMkI+5NJEjpxkvO/jqUr8a0JkZY8cRTN8xZ1nNaKQ==", + "version": "2.0.1", + "resolved": "https://npm.pkg.github.com/download/@nhsdigital/nhs-notify-event-schemas-letter-rendering/2.0.1/23a5011fb0addd3da400f798bb1e4340440d62a5", + "integrity": "sha512-U2AWQEBcTDSxA3RX29fdmwjaOPQvwrCQP5rVCgLgtlPGes4Wl695VLw7tDxgpyLY1p9ct3HHrx3Wc6k/QGeW7g==", "license": "MIT", "dependencies": { "zod": "^4.0.17" @@ -27367,7 +27367,7 @@ "@aws-sdk/client-api-gateway": "^3.906.0", "@aws-sdk/client-dynamodb": "^3.858.0", "@aws-sdk/lib-dynamodb": "^3.858.0", - "@nhsdigital/nhs-notify-event-schemas-letter-rendering": "^2.0.0", + "@nhsdigital/nhs-notify-event-schemas-letter-rendering": "^2.0.1", "@pact-foundation/pact": "^16.0.2", "allure-js-commons": "^3.3.3", "charenc": "^0.0.2", diff --git a/pact-contracts/pacts/letter-rendering/supplier-api-letter-request-prepared.json b/pact-contracts/pacts/letter-rendering/supplier-api-letter-request-prepared.json index f831dc26..913266d2 100644 --- a/pact-contracts/pacts/letter-rendering/supplier-api-letter-request-prepared.json +++ b/pact-contracts/pacts/letter-rendering/supplier-api-letter-request-prepared.json @@ -21,7 +21,7 @@ "url": "s3://comms-123456789012-eu-west-2-pdf-pipeline/rendered/client/35b9VJ4ejJZXk0Z9HtQI9khryiz_35b9VgjHJYKoseXAHWT9i44qSbz.pdf" }, "datacontenttype": "application/json", - "dataschema": "https://notify.nhs.uk/cloudevents/schemas/letter-rendering/letter-request.prepared.2.0.0.schema.json", + "dataschema": "https://notify.nhs.uk/cloudevents/schemas/letter-rendering/letter-request.prepared.2.0.1.schema.json", "dataschemaversion": "2.0.0", "id": "12f1f09c-a555-4d9b-8405-0b33490bc929", "plane": "data", diff --git a/tests/package.json b/tests/package.json index f087a3e1..9cb0394a 100644 --- a/tests/package.json +++ b/tests/package.json @@ -4,7 +4,7 @@ "@aws-sdk/client-api-gateway": "^3.906.0", "@aws-sdk/client-dynamodb": "^3.858.0", "@aws-sdk/lib-dynamodb": "^3.858.0", - "@nhsdigital/nhs-notify-event-schemas-letter-rendering": "^2.0.0", + "@nhsdigital/nhs-notify-event-schemas-letter-rendering": "^2.0.1", "@pact-foundation/pact": "^16.0.2", "allure-js-commons": "^3.3.3", "charenc": "^0.0.2", diff --git a/tests/pact-tests/consumer/letter-request-prepared.consumer.pact.test.ts b/tests/pact-tests/consumer/letter-request-prepared.consumer.pact.test.ts index deac7602..b73de11f 100644 --- a/tests/pact-tests/consumer/letter-request-prepared.consumer.pact.test.ts +++ b/tests/pact-tests/consumer/letter-request-prepared.consumer.pact.test.ts @@ -37,7 +37,7 @@ describe("Pact Message Consumer - LetterRequestPrepared Event", () => { datacontenttype: "application/json", dataschema: MatchersV3.regex( /^https:\/\/notify\.nhs\.uk\/cloudevents\/schemas\/letter-rendering\/letter-request\.prepared\.2\.\d+\.\d+\.schema\.json$/, - "https://notify.nhs.uk/cloudevents/schemas/letter-rendering/letter-request.prepared.2.0.0.schema.json", + "https://notify.nhs.uk/cloudevents/schemas/letter-rendering/letter-request.prepared.2.0.1.schema.json", ), dataschemaversion: MatchersV3.regex(/\d+\.\d+\.\d+/, "2.0.0"), traceparent: MatchersV3.string( diff --git a/tests/pact-tests/provider/letter-request-prepared.provider.pact.test.ts b/tests/pact-tests/provider/letter-request-prepared.provider.pact.test.ts index 1893621d..9fbf3384 100644 --- a/tests/pact-tests/provider/letter-request-prepared.provider.pact.test.ts +++ b/tests/pact-tests/provider/letter-request-prepared.provider.pact.test.ts @@ -1,6 +1,6 @@ import path from "node:path"; import { MessageProviderPact } from "@pact-foundation/pact"; -import LetterRequestPreparedEvent from "@nhsdigital/nhs-notify-event-schemas-letter-rendering/examples/LetterRequestPrepared/v2.0.0.json"; +import LetterRequestPreparedEvent from "@nhsdigital/nhs-notify-event-schemas-letter-rendering/examples/LetterRequestPrepared/v2.0.1.json"; describe("Letter rendering message provider tests", () => { test("verify pacts", async () => { From 5000d36a73c1b9d5a81399465c83a93058243e49 Mon Sep 17 00:00:00 2001 From: bhansell1 Date: Thu, 18 Dec 2025 15:32:39 +0000 Subject: [PATCH 2/2] CCM-13038: add leak to ignore --- .gitleaksignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitleaksignore b/.gitleaksignore index 706ad9b9..59b814d9 100644 --- a/.gitleaksignore +++ b/.gitleaksignore @@ -18,3 +18,4 @@ d8aaf7e033bf78fff491caa148897be266b60f67:src/src.sln:ipv4:3 e12407e09151898bfd8d049d57eee9db9977d56b:.github/copilot-instructions.md:generic-api-key:213 4ad86108d4e08cd410061e8842dd3a2b3bee4867:scripts/JWT/README.md:generic-api-key:38 504844c9838740c8c5235024919f0775ad817cde:pact-contracts/pacts/letter-rendering/supplier-api-letter-request-prepared.json:generic-api-key:10 +82cf3b2e89ea24b97c4ffc09e618700fb1b0aff3:pact-contracts/pacts/letter-rendering/supplier-api-letter-request-prepared.json:generic-api-key:10