fix(dialogs): unable to show nested frameless modal views (#1469)

* fix(dialogs): unable to show nested frameless modal views

* chore(modal-navigation-ng): add tests for nested modal views without frames

Author: ADjenkov

e2e/modal-navigation-ng/app/modal/modal.component.html

@@ -6,7 +6,7 @@
     <StackLayout backgroundColor="lightGreen">
         <Button text="Navigate To Second Page" (tap)="onNavigateSecondPage()" [visibility]="navigationVisibility"></Button>
         <Button text="Show Nested Modal Page With Frame" (tap)="showNestedModalFrame()" [visibility]="navigationVisibility"></Button>
-        <Button text="Show Nested Modal Page" (tap)="showNestedModal()" [visibility]="navigationVisibility"></Button>
+        <Button text="Show Nested Modal Page" (tap)="showNestedModal()"></Button>
         <Button text="Show Dialog" (tap)="showDialogConfirm()"></Button>
         <Button text="Close Modal" (tap)="close(rootLayout)"></Button>
     </StackLayout>

e2e/modal-navigation-ng/e2e/modal-layout.e2e-spec.ts

@@ -45,6 +45,10 @@ describe("modal-layout:", () => {
                 await screen.loadedHome();
             });
 
+            it("should show nested modal page, run in background, close", async () => {
+                await testNestedModalPageBackground(driver, screen, false);
+            });
+
             it("should show dialog confirm inside modal view with no frame, run in background", async () => {
                 await testDialogBackground(driver, screen, false);
             });

nativescript-angular/directives/dialogs.ts

@@ -67,6 +67,13 @@ export class ModalDialogService {
             parentView = parentView.ngAppRoot;
         }
 
+        // _ngDialogRoot is the first child of the previously detached proxy.
+        // It should have 'viewController' (iOS) or '_dialogFragment' (Android) available for
+        // presenting future modal views.
+        if (parentView._ngDialogRoot) {
+            parentView = parentView._ngDialogRoot;
+        }
+
         const pageFactory: PageFactory = viewContainerRef.injector.get(PAGE_FACTORY);
 
         // resolve from particular module (moduleRef)
@@ -76,7 +83,9 @@ export class ModalDialogService {
 
         const frame = parentView.page && parentView.page.frame;
 
-        this.location._beginModalNavigation(frame);
+        if (frame) {
+            this.location._beginModalNavigation(frame);
+        }
 
         return new Promise((resolve, reject) => {
             setTimeout(() => {
@@ -144,6 +153,7 @@ export class ModalDialogService {
             componentView = detachedProxy.getChildAt(0);
 
             if (componentView.parent) {
+                (<any>componentView.parent)._ngDialogRoot = componentView;
                 (<any>componentView.parent).removeChild(componentView);
             }
 

tests/app/tests/ns-location-strategy.ts

@@ -36,7 +36,7 @@ export class FakeFrame extends View implements Frame {
         }
     }
 
-    navigate(entry: any) {}
+    navigate(entry: any) { }
 
     constructor(private backCB?: () => void) {
         super();
@@ -70,10 +70,15 @@ export class FakeFrame extends View implements Frame {
     _findEntryForTag(fragmentTag: string): BackstackEntry {
         throw new Error("I am a FakeFrame");
     }
-
     _updateBackstack(entry: BackstackEntry, isBack: boolean): void {
         throw new Error("I am a FakeFrame");
     }
+    _pushInFrameStack() {
+        throw new Error("I am a FakeFrame");
+    }
+    _removeFromFrameStack() {
+        throw new Error("I am a FakeFrame");
+    }
 }
 
 function initStrategy(initUrl: string, back?: () => void): NSLocationStrategy {