fix: page might be null'ed before clearHistory's navigatedToEvent

m-abs · m-abs · commit ea66985a9cc9 · 2019-02-22T11:40:38.000+01:00
diff --git a/nativescript-angular/router/page-router-outlet.ts b/nativescript-angular/router/page-router-outlet.ts
@@ -374,10 +374,9 @@ export class PageRouterOutlet implements OnDestroy { // tslint:disable-line:dire
                 if (this.outlet) {
                     this.routeReuseStrategy.clearCache(this.outlet.outletKeys[0]);
                 }
-                page.off(Page.navigatedToEvent, clearCallback);
             });
 
-            page.on(Page.navigatedToEvent, clearCallback);
+            page.once(Page.navigatedToEvent, clearCallback);
         }
 
         this.frame.navigate({

Original file line number	Diff line number	Diff line change
`@@ -374,10 +374,9 @@ export class PageRouterOutlet implements OnDestroy { // tslint:disable-line:dire`
`374`	`374`	`if (this.outlet) {`
`375`	`375`	`this.routeReuseStrategy.clearCache(this.outlet.outletKeys[0]);`
`376`	`376`	`}`
`377`		`- page.off(Page.navigatedToEvent, clearCallback);`
`378`	`377`	`});`
`379`	`378`
`380`		`- page.on(Page.navigatedToEvent, clearCallback);`
	`379`	`+ page.once(Page.navigatedToEvent, clearCallback);`
`381`	`380`	`}`
`382`	`381`
`383`	`382`	`this.frame.navigate({`