chore: remove commandsServiceProvider

The `commandsServiceProvider` has been used when code was shared between AppBuilder CLI and NativeScript CLI. At the moment, we do not share the code with any other library, so we can safely remove the `commandsServiceProvider` as it is not used in NativeScript CLI.

Author: rosen-vladimirov

lib/bootstrap.ts

@@ -86,7 +86,6 @@ $injector.requireCommand("package-manager|get", "./commands/package-manager-get"
 
 $injector.require("packageInstallationManager", "./package-installation-manager");
 $injector.require("dynamicHelpProvider", "./dynamic-help-provider");
-$injector.require("commandsServiceProvider", "./providers/commands-service-provider");
 
 $injector.require("deviceLogProvider", "./common/mobile/device-log-provider");
 $injector.require("projectFilesProvider", "./providers/project-files-provider");

lib/common/definitions/commands-service.d.ts

@@ -6,13 +6,6 @@ interface ICommandsService {
 	completeCommand(): Promise<boolean>;
 }
 
-interface ICommandsServiceProvider {
-	dynamicCommandsPrefix: string;
-	getDynamicCommands(): Promise<string[]>;
-	generateDynamicCommands(): Promise<void>;
-	registerDynamicSubCommands(): void;
-}
-
 /**
  * Describes the command data.
  */

lib/common/services/commands-service.ts

@@ -16,11 +16,9 @@ export class CommandsService implements ICommandsService {
 		return _.last(this.commands);
 	}
 
-	private areDynamicSubcommandsRegistered = false;
 	private commands: ICommandData[] = [];
 
 	constructor(private $analyticsSettingsService: IAnalyticsSettingsService,
-		private $commandsServiceProvider: ICommandsServiceProvider,
 		private $errors: IErrors,
 		private $hooksService: IHooksService,
 		private $injector: IInjector,
@@ -110,10 +108,6 @@ export class CommandsService implements ICommandsService {
 			this.$options.validateOptions(command ? command.dashedOptions : null);
 		}
 
-		if (!this.areDynamicSubcommandsRegistered) {
-			this.$commandsServiceProvider.registerDynamicSubCommands();
-			this.areDynamicSubcommandsRegistered = true;
-		}
 		return this.canExecuteCommand(commandName, commandArguments);
 	}
 
@@ -161,11 +155,6 @@ export class CommandsService implements ICommandsService {
 
 			this.$errors.fail("Unable to execute command '%s'. Use '$ %s %s --help' for help.", beautifiedName, this.$staticConfig.CLIENT_NAME.toLowerCase(), beautifiedName);
 			return false;
-		} else if (!isDynamicCommand && _.startsWith(commandName, this.$commandsServiceProvider.dynamicCommandsPrefix)) {
-			if (_.some(await this.$commandsServiceProvider.getDynamicCommands())) {
-				await this.$commandsServiceProvider.generateDynamicCommands();
-				return await this.canExecuteCommand(commandName, commandArguments, true);
-			}
 		}
 
 		const commandInfo = {

lib/common/test/unit-tests/services/help-service.ts

@@ -42,11 +42,6 @@ const createTestInjector = (opts?: { isProjectTypeResult: boolean; isPlatformRes
 	injector.register("opener", {
 		open(target: string, appname?: string): void {/* mock */ }
 	});
-	injector.register("commandsServiceProvider", {
-		getDynamicCommands: (): Promise<string[]> => {
-			return Promise.resolve(<string[]>[]);
-		}
-	});
 
 	injector.register("fs", {
 		exists: (filePath: string) => false

lib/providers/commands-service-provider.ts

@@ -73,9 +73,6 @@ function createTestInjector(): IInjector {
 	testInjector.register("yarn", YarnLib.YarnPackageManager);
 	testInjector.register("childProcess", ChildProcessLib.ChildProcess);
 	testInjector.register("projectFilesManager", ProjectFilesManagerLib.ProjectFilesManager);
-	testInjector.register("commandsServiceProvider", {
-		registerDynamicSubCommands: () => { /* intentionally left blank */ }
-	});
 	testInjector.register("preparePlatformNativeService", PreparePlatformNativeService);
 	testInjector.register("preparePlatformJSService", PreparePlatformJSService);
 	testInjector.register("pluginVariablesService", {});

test/npm-support.ts

@@ -116,9 +116,6 @@ function createTestInjector() {
 	testInjector.registerCommand("platform|update", PlatformUpdateCommandLib.UpdatePlatformCommand);
 	testInjector.registerCommand("platform|clean", PlatformCleanCommandLib.CleanCommand);
 	testInjector.register("resources", {});
-	testInjector.register("commandsServiceProvider", {
-		registerDynamicSubCommands: () => { /* intentionally left blank */ }
-	});
 	testInjector.register("commandsService", {
 		tryExecuteCommand: () => { /* intentionally left blank */ }
 	});

test/platform-commands.ts

@@ -75,9 +75,6 @@ function createTestInjector() {
 		trackOptions: () => Promise.resolve(null)
 	});
 	testInjector.register("commandsService", CommandsService);
-	testInjector.register("commandsServiceProvider", {
-		registerDynamicSubCommands: () => { /* intentionally empty body */ }
-	});
 	testInjector.register("hostInfo", HostInfo);
 	testInjector.register("projectHelper", ProjectHelper);