Skip to content

Commit 0a29cc7

Browse files
FatmeFatme
authored andcommitted
Fix isCocoaPodsWorkingCorrectly
1 parent fd56e44 commit 0a29cc7

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

lib/doctor.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Constants } from "./constants";
2-
import { EOL, platform } from "os";
2+
import { EOL } from "os";
33
import { HostInfo } from "./host-info";
44
import { AndroidLocalBuildRequirements } from "./local-build-requirements/android-local-build-requirements";
55
import { IosLocalBuildRequirements } from "./local-build-requirements/ios-local-build-requirements";
@@ -198,7 +198,7 @@ export class Doctor implements NativeScriptDoctor.IDoctor {
198198
additionalInformation: data.additionalInformation,
199199
platforms: data.platforms,
200200
type: Constants.WARNING_TYPE_NAME
201-
}
201+
};
202202
}
203203

204204
return {

lib/sys-info.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,9 @@ export class SysInfo implements NativeScriptDoctor.ISysInfo {
235235
public isCocoaPodsWorkingCorrectly(): Promise<boolean> {
236236
return this.getValueForProperty(() => this.isCocoaPodsWorkingCorrectlyCache, async (): Promise<boolean> => {
237237
if (this.hostInfo.isDarwin) {
238+
if (!this.fileSystem.exists(path.join(osenv.home(), ".cocoapods"))) {
239+
return true;
240+
}
238241
temp.track();
239242
const tempDirectory = temp.mkdirSync("nativescript-check-cocoapods");
240243
const pathToXCodeProjectZip = path.join(__dirname, "..", "resources", "cocoapods-verification", "cocoapods.zip");
@@ -248,7 +251,7 @@ export class SysInfo implements NativeScriptDoctor.ISysInfo {
248251
if (spawnResult.exitCode) {
249252
return false;
250253
} else {
251-
return await this.fileSystem.exists(path.join(xcodeProjectDir, "cocoapods.xcworkspace"));
254+
return this.fileSystem.exists(path.join(xcodeProjectDir, "cocoapods.xcworkspace"));
252255
}
253256
} catch (err) {
254257
return null;

test/sys-info.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -552,7 +552,6 @@ ${expectedCliVersion}`;
552552
assert.deepEqual(result.xcprojInfo, undefined);
553553
assert.deepEqual(result.isCocoaPodsUpdateRequired, undefined);
554554
assert.deepEqual(result.pythonInfo, undefined);
555-
556555
});
557556
it("no platform is specified", async() => {
558557
sysInfo = mockSysInfo(childProcessResult, { isWindows: false, isDarwin: true, dotNetVersion });

0 commit comments

Comments
 (0)