chore: fix pr comments

Author: KristianDD

lib/services/log-source-map-service.ts

@@ -1,9 +1,9 @@
-const sourcemap = require("source-map");
 import * as path from "path";
-const sourceMapConverter = require("convert-source-map");
-import { ANDROID_DEVICE_APP_ROOT_TEMPLATE, APP_FOLDER_NAME, NODE_MODULES_FOLDER_NAME } from "../constants";
 import * as util from "util";
+import * as sourcemap from "source-map";
+import * as sourceMapConverter from "convert-source-map";
 import { stringReplaceAll } from "../common/helpers";
+import { ANDROID_DEVICE_APP_ROOT_TEMPLATE, APP_FOLDER_NAME, NODE_MODULES_FOLDER_NAME } from "../constants";
 
 interface IParsedMessage {
 	filePath?: string;

npm-shrinkwrap.json

@@ -96,6 +96,7 @@
     "@types/chai-as-promised": "0.0.31",
     "@types/chokidar": "1.6.0",
     "@types/color": "3.0.0",
+    "@types/convert-source-map": "^1.5.1",
     "@types/inquirer": "0.0.43",
     "@types/lodash": "4.14.123",
     "@types/node": "8.10.30",

package.json

@@ -41,26 +41,38 @@ function toPlatformSep(filePath: string) {
 
 const testCases: IDictionary<Array<{caseName: string, message: string, expected: string}>> = {
 	"android": [{
-			caseName: "trace massage",
+			caseName: "trace message",
 			message: "JS: at module.exports.push../main-view-model.ts.HelloWorldModel.onTap (file:///data/data/org.nativescript.sourceMap/files/app/bundle.js:303:17)",
 			expected: `JS: at module.exports.push../main-view-model.ts.HelloWorldModel.onTap file:///${toPlatformSep("src/main-view-model.ts")}:30:16\n`
 		}, {
-			caseName: "error massage",
+			caseName: "error message",
 			message: "System.err: 	Frame: function:'module.exports.push../main-view-model.ts.HelloWorldModel.onTap', file:'file:///data/data/org.nativescript.sourceMap/files/app/bundle.js', line: 304, column: 15",
 			expected: `System.err: 	Frame: function:'module.exports.push../main-view-model.ts.HelloWorldModel.onTap', file:' file:///${toPlatformSep("src/main-view-model.ts")}:31:14\n`
+		}, {
+			caseName: "error message no match",
+			message: "System.err: 	Frame: function:'module.exports.push../main-view-model.ts.HelloWorldModel.onTap', file:'file:///data/data/org.nativescript.sourceMap/files/app/bundle.js', line: 400, column: 15",
+			expected: "System.err: 	Frame: function:'module.exports.push../main-view-model.ts.HelloWorldModel.onTap', file:'file:///data/data/org.nativescript.sourceMap/files/app/bundle.js', line: 400, column: 15\n"
+		}, {
+			caseName: "no file match",
+			message: "System.err: 	at com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1203)",
+			expected: "System.err: 	at com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1203)\n"
 		}],
 	"ios": [{
-			caseName: "console massage",
+			caseName: "console message",
 			message: "CONSOLE LOG file:///app/bundle.js:294:20: Test.",
 			expected: `CONSOLE LOG Test. file:///${toPlatformSep("src/main-view-model.ts")}:29:20\n`
 		}, {
-			caseName: "trace massage",
+			caseName: "trace message",
 			message: "CONSOLE TRACE file:///app/bundle.js:295:22: Test",
 			expected: `CONSOLE TRACE Test file:///${toPlatformSep("src/main-view-model.ts")}:30:22\n`
 		}, {
-			caseName: "error massage",
+			caseName: "error message",
 			message: "file:///app/bundle.js:296:32: JS ERROR Error: Test",
 			expected: `JS ERROR Error Test file:///${toPlatformSep("src/main-view-model.ts")}:31:31\n`
+		}, {
+			caseName: "error message no match",
+			message: "file:///app/bundle.js:400:32: JS ERROR Error: Test",
+			expected: "file:///app/bundle.js:400:32: JS ERROR Error: Test\n"
 		}]
 };