Use sync version of fs.readFile

Author: rosen-vladimirov

lib/services/ios-project-service.ts

@@ -405,11 +405,11 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
 	public canUpdatePlatform(installedModuleDir: string): IFuture<boolean> {
 		return (() => {
 			let currentXcodeProjectFile = this.buildPathToCurrentXcodeProjectFile();
-			let currentXcodeProjectFileContent = this.$fs.readFile(currentXcodeProjectFile).wait();
+			let currentXcodeProjectFileContent = this.$fs.readFile(currentXcodeProjectFile);
 
 			let newXcodeProjectFile = this.buildPathToNewXcodeProjectFile(installedModuleDir);
 			this.replaceFileContent(newXcodeProjectFile).wait();
-			let newXcodeProjectFileContent = this.$fs.readFile(newXcodeProjectFile).wait();
+			let newXcodeProjectFileContent = this.$fs.readFile(newXcodeProjectFile);
 
 			let contentIsTheSame = currentXcodeProjectFileContent.toString() === newXcodeProjectFileContent.toString();
 			if(!contentIsTheSame) {
@@ -590,7 +590,7 @@ We will now place an empty obsolete compatability white screen LauncScreen.xib f
 				this.$logger.trace("Schedule merge plist at: " + plistPath);
 				session.patch({
 					name: path.relative(projectDir, plistPath),
-					read: () => this.$fs.readFile(plistPath).wait().toString()
+					read: () => this.$fs.readText(plistPath).wait()
 				});
 			};
 

test/ios-project-service.ts

@@ -234,7 +234,7 @@ describe("iOSProjectService", () => {
 
 				assert.ok(plist);
 
-				let plistContent = fs.readFile(plist).wait().toString();
+				let plistContent = fs.readText(plist).wait();
 				// There may be better way to equal property lists
 				assert.equal(plistContent, expectedPlistContent, "Mismatch in exportOptionsPlist content");
 
@@ -444,7 +444,7 @@ describe("Static libraries support", () => {
 
 		iOSProjectService.generateModulemap(staticLibraryHeadersPath, libraryName);
 		// Read the generated modulemap and verify it.
-		let modulemap = fs.readFile(path.join(staticLibraryHeadersPath, "module.modulemap")).wait();
+		let modulemap = fs.readFile(path.join(staticLibraryHeadersPath, "module.modulemap"));
 		let headerCommands = _.map(headers, value => `header "${value}"`);
 		let modulemapExpectation = `module ${libraryName} { explicit module ${libraryName} { ${headerCommands.join(" ")} } }`;
 
@@ -456,7 +456,7 @@ describe("Static libraries support", () => {
 
 		let error: any;
 		try {
-			modulemap = fs.readFile(path.join(staticLibraryHeadersPath, "module.modulemap")).wait();
+			modulemap = fs.readFile(path.join(staticLibraryHeadersPath, "module.modulemap"));
 		} catch (err) {
 			error = err;
 		}

test/stubs.ts

@@ -72,7 +72,7 @@ export class FileSystemStub implements IFileSystem {
 		return undefined;
 	}
 
-	readFile(filename:string):IFuture<NodeBuffer> {
+	readFile(filename:string): NodeBuffer | string {
 		return undefined;
 	}