fix: ensure data is sent to analytics on preuninstall

CLI's analytics process is a detached one, so during `preuninstall` command, CLI just sends information to the detached process what should be tracked and finishes CLI's execution. After that `npm` starts removing the CLI package and its `node_modules`.
At this point the analytics process may still work and trying to send data, but as it relies on components in node_modules, which npm currently deletes, it fails to send information to Google Analytics.
To ensure correct data is send to Analytics, ensure tracking is finished before ending the preuninstall command.

Author: rosen-vladimirov

lib/common/commands/preuninstall.ts

@@ -27,6 +27,7 @@ export class PreUninstallCommand implements ICommand {
 		}
 
 		this.$fs.deleteFile(path.join(this.$settingsService.getProfileDir(), "KillSwitches", "cli"));
+		await this.$analyticsService.finishTracking();
 	}
 
 	private async handleIntentionalUninstall(): Promise<void> {

lib/common/test/unit-tests/preuninstall.ts

@@ -30,7 +30,8 @@ describe("preuninstall", () => {
 		});
 
 		testInjector.register("analyticsService", {
-			trackEventActionInGoogleAnalytics: async (data: IEventActionData): Promise<void> => undefined
+			trackEventActionInGoogleAnalytics: async (data: IEventActionData): Promise<void> => undefined,
+			finishTracking: async(): Promise<void> => undefined
 		});
 
 		testInjector.registerCommand("dev-preuninstall", PreUninstallCommand);
@@ -83,15 +84,22 @@ describe("preuninstall", () => {
 			trackedData.push(data);
 		};
 
+		let isFinishTrackingCalled = false;
+		analyticsService.finishTracking = async (): Promise<void> => {
+			isFinishTrackingCalled = true;
+		};
+
 		const preUninstallCommand: ICommand = testInjector.resolveCommand("dev-preuninstall");
 		for (const testCase of testData) {
 			helpers.isInteractive = () => testCase.isInteractive;
 			helpers.doesCurrentNpmCommandMatch = () => testCase.isIntentionalUninstall;
+			isFinishTrackingCalled = false;
 			await preUninstallCommand.execute([]);
 			assert.deepEqual(trackedData, [{
 				action: "Uninstall CLI",
 				additionalData: testCase.expecteEventLabelData
 			}]);
+			assert.isTrue(isFinishTrackingCalled, "At the end of the command, finishTracking must be called");
 			trackedData = [];
 		}
 	});