chore: track prepare with hook and extract getCircularReplacer in method

Author: KristianDD

lib/services/performance-service.ts

@@ -57,22 +57,9 @@ export class PerformanceService implements IPerformanceService {
 
 	private logDataToFile(filePath: string, methodInfo: string, executionTime: number, args: any[]) {
 		let methodArgs;
-		const getCircularReplacer = () => {
-			const seen = new WeakSet();
-			seen.add(this.$options);
-			return (key: any, value: any) => {
-				if (typeof value === "object" && value !== null) {
-					if (seen.has(value) || _.startsWith(key, "$")) {
-						return;
-					}
-					seen.add(value);
-				}
-				return value;
-			};
-		};
 
 		try {
-			methodArgs = JSON.stringify(args, getCircularReplacer());
+			methodArgs = JSON.stringify(args, this.getCircularReplacer());
 		} catch (e) {
 			methodArgs = "cyclic args";
 		}
@@ -90,6 +77,20 @@ export class PerformanceService implements IPerformanceService {
 			this.$logger.trace(PerformanceService.FAIL_LOG_MESSAGE_TEMPLATE, methodInfo);
 		}
 	}
+
+	private getCircularReplacer() {
+		const seen = new WeakSet();
+		seen.add(this.$options);
+		return (key: any, value: any) => {
+			if (typeof value === "object" && value !== null) {
+				if (seen.has(value) || _.startsWith(key, "$")) {
+					return;
+				}
+				seen.add(value);
+			}
+			return value;
+		};
+	}
 }
 
 $injector.register('performanceService', PerformanceService);

lib/services/platform-service.ts

@@ -307,8 +307,8 @@ export class PlatformService extends EventEmitter implements IPlatformService {
 	}
 
 	/* Hooks are expected to use "filesToSync" parameter, as to give plugin authors additional information about the sync process.*/
-	@helpers.hook('prepare')
 	@performanceLog()
+	@helpers.hook('prepare')
 	private async preparePlatformCore(platform: string,
 		appFilesUpdaterOptions: IAppFilesUpdaterOptions,
 		projectData: IProjectData,