fix(xcode): fix getXcodeVersion() method

Currently `getXcodeVersion` always returns `{ major: null, minor: null, patch: null }`. This method uses internally `sysInfo.getXcodeVersion()`. On the other side, `sysInfo.getXcodeVersion()` returns the xocde's version in format `major.minor.patch` - for example `10.3.4`. After getting the result of `sysInfo.getXcodeVersion()`, NativeScript CLI matches the received output with `/Xcode (.*)/` regex. As the received output doesn't contain `Xcode`, the match returns null and as result `getXcodeVersion` method returns `{ major: null, minor: null, patch: null }`.

Author: Fatme

lib/common/services/xcode-select-service.ts

@@ -35,15 +35,9 @@ export class XcodeSelectService implements IXcodeSelectService {
 			this.$errors.fail("xcodebuild execution failed. Make sure that you have latest Xcode and tools installed.");
 		}
 
-		const xcodeVersionMatch = xcodeVer.match(/Xcode (.*)/),
-			xcodeVersionGroup = xcodeVersionMatch && xcodeVersionMatch[1],
-			xcodeVersionSplit = xcodeVersionGroup && xcodeVersionGroup.split(".");
-
-		return {
-			major: xcodeVersionSplit && xcodeVersionSplit[0],
-			minor: xcodeVersionSplit && xcodeVersionSplit[1],
-			patch: xcodeVersionSplit && xcodeVersionSplit[2]
-		};
+		const [ major, minor, patch ] = xcodeVer.split(".");
+
+		return { major, minor, patch };
 	}
 }
 

lib/common/test/unit-tests/xcode-select-service.ts

@@ -59,7 +59,7 @@ describe("xcode-select-service", () => {
 	});
 
 	it("gets correct Xcode version", async () => {
-		injector = createTestInjector({ xcodeSelectStdout: null, isDarwin: true, xcodeVersionOutput: "Xcode 7.3\nBuild version 7D175" });
+		injector = createTestInjector({ xcodeSelectStdout: null, isDarwin: true, xcodeVersionOutput: "7.3" });
 		service = injector.resolve("$xcodeSelectService");
 
 		const xcodeVersion = await service.getXcodeVersion();