Warn users that android related command need all --key-store- parameters when using --release

Fixes #839

Author: teobugslayer

lib/commands/build.ts

@@ -26,7 +26,8 @@ $injector.registerCommand("build|ios", BuildIosCommand);
 export class BuildAndroidCommand extends BuildCommandBase implements  ICommand {
 	constructor($platformService: IPlatformService,
 				private $platformsData: IPlatformsData,
-				private $options: IOptions) {
+				private $options: IOptions,
+				private $errors: IErrors) {
 		super($platformService);
 	}
 
@@ -36,5 +37,14 @@ export class BuildAndroidCommand extends BuildCommandBase implements  ICommand {
 	}
 
 	public allowedParameters: ICommandParameter[] = [];
+
+	public canExecute(args: string[]): IFuture<boolean> {
+		return (() => {
+			if (this.$options.release && (!this.$options.keyStorePath || !this.$options.keyStorePassword || !this.$options.keyStoreAlias || !this.$options.keyStoreAliasPassword)) {
+				this.$errors.fail("When producing a release build, you need to specify all --key-store-* options.");
+			}
+			return args.length === 0;
+		}).future<boolean>()();
+	}
 }
 $injector.registerCommand("build|android", BuildAndroidCommand);

lib/commands/deploy.ts

@@ -3,12 +3,24 @@
 
 export class DeployOnDeviceCommand implements ICommand {
 	constructor(private $platformService: IPlatformService,
-		private $platformCommandParameter: ICommandParameter) { }
+		private $platformCommandParameter: ICommandParameter,
+				private $options: IOptions,
+				private $errors: IErrors) { }
 
 	execute(args: string[]): IFuture<void> {
 		return this.$platformService.deployOnDevice(args[0]);
 	}
 
-	allowedParameters = [this.$platformCommandParameter];
+	public canExecute(args: string[]): IFuture<boolean> {
+		return (() => {
+			if (this.$options.release && (!this.$options.keyStorePath || !this.$options.keyStorePassword || !this.$options.keyStoreAlias || !this.$options.keyStoreAliasPassword)) {
+				this.$errors.fail("When producing a release build, you need to specify all --key-store-* options.");
+			}
+			let res = (args.length === 1) && this.$platformCommandParameter.validate(args[0]).wait();
+			return res;
+		}).future<boolean>()();
+	}
+
+	allowedParameters: ICommandParameter[] = [];
 }
 $injector.registerCommand("deploy", DeployOnDeviceCommand);

lib/commands/run.ts

@@ -25,14 +25,25 @@ $injector.registerCommand("run|ios", RunIosCommand);
 
 export class RunAndroidCommand extends RunCommandBase implements ICommand {
 	constructor($platformService: IPlatformService,
-		private $platformsData: IPlatformsData) {
-		super($platformService);
+		private $platformsData: IPlatformsData,
+				private $options: IOptions,
+				private $errors: IErrors) {
+			super($platformService);
 	}
 
 	public allowedParameters: ICommandParameter[] = [];
 
 	public execute(args: string[]): IFuture<void> {
 		return this.executeCore([this.$platformsData.availablePlatforms.Android]);
 	}
+
+	public canExecute(args: string[]): IFuture<boolean> {
+		return (() => {
+			if (this.$options.release && (!this.$options.keyStorePath || !this.$options.keyStorePassword || !this.$options.keyStoreAlias || !this.$options.keyStoreAliasPassword)) {
+				this.$errors.fail("When producing a release build, you need to specify all --key-store-* options.");
+			}
+			return args.length === 0;
+		}).future<boolean>()();
+	}
 }
 $injector.registerCommand("run|android", RunAndroidCommand);