chore: replace failWithoutHelp with fail

Author: rosen-vladimirov

lib/commands/apple-login.ts

@@ -24,7 +24,7 @@ export class AppleLogin implements ICommand {
 
 		const user = await this.$applePortalSessionService.createUserSession({ username, password });
 		if (!user.areCredentialsValid) {
-			this.$errors.failWithoutHelp(`Invalid username and password combination. Used '${username}' as the username.`);
+			this.$errors.fail(`Invalid username and password combination. Used '${username}' as the username.`);
 		}
 
 		const output = Buffer.from(user.userSessionCookie).toString("base64");

lib/commands/appstore-list.ts

@@ -37,7 +37,7 @@ export class ListiOSApps implements ICommand {
 			sessionBase64: this.$options.appleSessionBase64,
 		});
 		if (!user.areCredentialsValid) {
-			this.$errors.failWithoutHelp(`Invalid username and password combination. Used '${username}' as the username.`);
+			this.$errors.fail(`Invalid username and password combination. Used '${username}' as the username.`);
 		}
 
 		const applications = await this.$applePortalApplicationService.getApplications(user);

lib/commands/appstore-upload.ts

@@ -46,7 +46,7 @@ export class PublishIOS implements ICommand {
 			requireApplicationSpecificPassword: true
 		});
 		if (!user.areCredentialsValid) {
-			this.$errors.failWithoutHelp(`Invalid username and password combination. Used '${username}' as the username.`);
+			this.$errors.fail(`Invalid username and password combination. Used '${username}' as the username.`);
 		}
 
 		if (!mobileProvisionIdentifier && !ipaFilePath) {

lib/services/apple-portal/apple-portal-session-service.ts

@@ -98,13 +98,13 @@ export class ApplePortalSessionService implements IApplePortalSessionService {
 				result.isTwoFactorAuthenticationEnabled = statusCode === 409;
 
 				if (result.isTwoFactorAuthenticationEnabled && opts && opts.requireApplicationSpecificPassword && !opts.applicationSpecificPassword) {
-					this.$errors.failWithoutHelp(`Your account has two-factor authentication enabled but --appleApplicationSpecificPassword option is not provided.
+					this.$errors.fail(`Your account has two-factor authentication enabled but --appleApplicationSpecificPassword option is not provided.
 To generate an application-specific password, please go to https://appleid.apple.com/account/manage.
 This password will be used for the iTunes Transporter, which is used to upload your application.`);
 				}
 
 				if (result.isTwoFactorAuthenticationEnabled && opts && opts.requireInteractiveConsole && !isInteractive()) {
-					this.$errors.failWithoutHelp(`Your account has two-factor authentication enabled, but your console is not interactive.
+					this.$errors.fail(`Your account has two-factor authentication enabled, but your console is not interactive.
 For more details how to set up your environment, please execute "tns publish ios --help".`);
 				}
 
@@ -192,7 +192,7 @@ For more details how to set up your environment, please execute "tns publish ios
 
 			this.$applePortalCookieService.updateUserSessionCookie(authTrustResponse.headers["set-cookie"]);
 		} else {
-			this.$errors.failWithoutHelp(`Although response from Apple indicated activated Two-step Verification or Two-factor Authentication, NativeScript CLI don't know how to handle this response: ${data}`);
+			this.$errors.fail(`Although response from Apple indicated activated Two-step Verification or Two-factor Authentication, NativeScript CLI don't know how to handle this response: ${data}`);
 		}
 	}
 }