Merge pull request #3725 from NativeScript/fatme/fix-tracked-template-name

chore: fix the template name that will be send to google analytics

Author: Fatme

lib/services/project-templates-service.ts

@@ -92,7 +92,7 @@ export class ProjectTemplatesService implements IProjectTemplatesService {
 	private getTemplateNameToBeTracked(templateName: string, packageJsonContent: any): string {
 		try {
 			if (this.$fs.exists(templateName)) {
-				const templateNameToBeTracked = this.$fs.exists(path.join(templateName, constants.PACKAGE_JSON_FILE_NAME)) ? packageJsonContent.name : path.basename(templateName);
+				const templateNameToBeTracked = (packageJsonContent && packageJsonContent.name) || path.basename(templateName);
 				return `${constants.ANALYTICS_LOCAL_TEMPLATE_PREFIX}${templateNameToBeTracked}`;
 			}
 

test/project-templates-service.ts

@@ -163,6 +163,8 @@ describe("project-templates-service", () => {
 				const localTemplatePath = `/Users/username/${templateName}`;
 				const fs = testInjector.resolve<IFileSystem>("fs");
 				fs.exists = (localPath: string): boolean => path.basename(localPath) !== constants.PACKAGE_JSON_FILE_NAME;
+				const pacoteService = testInjector.resolve<IPacoteService>("pacoteService");
+				pacoteService.manifest = () => Promise.resolve({ });
 				await projectTemplatesService.prepareTemplate(localTemplatePath, "tempFolder");
 				assert.deepEqual(dataSentToGoogleAnalytics, [
 					{