fix: fix get-file and list-files commands

Author: Fatme

lib/common/commands/device/get-file.ts

@@ -1,7 +1,7 @@
 export class GetFileCommand implements ICommand {
 	constructor(private $devicesService: Mobile.IDevicesService,
 		private $stringParameter: ICommandParameter,
-		private $project: Project.IProjectBase,
+		private $projectData: IProjectData,
 		private $errors: IErrors,
 		private $options: IOptions) { }
 
@@ -11,13 +11,17 @@ export class GetFileCommand implements ICommand {
 		await this.$devicesService.initialize({ deviceId: this.$options.device, skipInferPlatform: true });
 		let appIdentifier = args[1];
 
-		if (!appIdentifier && !this.$project.projectData) {
-			this.$errors.failWithoutHelp("Please enter application identifier or execute this command in project.");
+		if (!appIdentifier) {
+			this.$projectData.initializeProjectDataSafe();
+			if (!this.$projectData.projectIdentifiers) {
+				this.$errors.failWithoutHelp("Please enter application identifier or execute this command in project.");
+			}
 		}
 
-		appIdentifier = appIdentifier || this.$project.projectData.AppIdentifier;
-
-		const action = (device: Mobile.IDevice) => device.fileSystem.getFile(args[0], appIdentifier, this.$options.file);
+		const action = async (device: Mobile.IDevice) => {
+			appIdentifier = appIdentifier || this.$projectData.projectIdentifiers[device.deviceInfo.platform.toLowerCase()];
+			await device.fileSystem.getFile(args[0], appIdentifier, this.$options.file);
+		};
 		await this.$devicesService.execute(action);
 	}
 }

lib/common/commands/device/list-files.ts

@@ -2,7 +2,7 @@ export class ListFilesCommand implements ICommand {
 	constructor(private $devicesService: Mobile.IDevicesService,
 		private $stringParameter: ICommandParameter,
 		private $options: IOptions,
-		private $project: Project.IProjectBase,
+		private $projectData: IProjectData,
 		private $errors: IErrors) { }
 
 	public allowedParameters: ICommandParameter[] = [this.$stringParameter, this.$stringParameter];
@@ -12,13 +12,17 @@ export class ListFilesCommand implements ICommand {
 		const pathToList = args[0];
 		let appIdentifier = args[1];
 
-		if (!appIdentifier && !this.$project.projectData) {
-			this.$errors.failWithoutHelp("Please enter application identifier or execute this command in project.");
+		if (!appIdentifier) {
+			this.$projectData.initializeProjectDataSafe();
+			if (!this.$projectData.projectIdentifiers) {
+				this.$errors.failWithoutHelp("Please enter application identifier or execute this command in project.");
+			}
 		}
 
-		appIdentifier = appIdentifier || this.$project.projectData.AppIdentifier;
-
-		const action = (device: Mobile.IDevice) => device.fileSystem.listFiles(pathToList, appIdentifier);
+		const action = async (device: Mobile.IDevice) => {
+			appIdentifier = appIdentifier || this.$projectData.projectIdentifiers[device.deviceInfo.platform.toLowerCase()];
+			await device.fileSystem.listFiles(pathToList, appIdentifier);
+		};
 		await this.$devicesService.execute(action);
 	}
 }

lib/common/commands/device/put-file.ts

@@ -2,7 +2,7 @@ export class PutFileCommand implements ICommand {
 	constructor(private $devicesService: Mobile.IDevicesService,
 		private $stringParameter: ICommandParameter,
 		private $options: IOptions,
-		private $project: Project.IProjectBase,
+		private $projectData: IProjectData,
 		private $errors: IErrors) { }
 
 	allowedParameters: ICommandParameter[] = [this.$stringParameter, this.$stringParameter, this.$stringParameter];
@@ -11,12 +11,17 @@ export class PutFileCommand implements ICommand {
 		await this.$devicesService.initialize({ deviceId: this.$options.device, skipInferPlatform: true });
 		let appIdentifier = args[2];
 
-		if (!appIdentifier && !this.$project.projectData) {
-			this.$errors.failWithoutHelp("Please enter application identifier or execute this command in project.");
+		if (!appIdentifier) {
+			this.$projectData.initializeProjectDataSafe();
+			if (!this.$projectData.projectIdentifiers) {
+				this.$errors.failWithoutHelp("Please enter application identifier or execute this command in project.");
+			}
 		}
 
-		appIdentifier = appIdentifier || this.$project.projectData.AppIdentifier;
-		const action = (device: Mobile.IDevice) => device.fileSystem.putFile(args[0], args[1], appIdentifier);
+		const action = async (device: Mobile.IDevice) => {
+			appIdentifier = appIdentifier || this.$projectData.projectIdentifiers[device.deviceInfo.platform.toLowerCase()];
+			await device.fileSystem.putFile(args[0], args[1], appIdentifier);
+		};
 		await this.$devicesService.execute(action);
 	}
 }

lib/definitions/project.d.ts

@@ -104,6 +104,7 @@ interface IProjectData extends ICreateProjectData {
 	 * @returns {void}
 	 */
 	initializeProjectData(projectDir?: string): void;
+	initializeProjectDataSafe(projectDir?: string): void;
 	initializeProjectDataFromContent(packageJsonContent: string, nsconfigContent: string, projectDir?: string): void;
 	getAppDirectoryPath(projectDir?: string): string;
 	getAppDirectoryRelativePath(): string;

lib/project-data.ts

@@ -90,6 +90,14 @@ export class ProjectData implements IProjectData {
 		this.errorInvalidProject(projectDir);
 	}
 
+	public initializeProjectDataSafe(projectDir?: string): void {
+		try {
+			return this.initializeProjectData(projectDir);
+		} catch (err) {
+			// ignore the error
+		}
+	}
+
 	public initializeProjectDataFromContent(packageJsonContent: string, nsconfigContent: string, projectDir?: string): void {
 		projectDir = projectDir || this.$projectHelper.projectDir || "";
 		const projectFilePath = this.getProjectFilePath(projectDir);

test/stubs.ts

@@ -336,6 +336,9 @@ export class ProjectDataStub implements IProjectData {
 		this.projectIdentifiers = { android: "", ios: "" };
 		this.projectId = "";
 	}
+	public initializeProjectDataSafe(projectDir?: string): void {
+		this.initializeProjectData(projectDir);
+	}
 	public initializeProjectDataFromContent(): void {
 		return;
 	}