Merge pull request #4768 from NativeScript/tachev/remove-generated-files-on-migration

feat: remove the auto-generated js, js.map and css files during app migration

Author: rosen-vladimirov

lib/common/definitions/minimatch.d.ts

@@ -1,6 +1,7 @@
 import * as path from "path";
 import * as semver from "semver";
 import * as constants from "../constants";
+import * as glob from "glob";
 import { UpdateControllerBase } from "./update-controller-base";
 import { fromWindowsRelativePathToUnix } from "../common/helpers";
 
@@ -65,7 +66,8 @@ export class MigrateController extends UpdateControllerBase implements IMigrateC
 		{ packageName: "nativescript-vue", verifiedVersion: "2.3.0-rc.0" },
 		{ packageName: "nativescript-permissions", verifiedVersion: "1.3.0" },
 		{ packageName: "nativescript-cardview", verifiedVersion: "3.2.0" },
-		{ packageName: "nativescript-unit-test-runner", verifiedVersion: "0.6.3",
+		{
+			packageName: "nativescript-unit-test-runner", verifiedVersion: "0.6.3",
 			shouldMigrateAction: (projectData: IProjectData) => this.hasDependency({ packageName: "nativescript-unit-test-runner", isDev: false }, projectData),
 			migrateAction: this.migrateUnitTestRunner.bind(this)
 		}
@@ -92,6 +94,14 @@ export class MigrateController extends UpdateControllerBase implements IMigrateC
 			return;
 		}
 
+		try {
+			this.$logger.info("Backup auto-generated files.");
+			this.handleAutoGeneratedFiles(backupDir, projectData);
+			this.$logger.info("Backup auto-generated files complete.");
+		} catch (error) {
+			this.$logger.trace(`Error during auto-generated files handling. ${(error && error.message) || error}`);
+		}
+
 		try {
 			await this.cleanUpProject(projectData);
 			await this.migrateDependencies(projectData);
@@ -133,7 +143,7 @@ export class MigrateController extends UpdateControllerBase implements IMigrateC
 		}
 	}
 
-	private async cleanUpProject(projectData: IProjectData) {
+	private async cleanUpProject(projectData: IProjectData): Promise<void> {
 		this.$logger.info("Clean old project artefacts.");
 		this.$fs.deleteDirectory(path.join(projectData.projectDir, constants.HOOKS_DIR_NAME));
 		this.$fs.deleteDirectory(path.join(projectData.projectDir, constants.PLATFORMS_DIR_NAME));
@@ -147,6 +157,52 @@ export class MigrateController extends UpdateControllerBase implements IMigrateC
 		this.$logger.info("Clean old project artefacts complete.");
 	}
 
+	private handleAutoGeneratedFiles(backupDir: string, projectData: IProjectData): void {
+		const globOptions: glob.IOptions = {
+			silent: true,
+			nocase: true,
+			matchBase: true,
+			nodir: true,
+			absolute: false,
+			root: projectData.appDirectoryPath
+		};
+
+		const jsFiles = glob.sync("*.@(js|ts|js.map)", globOptions);
+		const autoGeneratedJsFiles = this.getGeneratedFiles(jsFiles, [".js"], [".ts"]);
+		const autoGeneratedJsMapFiles = this.getGeneratedFiles(jsFiles, [".map"], [""]);
+		const cssFiles = glob.sync("*.@(le|sa|sc|c)ss", globOptions);
+		const autoGeneratedCssFiles = this.getGeneratedFiles(cssFiles, [".css"], [".scss", ".sass", ".less"]);
+
+		const allGeneratedFiles = autoGeneratedJsFiles.concat(autoGeneratedJsMapFiles).concat(autoGeneratedCssFiles);
+		for (const generatedFile of allGeneratedFiles) {
+			const sourceFile = path.join(projectData.projectDir, generatedFile);
+			const destinationFile = path.join(backupDir, generatedFile);
+			const destinationFileDir = path.dirname(destinationFile);
+			this.$fs.ensureDirectoryExists(destinationFileDir);
+			this.$fs.rename(sourceFile, destinationFile);
+		}
+	}
+
+	private getGeneratedFiles(allFiles: string[], generatedFileExts: string[], sourceFileExts: string[]): string[] {
+		const autoGeneratedFiles = allFiles.filter(file => {
+			let isGenerated = false;
+			const { dir, name, ext } = path.parse(file);
+			if (generatedFileExts.indexOf(ext) > -1) {
+				for (const sourceExt of sourceFileExts) {
+					const possibleSourceFile = path.format({ dir, name, ext: sourceExt });
+					isGenerated = allFiles.indexOf(possibleSourceFile) > -1;
+					if (isGenerated) {
+						break;
+					}
+				}
+			}
+
+			return isGenerated;
+		});
+
+		return autoGeneratedFiles;
+	}
+
 	private async migrateDependencies(projectData: IProjectData): Promise<void> {
 		this.$logger.info("Start dependencies migration.");
 		for (let i = 0; i < this.migrationDependencies.length; i++) {