Merge pull request #3938 from NativeScript/tachev/fix-ios-freeze

fix: detach from the Native iOS debugger in order to avoid app freeze on unhandled exceptions

Author: Dimitar Tachev

lib/common/helpers.ts

@@ -463,11 +463,11 @@ export function getHash(str: string, options?: { algorithm?: string, encoding?:
 }
 
 export async function connectEventuallyUntilTimeout(factory: () => Promise<net.Socket>, timeout: number): Promise<net.Socket> {
-	return new Promise<net.Socket>(async(resolve, reject) => {
+	return new Promise<net.Socket>(async (resolve, reject) => {
 		let lastKnownError: Error;
 		let isResolved = false;
 
-		setTimeout(function () {
+		const connectionTimer = setTimeout(function () {
 			if (!isResolved) {
 				isResolved = true;
 				reject(lastKnownError);
@@ -484,13 +484,18 @@ export async function connectEventuallyUntilTimeout(factory: () => Promise<net.S
 				setTimeout(tryConnect, 1000);
 			};
 
-			const socket = await factory();
-			socket.on("connect", () => {
-				socket.removeListener("error", tryConnectAfterTimeout);
-				isResolved = true;
-				resolve(socket);
-			});
-			socket.on("error", tryConnectAfterTimeout);
+			try {
+				const socket = await factory();
+				socket.on("connect", () => {
+					socket.removeListener("error", tryConnectAfterTimeout);
+					isResolved = true;
+					clearTimeout(connectionTimer);
+					resolve(socket);
+				});
+				socket.on("error", tryConnectAfterTimeout);
+			} catch (e) {
+				lastKnownError = e;
+			}
 		}
 
 		await tryConnect();

lib/services/ios-debug-service.ts

@@ -142,6 +142,7 @@ export class IOSDebugService extends DebugServiceBase implements IPlatformDebugS
 		}
 		this._lldbProcess.stderr.pipe(process.stderr);
 		this._lldbProcess.stdin.write("process continue\n");
+		this._lldbProcess.stdin.write("detach\n");
 
 		return this.wireDebuggerClient(debugData, debugOptions);
 	}

npm-shrinkwrap.json

@@ -42,7 +42,7 @@
     "gaze": "1.1.0",
     "iconv-lite": "0.4.11",
     "inquirer": "0.9.0",
-    "ios-device-lib": "0.4.14",
+    "ios-device-lib": "0.4.15",
     "ios-mobileprovision-finder": "1.0.10",
     "ios-sim-portable": "4.0.2",
     "istextorbinary": "2.2.1",