feat: Speed up device detection

Speed up device detection by:
* removing duplicate calls to all device detection services
* cache the Promise of initialize method - this way even when multiple calls are executed simultaneously, the result of the first one will be used. This allows Sidekick to call the method asynchronously.
* do not execute iOS device detection login in case `--emulator` is passed

Remove several public methods from the service - make them protected as we already have tests for them.
Remove all calls to detectCurrentlyAttachedDevices method outside of the service - the initialize method will do it anyway, so no need to call it externally.
Remove duplicate calls in the startLookingForDevices method - previously it had to filter which device detection services to call. As now each device detection service checks its platform, we can safely call all of them and rely on their filters to skip the execution.

Author: rosen-vladimirov

lib/commands/debug.ts

@@ -35,8 +35,6 @@ export class DebugPlatformCommand implements ICommand {
 			return;
 		}
 
-		await this.$devicesService.detectCurrentlyAttachedDevices({ shouldReturnImmediateResult: false, platform: this.platform });
-
 		await this.$liveSyncCommandHelper.executeLiveSyncOperation([selectedDeviceForDebug], this.platform, {
 			deviceDebugMap: {
 				[selectedDeviceForDebug.deviceInfo.identifier]: true
@@ -52,8 +50,6 @@ export class DebugPlatformCommand implements ICommand {
 			this.$errors.fail(DebugCommandErrors.UNABLE_TO_USE_FOR_DEVICE_AND_EMULATOR);
 		}
 
-		await this.$devicesService.detectCurrentlyAttachedDevices({ platform: this.platform, shouldReturnImmediateResult: false });
-
 		if (this.$options.device) {
 			const device = await this.$devicesService.getDevice(this.$options.device);
 			return device;

lib/common

@@ -405,9 +405,6 @@ interface IPlatformTemplate {
 	platformTemplate: string;
 }
 
-interface IEmulator {
-	emulator: boolean;
-}
 
 interface IClean {
 	clean: boolean;
@@ -449,7 +446,7 @@ interface IPort {
 	port: Number;
 }
 
-interface IOptions extends ICommonOptions, IBundleString, IPlatformTemplate, IEmulator, IClean, IProvision, ITeamIdentifier, IAndroidReleaseOptions, INpmInstallConfigurationOptions, IPort, IEnvOptions {
+interface IOptions extends ICommonOptions, IBundleString, IPlatformTemplate, IHasEmulatorOption, IClean, IProvision, ITeamIdentifier, IAndroidReleaseOptions, INpmInstallConfigurationOptions, IPort, IEnvOptions {
 	all: boolean;
 	client: boolean;
 	compileSdk: number;
@@ -482,7 +479,7 @@ interface IAppFilesUpdaterOptions extends IBundle, IRelease, IOptionalWatchAllFi
 
 interface IPlatformBuildData extends IAppFilesUpdaterOptions, IBuildConfig, IEnvOptions { }
 
-interface IDeviceEmulator extends IEmulator, IDeviceIdentifier { }
+interface IDeviceEmulator extends IHasEmulatorOption, IDeviceIdentifier { }
 
 interface IRunPlatformOptions extends IJustLaunch, IDeviceEmulator { }
 

lib/declarations.d.ts

@@ -21,15 +21,15 @@ export class LiveSyncCommandHelper implements ILiveSyncCommandHelper {
 	}
 
 	public async executeCommandLiveSync(platform?: string, additionalOptions?: ILiveSyncCommandHelperAdditionalOptions) {
+		const emulator = this.$options.emulator;
 		await this.$devicesService.initialize({
 			deviceId: this.$options.device,
-			platform: platform,
-			emulator: this.$options.emulator,
+			platform,
+			emulator,
 			skipDeviceDetectionInterval: true,
 			skipInferPlatform: !platform
 		});
 
-		await this.$devicesService.detectCurrentlyAttachedDevices({ shouldReturnImmediateResult: false, platform: platform });
 		const devices = this.$devicesService.getDeviceInstances()
 			.filter(d => !platform || d.deviceInfo.platform.toLowerCase() === platform.toLowerCase());
 

lib/helpers/livesync-command-helper.ts

@@ -44,7 +44,6 @@ class TestExecutionService implements ITestExecutionService {
 						deviceId: this.$options.device,
 						emulator: this.$options.emulator
 					});
-					await this.$devicesService.detectCurrentlyAttachedDevices();
 					const projectFilesPath = path.join(platformData.appDestinationDirectoryPath, constants.APP_FOLDER_NAME);
 
 					const configOptions: IKarmaConfigOptions = JSON.parse(launcherConfig);

lib/services/test-execution-service.ts

@@ -36,7 +36,6 @@ function createTestInjector(): IInjector {
 	});
 	testInjector.register('devicesService', {
 		initialize: async () => { /* Intentionally left blank */ },
-		detectCurrentlyAttachedDevices: async () => { /* Intentionally left blank */ },
 		getDeviceInstances: (): any[] => { return []; },
 		execute: async (): Promise<any> => ({})
 	});