Merge pull request #18 from NativeScript/vladimirov/fix-get-cli-version

rosen-vladimirov · web-flow · commit 8800c00d40d5 · 2017-03-28T01:00:53.000+03:00
Fix getting the version of nativescript-cloud when it is not installed
diff --git a/lib/sys-info.ts b/lib/sys-info.ts
@@ -301,7 +301,7 @@ export class SysInfo implements NativeScriptDoctor.ISysInfo {
 	public getNativeScriptCloudVersion(): Promise<string> {
 		return this.getValueForProperty(() => this.nativeScriptCloudVersionCache, async (): Promise<string> => {
 			const output = await this.execCommand("tns cloud lib version");
-			return output ? output.trim() : output;
+			return output ? this.getVersionFromString(output.trim()) : output;
 		});
 	}
 
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "nativescript-doctor",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "description": "Library that helps identifying if the environment can be used for development of {N} apps.",
   "main": "lib/index.js",
   "types": "./typings/nativescript-doctor.d.ts",

Original file line number	Diff line number	Diff line change
`@@ -301,7 +301,7 @@ export class SysInfo implements NativeScriptDoctor.ISysInfo {`
`301`	`301`	`public getNativeScriptCloudVersion(): Promise<string> {`
`302`	`302`	`return this.getValueForProperty(() => this.nativeScriptCloudVersionCache, async (): Promise<string> => {`
`303`	`303`	`const output = await this.execCommand("tns cloud lib version");`
`304`		`- return output ? output.trim() : output;`
	`304`	`+ return output ? this.getVersionFromString(output.trim()) : output;`
`305`	`305`	`});`
`306`	`306`	`}`
`307`	`307`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "nativescript-doctor",`
`3`		`- "version": "0.4.0",`
	`3`	`+ "version": "0.4.1",`
`4`	`4`	`"description": "Library that helps identifying if the environment can be used for development of {N} apps.",`
`5`	`5`	`"main": "lib/index.js",`
`6`	`6`	`"types": "./typings/nativescript-doctor.d.ts",`