chore: enable the deprecation TsLint check

Author: DimitarTachev

lib/common/child-process.ts

@@ -9,7 +9,7 @@ export class ChildProcess extends EventEmitter implements IChildProcess {
 
 	public async exec(command: string, options?: any, execOptions?: IExecOptions): Promise<any> {
 		return new Promise<any>((resolve, reject) => {
-			const callback = (error: Error, stdout: string | NodeBuffer, stderr: string | NodeBuffer) => {
+			const callback = (error: Error, stdout: string | Buffer, stderr: string | Buffer) => {
 				this.$logger.trace("Exec %s \n stdout: %s \n stderr: %s", command, stdout.toString(), stderr.toString());
 
 				if (error) {
@@ -33,7 +33,7 @@ export class ChildProcess extends EventEmitter implements IChildProcess {
 		this.$logger.debug("execFile: %s %s", command, this.getArgumentsAsQuotedString(args));
 
 		return new Promise<any>((resolve, reject) => {
-			child_process.execFile(command, args, (error: any, stdout: string | NodeBuffer) => {
+			child_process.execFile(command, args, (error: any, stdout: string | Buffer) => {
 				if (error) {
 					reject(error);
 				} else {

lib/common/declarations.d.ts

@@ -561,11 +561,11 @@ interface IErrors {
 	fail(formatStr: string, ...args: any[]): never;
 	fail(opts: IFailOptions, ...args: any[]): never;
 	/**
-	 * DEPRECATED: use `fail` instead
+	 * @deprecated: use `fail` instead
 	 */
 	failWithoutHelp(message: string, ...args: any[]): never;
 	/**
-	 * DEPRECATED: use `fail` instead
+	 * @deprecated: use `fail` instead
 	 */
 	failWithoutHelp(opts: IFailOptions, ...args: any[]): never;
 	failWithHelp(formatStr: string, ...args: any[]): never;

lib/common/file-system.ts

@@ -177,7 +177,7 @@ export class FileSystem implements IFileSystem {
 		return fs.readdirSync(path);
 	}
 
-	public readFile(filename: string, options?: IReadFileOptions): string | NodeBuffer {
+	public readFile(filename: string, options?: IReadFileOptions): string | Buffer {
 		return fs.readFileSync(filename, options);
 	}
 
@@ -203,7 +203,7 @@ export class FileSystem implements IFileSystem {
 		return null;
 	}
 
-	public writeFile(filename: string, data: string | NodeBuffer, encoding?: string): void {
+	public writeFile(filename: string, data: string | Buffer, encoding?: string): void {
 		this.createDirectory(dirname(filename));
 		fs.writeFileSync(filename, data, { encoding: encoding });
 	}
@@ -390,7 +390,7 @@ export class FileSystem implements IFileSystem {
 			const logger: ILogger = this.$injector.resolve("$logger");
 			const shasumData = crypto.createHash(algorithm);
 			const fileStream = this.createReadStream(fileName);
-			fileStream.on("data", (data: NodeBuffer | string) => {
+			fileStream.on("data", (data: Buffer | string) => {
 				shasumData.update(data);
 			});
 

lib/common/mobile/android/android-debug-bridge.ts

@@ -66,11 +66,11 @@ export class AndroidDebugBridge implements Mobile.IAndroidDebugBridge {
 			let errorData = "";
 			let isSettled = false;
 
-			result.stdout.on("data", (data: NodeBuffer) => {
+			result.stdout.on("data", (data: Buffer) => {
 				adbData += data.toString();
 			});
 
-			result.stderr.on("data", (data: NodeBuffer) => {
+			result.stderr.on("data", (data: Buffer) => {
 				errorData += (data || "").toString();
 			});
 

lib/common/mobile/android/logcat-helper.ts

@@ -33,7 +33,7 @@ export class LogcatHelper implements Mobile.ILogcatHelper {
 			const lineStream = byline(logcatStream.stdout);
 			this.mapDevicesLoggingData[deviceIdentifier].loggingProcess = logcatStream;
 			this.mapDevicesLoggingData[deviceIdentifier].lineStream = lineStream;
-			logcatStream.stderr.on("data", (data: NodeBuffer) => {
+			logcatStream.stderr.on("data", (data: Buffer) => {
 				this.$logger.trace("ADB logcat stderr: " + data.toString());
 			});
 
@@ -49,7 +49,7 @@ export class LogcatHelper implements Mobile.ILogcatHelper {
 				}
 			});
 
-			lineStream.on('data', (line: NodeBuffer) => {
+			lineStream.on('data', (line: Buffer) => {
 				const lineText = line.toString();
 				this.$deviceLogProvider.logData(lineText, this.$devicePlatformsConstants.Android, deviceIdentifier);
 			});
@@ -61,7 +61,7 @@ export class LogcatHelper implements Mobile.ILogcatHelper {
 		const logcatDumpStream = await adb.executeCommand(["logcat", "-d"], { returnChildProcess: true });
 
 		const lineStream = byline(logcatDumpStream.stdout);
-		lineStream.on('data', (line: NodeBuffer) => {
+		lineStream.on('data', (line: Buffer) => {
 			const lineText = line.toString();
 			this.$logger.trace(lineText);
 		});

lib/common/mobile/ios/simulator/ios-simulator-log-provider.ts

@@ -10,9 +10,9 @@ export class IOSSimulatorLogProvider extends EventEmitter implements Mobile.IiOS
 		private $logger: ILogger,
 		private $devicePlatformsConstants: Mobile.IDevicePlatformsConstants,
 		private $deviceLogProvider: Mobile.IDeviceLogProvider) {
-			super();
-			this.shouldDispose = true;
-		}
+		super();
+		this.shouldDispose = true;
+	}
 
 	public setShouldDispose(shouldDispose: boolean) {
 		this.shouldDispose = shouldDispose;
@@ -22,7 +22,7 @@ export class IOSSimulatorLogProvider extends EventEmitter implements Mobile.IiOS
 		if (!this.simulatorsLoggingEnabled[deviceId]) {
 			const deviceLogChildProcess: ChildProcess = await this.$iOSSimResolver.iOSSim.getDeviceLogProcess(deviceId, options ? options.predicate : null);
 
-			const action = (data: NodeBuffer | string) => {
+			const action = (data: Buffer | string) => {
 				const message = data.toString();
 				this.$deviceLogProvider.logData(message, this.$devicePlatformsConstants.iOS, deviceId);
 			};

lib/services/livesync/android-livesync-tool.ts

@@ -274,11 +274,11 @@ export class AndroidLivesyncTool implements IAndroidLivesyncTool {
 		return true;
 	}
 
-	private handleConnection({ socket, data }: { socket: ILiveSyncSocket, data: NodeBuffer | string }) {
+	private handleConnection({ socket, data }: { socket: ILiveSyncSocket, data: Buffer | string }) {
 		this.socketConnection = socket;
 		this.socketConnection.uid = this.generateOperationIdentifier();
 
-		const versionLength = (<NodeBuffer>data).readUInt8(0);
+		const versionLength = (<Buffer>data).readUInt8(0);
 		const versionBuffer = data.slice(PROTOCOL_VERSION_LENGTH_SIZE, versionLength + PROTOCOL_VERSION_LENGTH_SIZE);
 		const appIdentifierBuffer = data.slice(versionLength + PROTOCOL_VERSION_LENGTH_SIZE, data.length);
 
@@ -287,7 +287,7 @@ export class AndroidLivesyncTool implements IAndroidLivesyncTool {
 		this.$logger.trace(`Handle socket connection for app identifier: ${appIdentifier} with protocol version: ${protocolVersion}.`);
 		this.protocolVersion = protocolVersion;
 
-		this.socketConnection.on("data", (connectionData: NodeBuffer) => this.handleData(socket.uid, connectionData));
+		this.socketConnection.on("data", (connectionData: Buffer) => this.handleData(socket.uid, connectionData));
 		this.socketConnection.on("close", (hasError: boolean) => this.handleSocketClose(socket.uid, hasError));
 		this.socketConnection.on("error", (err: Error) => {
 			const error = new Error(`Socket Error:\n${err}`);
@@ -299,7 +299,7 @@ export class AndroidLivesyncTool implements IAndroidLivesyncTool {
 		});
 	}
 
-	private connectEventuallyUntilTimeout(factory: () => ILiveSyncSocket, timeout: number): Promise<{ socket: ILiveSyncSocket, data: NodeBuffer | string }> {
+	private connectEventuallyUntilTimeout(factory: () => ILiveSyncSocket, timeout: number): Promise<{ socket: ILiveSyncSocket, data: Buffer | string }> {
 		return new Promise((resolve, reject) => {
 			let lastKnownError: Error | string,
 				isConnected = false;

lib/services/livesync/ios-device-livesync-service.ts

@@ -117,7 +117,7 @@ export class IOSDeviceLiveSyncService extends DeviceLiveSyncServiceBase implemen
 			this.$logger.trace(`Socket error received: ${error}`);
 		});
 
-		this.socket.on("data", (data: NodeBuffer | string) => {
+		this.socket.on("data", (data: Buffer | string) => {
 			this.$logger.trace(`Socket sent data: ${data.toString()}`);
 		});
 	}

test/stubs.ts

@@ -85,7 +85,7 @@ export class FileSystemStub implements IFileSystem {
 		return undefined;
 	}
 
-	readFile(filename: string): NodeBuffer | string {
+	readFile(filename: string): Buffer | string {
 		return undefined;
 	}
 

tslint.json

@@ -1,6 +1,7 @@
 {
 	"rulesDirectory": "node_modules/tslint-microsoft-contrib",
 	"rules": {
+		"deprecation": true,
 		"class-name": true,
 		"curly": true,
 		"eofline": true,