Merge pull request #3959 from NativeScript/tachev/update-prompter

chore: update inquirer to the latest version

Author: Dimitar Tachev

lib/common/commands/proxy/proxy-set.ts

@@ -4,6 +4,7 @@ import { ProxyCommandBase } from "./proxy-base";
 import { HttpProtocolToPort } from "../../constants";
 import { parse } from "url";
 import { platform, EOL } from "os";
+import * as prompt from "inquirer";
 const { getCredentialsFromAuth } = require("proxy-lib/lib/utils");
 
 const proxySetCommandName = "proxy|set";
@@ -121,7 +122,7 @@ export class ProxySetCommand extends ProxyCommandBase {
 
 	private async getPortFromUserInput(): Promise<number> {
 		const schemaName = "port";
-		const schema: IPromptSchema = {
+		const schema: prompt.Question = {
 			message: "Port",
 			type: "input",
 			name: schemaName,

lib/common/declarations.d.ts

@@ -721,14 +721,6 @@ interface IPrompterOptions extends IAllowEmpty {
 	defaultAction?: () => string
 }
 
-interface IPrompter extends IDisposable {
-	get(schemas: IPromptSchema[]): Promise<any>;
-	getPassword(prompt: string, options?: IAllowEmpty): Promise<string>;
-	getString(prompt: string, options?: IPrompterOptions): Promise<string>;
-	promptForChoice(promptMessage: string, choices: any[]): Promise<string>;
-	confirm(prompt: string, defaultAction?: () => boolean): Promise<boolean>;
-}
-
 interface IAnalyticsSettingsService {
 	canDoRequest(): Promise<boolean>;
 	getUserId(): Promise<string>;

lib/common/definitions/prompt.d.ts

@@ -14,45 +14,34 @@ export class Prompter implements IPrompter {
 		}
 	}
 
-	public async get(schemas: IPromptSchema[]): Promise<any> {
-		let promptResult: any;
-
+	public async get(questions: prompt.Question[]): Promise<any> {
 		try {
-			promptResult = await new Promise<any>((resolve, reject) => {
 				this.muteStdout();
 
 				if (!helpers.isInteractive()) {
-					if (_.some(schemas, s => !s.default)) {
-						reject(new Error("Console is not interactive and no default action specified."));
+					if (_.some(questions, s => !s.default)) {
+						throw new Error("Console is not interactive and no default action specified.");
 					} else {
 						const result: any = {};
 
-						_.each(schemas, s => {
+						_.each(questions, s => {
 							// Curly brackets needed because s.default() may return false and break the loop
 							result[s.name] = s.default();
 						});
 
-						resolve(result);
+						return result;
 					}
 				} else {
-					prompt.prompt(schemas, (result: any) => {
-						if (result) {
-							resolve(result);
-						} else {
-							reject(new Error(`Unable to get result from prompt: ${result}`));
-						}
-					});
+					const result = await prompt.prompt(questions);
+					return result;
 				}
-			});
 		} finally {
 			this.unmuteStdout();
 		}
-
-		return promptResult;
 	}
 
 	public async getPassword(prompt: string, options?: IAllowEmpty): Promise<string> {
-		const schema: IPromptSchema = {
+		const schema: prompt.Question = {
 			message: prompt,
 			type: "password",
 			name: "password",
@@ -67,7 +56,7 @@ export class Prompter implements IPrompter {
 	}
 
 	public async getString(prompt: string, options?: IPrompterOptions): Promise<string> {
-		const schema: IPromptSchema = {
+		const schema: prompt.Question = {
 			message: prompt,
 			type: "input",
 			name: "inputString",
@@ -83,7 +72,7 @@ export class Prompter implements IPrompter {
 	}
 
 	public async promptForChoice(promptMessage: string, choices: any[]): Promise<string> {
-		const schema: IPromptSchema = {
+		const schema: prompt.Question = {
 			message: promptMessage,
 			type: "list",
 			name: "userAnswer",