chore: fix PR comments

Author: Fatme

lib/definitions/plugins.d.ts

@@ -15,6 +15,7 @@ interface IPluginsService {
 	validate(platformData: IPlatformData, projectData: IProjectData): Promise<void>;
 	preparePluginNativeCode(pluginData: IPluginData, platform: string, projectData: IProjectData): Promise<void>;
 	convertToPluginData(cacheData: any, projectDir: string): IPluginData;
+	isNativeScriptPlugin(pluginName: string, projectData: IProjectData): boolean;
 }
 
 interface IPackageJsonDepedenciesResult {

lib/services/livesync/playground/preview-app-plugins-service.ts

@@ -4,12 +4,14 @@ import * as util from "util";
 import { Device } from "nativescript-preview-sdk";
 import { PluginComparisonMessages } from "./preview-app-constants";
 import { NODE_MODULES_DIR_NAME } from "../../../common/constants";
+import { PLATFORMS_DIR_NAME } from "../../../constants";
 
 export class PreviewAppPluginsService implements IPreviewAppPluginsService {
 	private previewAppVersionWarnings: IDictionary<string[]> = {};
 
 	constructor(private $fs: IFileSystem,
 		private $logger: ILogger,
+		private $pluginsService: IPluginsService,
 		private $projectData: IProjectData) { }
 
 	public async comparePluginsOnDevice(data: IPreviewAppLiveSyncData, device: Device): Promise<void> {
@@ -91,17 +93,11 @@ export class PreviewAppPluginsService implements IPreviewAppPluginsService {
 	}
 
 	private isNativeScriptPluginWithoutNativeCode(localPlugin: string, platform: string): boolean {
-		return this.isNativeScriptPlugin(localPlugin) && !this.hasNativeCode(localPlugin, platform);
-	}
-
-	private isNativeScriptPlugin(localPlugin: string): boolean {
-		const pluginPackageJsonPath = path.join(this.$projectData.projectDir, NODE_MODULES_DIR_NAME, localPlugin, "package.json");
-		const pluginPackageJsonContent = this.$fs.readJson(pluginPackageJsonPath);
-		return pluginPackageJsonContent && pluginPackageJsonContent.nativescript;
+		return this.$pluginsService.isNativeScriptPlugin(localPlugin, this.$projectData) && !this.hasNativeCode(localPlugin, platform);
 	}
 
 	private hasNativeCode(localPlugin: string, platform: string): boolean {
-		const nativeFolderPath = path.join(this.$projectData.projectDir, NODE_MODULES_DIR_NAME, localPlugin, "platforms", platform.toLowerCase());
+		const nativeFolderPath = path.join(this.$projectData.projectDir, NODE_MODULES_DIR_NAME, localPlugin, PLATFORMS_DIR_NAME, platform.toLowerCase());
 		return this.$fs.exists(nativeFolderPath) && !this.$fs.isEmptyDir(nativeFolderPath);
 	}
 }

lib/services/plugins-service.ts

@@ -2,6 +2,7 @@ import * as path from "path";
 import * as shelljs from "shelljs";
 import * as semver from "semver";
 import * as constants from "../constants";
+import { NODE_MODULES_DIR_NAME } from "../common/constants";
 
 export class PluginsService implements IPluginsService {
 	private static INSTALL_COMMAND_NAME = "install";
@@ -207,6 +208,12 @@ export class PluginsService implements IPluginsService {
 		};
 	}
 
+	public isNativeScriptPlugin(pluginName: string, projectData: IProjectData): boolean {
+		const pluginPackageJsonPath = path.join(projectData.projectDir, NODE_MODULES_DIR_NAME, pluginName, "package.json");
+		const pluginPackageJsonContent = this.$fs.readJson(pluginPackageJsonPath);
+		return pluginPackageJsonContent && pluginPackageJsonContent.nativescript;
+	}
+
 	private getBasicPluginInformation(dependencies: any): IBasePluginData[] {
 		return _.map(dependencies, (version: string, key: string) => ({
 			name: key,

test/services/playground/preview-app-plugins-service.ts

@@ -34,6 +34,11 @@ function createTestInjector(localPlugins: IStringDictionary, options?: { isNativ
 			return !options.hasPluginNativeCode;
 		}
 	});
+	injector.register("pluginsService", {
+		isNativeScriptPlugin: () => {
+			return options.isNativeScriptPlugin;
+		}
+	});
 	injector.register("logger", {
 		trace: () => ({}),
 		warn: (message: string) =>  warnParams.push(message)