Use sync version of fs.exists

We use fs.exists, which is deprecated. Change the code to use fs.existsSync instead. This makes the `$fs.exists` method to return boolean instead of `IFuture<boolean>`.
Several methods were declared as `IFuture<T>` as in their body they are calling `$fs.exists(...).wait()`. As now the `$fs.exists` method is sync, change all methods that are async only because of `$fs.exists().wait()` sync.

Author: rosen-vladimirov

lib/android-tools-info.ts

@@ -42,7 +42,7 @@ export class AndroidToolsInfo implements IAndroidToolsInfo {
 				this.showWarningsAsErrors = options.showWarningsAsErrors;
 			}
 			if (!this.pathToAndroidExecutable) {
-				if (this.validateAndroidHomeEnvVariable(this.androidHome).wait()) {
+				if (this.validateAndroidHomeEnvVariable(this.androidHome)) {
 					let androidPath = path.join(this.androidHome, "tools", this.androidExecutableName);
 					if (!this.trySetAndroidPath(androidPath).wait() && !this.trySetAndroidPath(this.androidExecutableName).wait()) {
 						this.printMessage(`Unable to find "${this.androidExecutableName}" executable file. Make sure you have set ANDROID_HOME environment variable correctly.`);
@@ -100,7 +100,7 @@ export class AndroidToolsInfo implements IAndroidToolsInfo {
 			let detectedErrors = false;
 			this.showWarningsAsErrors = options && options.showWarningsAsErrors;
 			let toolsInfoData = this.getToolsInfo().wait();
-			let isAndroidHomeValid = this.validateAndroidHomeEnvVariable(toolsInfoData.androidHomeEnvVar).wait();
+			let isAndroidHomeValid = this.validateAndroidHomeEnvVariable(toolsInfoData.androidHomeEnvVar);
 			if (!toolsInfoData.compileSdkVersion) {
 				this.printMessage(`Cannot find a compatible Android SDK for compilation. To be able to build for Android, install Android SDK ${AndroidToolsInfo.MIN_REQUIRED_COMPILE_TARGET} or later.`,
 					"Run `$ android` to manage your Android SDK versions.");
@@ -261,7 +261,7 @@ export class AndroidToolsInfo implements IAndroidToolsInfo {
 	private getMatchingDir(pathToDir: string, versionRange: string): IFuture<string> {
 		return ((): string => {
 			let selectedVersion: string;
-			if (this.$fs.exists(pathToDir).wait()) {
+			if (this.$fs.exists(pathToDir)) {
 				let subDirs = this.$fs.readDirectory(pathToDir).wait();
 				this.$logger.trace(`Directories found in ${pathToDir} are ${subDirs.join(", ")}`);
 
@@ -366,25 +366,23 @@ export class AndroidToolsInfo implements IAndroidToolsInfo {
 	}
 
 	private _cachedAndroidHomeValidationResult: boolean = null;
-	private validateAndroidHomeEnvVariable(androidHomeEnvVar: string): IFuture<boolean> {
-		return ((): boolean => {
-			if (this._cachedAndroidHomeValidationResult === null) {
-				this._cachedAndroidHomeValidationResult = true;
-				let expectedDirectoriesInAndroidHome = ["build-tools", "tools", "platform-tools", "extras"];
-				if (!androidHomeEnvVar || !this.$fs.exists(androidHomeEnvVar).wait()) {
-					this.printMessage("The ANDROID_HOME environment variable is not set or it points to a non-existent directory. You will not be able to perform any build-related operations for Android.",
-						"To be able to perform Android build-related operations, set the `ANDROID_HOME` variable to point to the root of your Android SDK installation directory.");
-					this._cachedAndroidHomeValidationResult = false;
-				} else if (!_.some(expectedDirectoriesInAndroidHome.map(dir => this.$fs.exists(path.join(androidHomeEnvVar, dir)).wait()))) {
-					this.printMessage("The ANDROID_HOME environment variable points to incorrect directory. You will not be able to perform any build-related operations for Android.",
-						"To be able to perform Android build-related operations, set the `ANDROID_HOME` variable to point to the root of your Android SDK installation directory, " +
-						"where you will find `tools` and `platform-tools` directories.");
-					this._cachedAndroidHomeValidationResult = false;
-				}
+	private validateAndroidHomeEnvVariable(androidHomeEnvVar: string): boolean {
+		if (this._cachedAndroidHomeValidationResult === null) {
+			this._cachedAndroidHomeValidationResult = true;
+			let expectedDirectoriesInAndroidHome = ["build-tools", "tools", "platform-tools", "extras"];
+			if (!androidHomeEnvVar || !this.$fs.exists(androidHomeEnvVar)) {
+				this.printMessage("The ANDROID_HOME environment variable is not set or it points to a non-existent directory. You will not be able to perform any build-related operations for Android.",
+					"To be able to perform Android build-related operations, set the `ANDROID_HOME` variable to point to the root of your Android SDK installation directory.");
+				this._cachedAndroidHomeValidationResult = false;
+			} else if (!_.some(expectedDirectoriesInAndroidHome.map(dir => this.$fs.exists(path.join(androidHomeEnvVar, dir))))) {
+				this.printMessage("The ANDROID_HOME environment variable points to incorrect directory. You will not be able to perform any build-related operations for Android.",
+					"To be able to perform Android build-related operations, set the `ANDROID_HOME` variable to point to the root of your Android SDK installation directory, " +
+					"where you will find `tools` and `platform-tools` directories.");
+				this._cachedAndroidHomeValidationResult = false;
 			}
+		}
 
-			return this._cachedAndroidHomeValidationResult;
-		}).future<boolean>()();
+		return this._cachedAndroidHomeValidationResult;
 	}
 }
 $injector.register("androidToolsInfo", AndroidToolsInfo);

lib/commands/install.ts

@@ -49,7 +49,7 @@ export class InstallCommand implements ICommand {
 			let projectDir = this.$projectData.projectDir;
 
 			let devPrefix = 'nativescript-dev-';
-			if (!this.$fs.exists(moduleName).wait() && moduleName.indexOf(devPrefix) !== 0) {
+			if (!this.$fs.exists(moduleName) && moduleName.indexOf(devPrefix) !== 0) {
 				moduleName = devPrefix + moduleName;
 			}
 

lib/commands/list-platforms.ts

@@ -9,7 +9,7 @@ export class ListPlatformsCommand implements ICommand {
 			let installedPlatforms = this.$platformService.getInstalledPlatforms().wait();
 
 			if(installedPlatforms.length > 0) {
-				let preparedPlatforms = this.$platformService.getPreparedPlatforms().wait();
+				let preparedPlatforms = this.$platformService.getPreparedPlatforms();
 				if(preparedPlatforms.length > 0) {
 					this.$logger.out("The project is prepared for: ", helpers.formatListOfNames(preparedPlatforms, "and"));
 				} else {

lib/commands/test-init.ts

@@ -41,7 +41,7 @@ class TestInitCommand implements ICommand {
 
 			let testsDir = path.join(projectDir, 'app/tests');
 			let shouldCreateSampleTests = true;
-			if (this.$fs.exists(testsDir).wait()) {
+			if (this.$fs.exists(testsDir)) {
 				this.$logger.info('app/tests/ directory already exists, will not create an example test project.');
 				shouldCreateSampleTests = false;
 			}
@@ -59,7 +59,7 @@ class TestInitCommand implements ICommand {
 
 			let exampleFilePath = this.$resources.resolvePath(`test/example.${frameworkToInstall}.js`);
 
-			if (shouldCreateSampleTests && this.$fs.exists(exampleFilePath).wait()) {
+			if (shouldCreateSampleTests && this.$fs.exists(exampleFilePath)) {
 				this.$fs.copyFile(exampleFilePath, path.join(testsDir, 'example.js')).wait();
 				this.$logger.info('\nExample test file created in app/tests/'.yellow);
 			} else {

lib/common

@@ -2,7 +2,13 @@ interface IPlatformService {
 	addPlatforms(platforms: string[]): IFuture<void>;
 	getInstalledPlatforms(): IFuture<string[]>;
 	getAvailablePlatforms(): IFuture<string[]>;
-	getPreparedPlatforms(): IFuture<string[]>;
+
+	/**
+	 * Returns a list of all currently prepared platforms.
+	 * @returns {string[]} List of all prepared platforms.
+	 */
+	getPreparedPlatforms(): string[];
+
 	removePlatforms(platforms: string[]): IFuture<void>;
 	updatePlatforms(platforms: string[]): IFuture<void>;
 	preparePlatform(platform: string, force?: boolean, skipModulesAndResources?: boolean): IFuture<boolean>;

lib/definitions/platform.d.ts

@@ -74,7 +74,14 @@ interface IPlatformProjectService {
 	buildProject(projectRoot: string, buildConfig?: IBuildConfig): IFuture<void>;
 	prepareProject(): IFuture<void>;
 	prepareAppResources(appResourcesDirectoryPath: string): IFuture<void>;
-	isPlatformPrepared(projectRoot: string): IFuture<boolean>;
+
+	/**
+	 * Defines if current platform is prepared (i.e. if <project dir>/platforms/<platform> dir exists).
+	 * @param {string} projectRoot The project directory (path where root's package.json is located).
+	 * @returns {boolean} True in case platform is prepare (i.e. if <project dir>/platforms/<platform> dir exists), false otherwise.
+	 */
+	isPlatformPrepared(projectRoot: string): boolean;
+
 	canUpdatePlatform(newInstalledModuleDir: string): IFuture<boolean>;
 	preparePluginNativeCode(pluginData: IPluginData, options?: any): IFuture<void>;
 	removePluginNativeCode(pluginData: IPluginData): IFuture<void>;

lib/definitions/project.d.ts

@@ -1,16 +1,15 @@
 import * as constants from './constants';
-import Future = require("fibers/future");
 
 export class DynamicHelpProvider implements IDynamicHelpProvider {
-	public isProjectType(args: string[]): IFuture<boolean> {
-		return Future.fromResult(true);
+	public isProjectType(args: string[]): boolean {
+		return true;
 	}
 
-	public getLocalVariables(options: { isHtml: boolean }): IFuture<IDictionary<any>> {
+	public getLocalVariables(options: { isHtml: boolean }): IDictionary<any> {
 		let localVariables: IDictionary<any> = {
 			constants: constants
 		};
-		return Future.fromResult(localVariables);
+		return localVariables;
 	}
 }
 $injector.register("dynamicHelpProvider", DynamicHelpProvider);

lib/dynamic-help-provider.ts

@@ -39,7 +39,7 @@ export class NodePackageManager implements INodePackageManager {
 				let relativePathFromCwdToSource = "";
 				if(this.$options.frameworkPath) {
 					relativePathFromCwdToSource = path.relative(this.$options.frameworkPath, pathToSave);
-					if(this.$fs.exists(relativePathFromCwdToSource).wait()) {
+					if(this.$fs.exists(relativePathFromCwdToSource)) {
 						packageName = relativePathFromCwdToSource;
 					}
 				}

lib/node-package-manager.ts

@@ -63,13 +63,13 @@ export class NpmInstallationManager implements INpmInstallationManager {
 			let inspectorPath = path.join(projectDir, "node_modules", inspectorNpmPackageName);
 
 			// local installation takes precedence over cache
-			if(!this.inspectorAlreadyInstalled(inspectorPath).wait()) {
+			if(!this.inspectorAlreadyInstalled(inspectorPath)) {
 				let cachepath = this.$childProcess.exec("npm get cache").wait().trim();
 				let version = this.getLatestCompatibleVersion(inspectorNpmPackageName).wait();
 				let pathToPackageInCache = path.join(cachepath, inspectorNpmPackageName, version);
 				let pathToUnzippedInspector = path.join(pathToPackageInCache, "package");
 
-				if(!this.$fs.exists(pathToPackageInCache).wait()) {
+				if(!this.$fs.exists(pathToPackageInCache)) {
 					this.$childProcess.exec(`npm cache add ${inspectorNpmPackageName}@${version}`).wait();
 					let inspectorTgzPathInCache = path.join(pathToPackageInCache, "package.tgz");
 					this.$childProcess.exec(`tar -xf ${inspectorTgzPathInCache} -C ${pathToPackageInCache}`).wait();
@@ -82,26 +82,24 @@ export class NpmInstallationManager implements INpmInstallationManager {
 		}).future<string>()();
 	}
 
-	private inspectorAlreadyInstalled(pathToInspector: string): IFuture<Boolean> {
-		return (() => {
-			if(this.$fs.exists(pathToInspector).wait()) {
-				return true;
-			}
-			return false;
-		}).future<Boolean>()();
+	private inspectorAlreadyInstalled(pathToInspector: string): Boolean {
+		if(this.$fs.exists(pathToInspector)) {
+			return true;
+		}
+		return false;
 	}
 
 	private installCore(packageName: string, pathToSave: string, version: string, dependencyType: string): IFuture<string> {
 		return (() => {
 			const possiblePackageName= path.resolve(packageName);
-			if(this.$fs.exists(possiblePackageName).wait()) {
+			if(this.$fs.exists(possiblePackageName)) {
 				packageName = possiblePackageName;
 			}
 			if(packageName.indexOf(".tgz") >= 0) {
 				version = null;
 			}
 			// check if the packageName is url or local file and if it is, let npm install deal with the version
-			if(this.isURL(packageName) || this.$fs.exists(packageName).wait()) {
+			if(this.isURL(packageName) || this.$fs.exists(packageName)) {
 				version = null;
 			} else {
 				version = version || this.getLatestCompatibleVersion(packageName).wait();