Skip to content

Commit a6673eb

Browse files
committed
refactor: Make pluginsService.isNativeScriptPlugin to work with full path
1 parent 7485d03 commit a6673eb

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

lib/definitions/plugins.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ interface IPluginsService {
1515
validate(platformData: IPlatformData, projectData: IProjectData): Promise<void>;
1616
preparePluginNativeCode(pluginData: IPluginData, platform: string, projectData: IProjectData): Promise<void>;
1717
convertToPluginData(cacheData: any, projectDir: string): IPluginData;
18-
isNativeScriptPlugin(pluginName: string, projectData: IProjectData): boolean;
18+
isNativeScriptPlugin(pluginPackageJsonPath: string): boolean;
1919
}
2020

2121
interface IPackageJsonDepedenciesResult {

lib/services/plugins-service.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import * as path from "path";
22
import * as shelljs from "shelljs";
33
import * as semver from "semver";
44
import * as constants from "../constants";
5-
import { NODE_MODULES_DIR_NAME } from "../common/constants";
65

76
export class PluginsService implements IPluginsService {
87
private static INSTALL_COMMAND_NAME = "install";
@@ -208,8 +207,7 @@ export class PluginsService implements IPluginsService {
208207
};
209208
}
210209

211-
public isNativeScriptPlugin(pluginName: string, projectData: IProjectData): boolean {
212-
const pluginPackageJsonPath = path.join(projectData.projectDir, NODE_MODULES_DIR_NAME, pluginName, "package.json");
210+
public isNativeScriptPlugin(pluginPackageJsonPath: string): boolean {
213211
const pluginPackageJsonContent = this.$fs.readJson(pluginPackageJsonPath);
214212
return pluginPackageJsonContent && pluginPackageJsonContent.nativescript;
215213
}

0 commit comments

Comments
 (0)