Fix merging of CFBundleURLSchemes in debug builds (#2913)

In debug builds we add CFBundleURLSchemes that's required to restart the app on Windows.
However, in case the Info.plist of the application already has the same key, the module we are using is not merging the values correctly.
Fix this by manually merging the values.

Author: rosen-vladimirov

lib/common

@@ -743,40 +743,28 @@ We will now place an empty obsolete compatability white screen LauncScreen.xib f
 			makePatch(pluginInfoPlistPath);
 		}
 
-		makePatch(infoPlistPath);
+		if (!buildOptions.release && projectData.projectId) {
+			const modifiedPlistContent = this.updateCFBundleURLSchemes(infoPlistPath, projectData);
 
-		if (projectData.projectId) {
 			session.patch({
-				name: "CFBundleIdentifier from package.json nativescript.id",
-				read: () =>
-					`<?xml version="1.0" encoding="UTF-8"?>
-						<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
-						<plist version="1.0">
-						<dict>
-							<key>CFBundleIdentifier</key>
-							<string>${projectData.projectId}</string>
-						</dict>
-						</plist>`
+				name: "CFBundleURLTypes from Info.plist and required one for restarting application",
+				read: () => modifiedPlistContent
 			});
+
+		} else {
+			makePatch(infoPlistPath);
 		}
 
-		if (!buildOptions.release && projectData.projectId) {
+		if (projectData.projectId) {
 			session.patch({
-				name: "CFBundleURLTypes from package.json nativescript.id",
+				name: "CFBundleIdentifier from package.json nativescript.id",
 				read: () =>
 					`<?xml version="1.0" encoding="UTF-8"?>
 						<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 						<plist version="1.0">
 						<dict>
-							<key>CFBundleURLTypes</key>
-							<array>
-								<dict>
-									<key>CFBundleURLSchemes</key>
-									<array>
-										<string>${projectData.projectId.replace(/[^A-Za-z0-9]/g, "")}</string>
-									</array>
-								</dict>
-							</array>
+							<key>CFBundleIdentifier</key>
+							<string>${projectData.projectId}</string>
 						</dict>
 						</plist>`
 			});
@@ -788,6 +776,36 @@ We will now place an empty obsolete compatability white screen LauncScreen.xib f
 		this.$fs.writeFile(this.getPlatformData(projectData).configurationFilePath, plistContent);
 	}
 
+	private updateCFBundleURLSchemes(infoPlistPath: string, projectData: IProjectData): string {
+		// This code is required due to bug in session.patch logic which cannot merge values which are both arrays - it uses the second one directly.
+		// In our case we want to merge the values of CFBundleURLSchemes (which are arrays), which are in CFBundleURLTypes arrays.
+		let parsedPlist: any = plist.parse(this.$fs.readFile(infoPlistPath).toString());
+		parsedPlist.CFBundleURLTypes = parsedPlist.CFBundleURLTypes || [];
+
+		const appIdCfBundleUrlScheme = projectData.projectId.replace(/[^A-Za-z0-9]/g, "");
+
+		let hasAddedCFBundleURLSchemes = false;
+
+		_.each(parsedPlist.CFBundleURLTypes, type => {
+			if (type.CFBundleURLSchemes) {
+				hasAddedCFBundleURLSchemes = true;
+				type.CFBundleURLSchemes.push(appIdCfBundleUrlScheme);
+				return false;
+			}
+		});
+
+		if (!hasAddedCFBundleURLSchemes) {
+			parsedPlist.CFBundleURLTypes.push(
+				{
+					CFBundleURLSchemes: [appIdCfBundleUrlScheme]
+				}
+			);
+		}
+
+		const newPlistContent = plist.build(parsedPlist);
+		return newPlistContent;
+	}
+
 	private getAllInstalledPlugins(projectData: IProjectData): Promise<IPluginData[]> {
 		return (<IPluginsService>this.$injector.resolve("pluginsService")).getAllInstalledPlugins(projectData);
 	}