Skip to content

Commit ada7648

Browse files
Split Android debug bridge
The non-device Android debug bridge must be separated from the device-specific Android debug bridge. The non-device Android debug bridge can be injected through constructor and the device specific Android debug bridge can be resolved using the $injector. This way the device-specific Android debug bridge will be unique for each device.
1 parent 881f2af commit ada7648

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

lib/services/android-project-service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import Future = require("fibers/future");
66
import * as constants from "../constants";
77
import * as semver from "semver";
88
import * as projectServiceBaseLib from "./platform-project-service-base";
9-
import * as androidDebugBridgePath from "../common/mobile/android/android-debug-bridge";
9+
import {DeviceAndroidDebugBridge} from "../common/mobile/android/device-android-debug-bridge";
1010
import {AndroidDeviceHashService} from "../common/mobile/android/android-device-hash-service";
1111
import {EOL} from "os";
1212
import { createGUID } from "../common/helpers";
@@ -393,7 +393,7 @@ export class AndroidProjectService extends projectServiceBaseLib.PlatformProject
393393

394394
public deploy(deviceIdentifier: string): IFuture<void> {
395395
return (() => {
396-
let adb = this.$injector.resolve(androidDebugBridgePath.AndroidDebugBridge, { identifier: deviceIdentifier });
396+
let adb = this.$injector.resolve(DeviceAndroidDebugBridge, { identifier: deviceIdentifier });
397397
let deviceRootPath = `/data/local/tmp/${this.$projectData.projectId}`;
398398
adb.executeShellCommand(["rm", "-rf", this.$mobileHelper.buildDevicePath(deviceRootPath, "fullsync"),
399399
this.$mobileHelper.buildDevicePath(deviceRootPath, "sync"),

lib/services/livesync/android-livesync-service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
///<reference path="../../.d.ts"/>
22
"use strict";
33

4-
import {AndroidDebugBridge} from "../../common/mobile/android/android-debug-bridge";
4+
import {DeviceAndroidDebugBridge} from "../../common/mobile/android/device-android-debug-bridge";
55
import {AndroidDeviceHashService} from "../../common/mobile/android/android-device-hash-service";
66
import Future = require("fibers/future");
77
import * as helpers from "../../common/helpers";
@@ -102,7 +102,7 @@ class AndroidLiveSyncService extends liveSyncServiceBaseLib.LiveSyncServiceBase<
102102
private _deviceHashService: Mobile.IAndroidDeviceHashService;
103103
private get deviceHashService(): Mobile.IAndroidDeviceHashService {
104104
if (!this._deviceHashService) {
105-
let adb = this.$injector.resolve(AndroidDebugBridge, { identifier: this.device.deviceInfo.identifier });
105+
let adb = this.$injector.resolve(DeviceAndroidDebugBridge, { identifier: this.device.deviceInfo.identifier });
106106
this._deviceHashService = this.$injector.resolve(AndroidDeviceHashService, { adb: adb, appIdentifier: this.$projectData.projectId });
107107
}
108108

0 commit comments

Comments
 (0)