Merge pull request #4710 from NativeScript/fatme/hooks

fix: add preview-sync and watchPatterns hooks

Author: Fatme

lib/controllers/prepare-controller.ts

@@ -114,12 +114,8 @@ export class PrepareController extends EventEmitter {
 			return false;
 		}
 
-		const patterns = [
-			path.join(projectData.projectDir, PACKAGE_JSON_FILE_NAME),
-			path.join(projectData.getAppDirectoryPath(), PACKAGE_JSON_FILE_NAME),
-			path.join(projectData.getAppResourcesRelativeDirectoryPath(), platformData.normalizedPlatformName),
-			`node_modules/**/platforms/${platformData.platformNameLowerCase}/`
-		];
+		const patterns = await this.getWatcherPatterns(platformData, projectData);
+
 		const watcherOptions: choki.WatchOptions = {
 			ignoreInitial: true,
 			cwd: projectData.projectDir,
@@ -143,6 +139,18 @@ export class PrepareController extends EventEmitter {
 		return hasNativeChanges;
 	}
 
+	@hook('watchPatterns')
+	public async getWatcherPatterns(platformData: IPlatformData, projectData: IProjectData): Promise<string[]> {
+		const patterns = [
+			path.join(projectData.projectDir, PACKAGE_JSON_FILE_NAME),
+			path.join(projectData.getAppDirectoryPath(), PACKAGE_JSON_FILE_NAME),
+			path.join(projectData.getAppResourcesRelativeDirectoryPath(), platformData.normalizedPlatformName),
+			`node_modules/**/platforms/${platformData.platformNameLowerCase}/`
+		];
+
+		return patterns;
+	}
+
 	private emitPrepareEvent(filesChangeEventData: IFilesChangeEventData) {
 		if (this.isInitialPrepareReady) {
 			this.emit(PREPARE_READY_EVENT_NAME, filesChangeEventData);

lib/controllers/preview-app-controller.ts

@@ -2,7 +2,7 @@ import { Device, FilesPayload } from "nativescript-preview-sdk";
 import { TrackActionNames, PREPARE_READY_EVENT_NAME } from "../constants";
 import { PrepareController } from "./prepare-controller";
 import { performanceLog } from "../common/decorators";
-import { stringify } from "../common/helpers";
+import { stringify, hook } from "../common/helpers";
 import { HmrConstants } from "../common/constants";
 import { EventEmitter } from "events";
 import { PrepareDataService } from "../services/prepare-data-service";
@@ -17,6 +17,7 @@ export class PreviewAppController extends EventEmitter implements IPreviewAppCon
 		private $errors: IErrors,
 		private $hmrStatusService: IHmrStatusService,
 		private $logger: ILogger,
+		public $hooksService: IHooksService,
 		private $prepareController: PrepareController,
 		private $previewAppFilesService: IPreviewAppFilesService,
 		private $previewAppPluginsService: IPreviewAppPluginsService,
@@ -26,6 +27,7 @@ export class PreviewAppController extends EventEmitter implements IPreviewAppCon
 		private $prepareDataService: PrepareDataService
 	) { super(); }
 
+	@hook("preview-sync")
 	public async startPreview(data: IPreviewAppLiveSyncData): Promise<IQrCodeImageData> {
 		await this.previewCore(data);
 

test/services/playground/preview-app-livesync-service.ts

@@ -180,6 +180,10 @@ function createTestInjector(options?: {
 	injector.register("analyticsService", {
 		trackEventActionInGoogleAnalytics: () => ({})
 	});
+	injector.register("hooksService", {
+		executeBeforeHooks: () => ({}),
+		executeAfterHooks: () => ({})
+	});
 
 	return injector;
 }