chore: remove $timers

Remove previously introduced `$timers` - the idea was to use $timers as we wanted to kill remaining timers when SIGINT is sent to CLI.
As CLI no longer handles SIGINT signal, Node.js kills the timers on its own, so there's no need of additional timers implementation.

Author: rosen-vladimirov

lib/common/bootstrap.ts

@@ -6,7 +6,6 @@ $injector.require("errors", "./errors");
 $injector.requirePublic("fs", "./file-system");
 $injector.require("hostInfo", "./host-info");
 $injector.require("osInfo", "./os-info");
-$injector.require("timers", "./timers");
 
 $injector.require("dispatcher", "./dispatchers");
 $injector.require("commandDispatcher", "./dispatchers");

lib/common/definitions/timers.d.ts

@@ -42,8 +42,7 @@ export class DevicesService extends EventEmitter implements Mobile.IDevicesServi
 		private $androidEmulatorServices: Mobile.IEmulatorPlatformService,
 		private $androidEmulatorDiscovery: Mobile.IDeviceDiscovery,
 		private $emulatorHelper: Mobile.IEmulatorHelper,
-		private $prompter: IPrompter,
-		private $timers: ITimers) {
+		private $prompter: IPrompter) {
 		super();
 		this.attachToKnownDeviceDiscoveryEvents();
 		this.attachToKnownEmulatorDiscoveryEvents();
@@ -293,7 +292,7 @@ export class DevicesService extends EventEmitter implements Mobile.IDevicesServi
 		if (!this.deviceDetectionInterval) {
 			let isDeviceDetectionIntervalInProgress = false;
 
-			this.deviceDetectionInterval = this.$timers.setInterval(async () => {
+			this.deviceDetectionInterval = setInterval(async () => {
 				if (isDeviceDetectionIntervalInProgress) {
 					return;
 				}
@@ -320,7 +319,7 @@ export class DevicesService extends EventEmitter implements Mobile.IDevicesServi
 	@exported("devicesService")
 	public startEmulatorDetectionInterval(opts: Mobile.IHasDetectionInterval = {}): void {
 		let isEmulatorDetectionIntervalRunning = false;
-		this.emulatorDetectionInterval = this.$timers.setInterval(async () => {
+		this.emulatorDetectionInterval = setInterval(async () => {
 			if (isEmulatorDetectionIntervalRunning) {
 				return;
 			}
@@ -336,14 +335,14 @@ export class DevicesService extends EventEmitter implements Mobile.IDevicesServi
 	@exported("devicesService")
 	public stopDeviceDetectionInterval(): void {
 		if (this.deviceDetectionInterval) {
-			this.$timers.clearInterval(this.deviceDetectionInterval);
+			clearInterval(this.deviceDetectionInterval);
 		}
 	}
 
 	@exported("devicesService")
 	public stopEmulatorDetectionInterval(): void {
 		if (this.emulatorDetectionInterval) {
-			this.$timers.clearInterval(this.emulatorDetectionInterval);
+			clearInterval(this.emulatorDetectionInterval);
 		}
 	}
 

lib/common/mobile/mobile-core/devices-service.ts

@@ -14,7 +14,6 @@ import { CommonLoggerStub, ErrorsStub } from "../stubs";
 import { Messages } from "../../../messages/messages";
 import * as constants from "../../../constants";
 import { DevicePlatformsConstants } from "../../../mobile/device-platforms-constants";
-import { Timers } from "../../../timers";
 
 const helpers = require("../../../helpers");
 const originalIsInteractive = helpers.isInteractive;
@@ -183,7 +182,6 @@ function createTestInjector(): IInjector {
 	testInjector.register("androidProcessService", { /* no implementation required */ });
 	testInjector.register("androidEmulatorDiscovery", AndroidEmulatorDiscoveryStub);
 	testInjector.register("emulatorHelper", {});
-	testInjector.register("timers", Timers);
 
 	return testInjector;
 }

lib/common/test/unit-tests/mobile/devices-service.ts

@@ -159,7 +159,6 @@ function createTestInjector(projectPath: string, projectName: string, xCode?: IX
 		removeExtensions: () => { /* */ },
 		addExtensionsFromPath: () => Promise.resolve()
 	});
-	testInjector.register("timers", {});
 	return testInjector;
 }