chore: remove COMMAND_HELP_FILE_NAME from static-config

The COMMAND_HELP_FILE_NAME had been used in the past to show the name of the file where the help of all commands is located.
Since several years such file does not exist, so remove the variable and its usage in the code.

Author: rosen-vladimirov

lib/common/definitions/config.d.ts

@@ -21,7 +21,6 @@ declare module Config {
 		HTML_CLI_HELPERS_DIR: string;
 		pathToPackageJson: string;
 		APP_RESOURCES_DIR_NAME: string;
-		COMMAND_HELP_FILE_NAME: string;
 		RESOURCE_DIR_PATH: string;
 		PATH_TO_BOOTSTRAP: string;
 		QR_SIZE: number;

lib/common/services/commands-service.ts

@@ -22,12 +22,10 @@ export class CommandsService implements ICommandsService {
 	constructor(private $analyticsSettingsService: IAnalyticsSettingsService,
 		private $commandsServiceProvider: ICommandsServiceProvider,
 		private $errors: IErrors,
-		private $fs: IFileSystem,
 		private $hooksService: IHooksService,
 		private $injector: IInjector,
 		private $logger: ILogger,
 		private $options: IOptions,
-		private $resources: IResourceLoader,
 		private $staticConfig: Config.IStaticConfig,
 		private $helpService: IHelpService,
 		private $extensibilityService: IExtensibilityService,
@@ -88,12 +86,6 @@ export class CommandsService implements ICommandsService {
 				await this.$hooksService.executeAfterHooks(commandName);
 			}
 
-			const commandHelp = this.getCommandHelp();
-			if (!command.disableCommandHelpSuggestion && commandHelp && commandHelp[commandName]) {
-				const suggestionText: string = commandHelp[commandName];
-				this.$logger.printMarkdown(~suggestionText.indexOf('%s') ? require('util').format(suggestionText, commandArguments) : suggestionText);
-			}
-
 			this.commands.pop();
 			return true;
 		}
@@ -372,15 +364,6 @@ export class CommandsService implements ICommandsService {
 		return true;
 	}
 
-	private getCommandHelp(): any {
-		let commandHelp: any = null;
-		if (this.$fs.exists(this.$resources.resolvePath(this.$staticConfig.COMMAND_HELP_FILE_NAME))) {
-			commandHelp = this.$resources.readJson(this.$staticConfig.COMMAND_HELP_FILE_NAME);
-		}
-
-		return commandHelp;
-	}
-
 	private beautifyCommandName(commandName: string): string {
 		if (commandName.indexOf("*") > 0) {
 			return commandName.substr(0, commandName.indexOf("|"));

lib/common/static-config-base.ts

@@ -9,7 +9,6 @@ export abstract class StaticConfigBase implements Config.IStaticConfig {
 	public TRACK_FEATURE_USAGE_SETTING_NAME: string = null;
 	public ERROR_REPORT_SETTING_NAME: string = null;
 	public APP_RESOURCES_DIR_NAME = "App_Resources";
-	public COMMAND_HELP_FILE_NAME = 'command-help.json';
 	public QR_SIZE = 5;
 	public RESOURCE_DIR_PATH = __dirname;
 	public SYS_REQUIREMENTS_LINK: string;