Skip to content

Commit de90bde

Browse files
Include linting of unit tests
Allow linter for unit tests and fix all errors. Add public method in liveSyncService that should be used to delete files when LiveSync operation is in progress. This way, when user deletes file in Proton, the application will call `liveSyncService.deleteFiles` method for it and it will be removed from device.
1 parent 5f25370 commit de90bde

File tree

5 files changed

+8
-10
lines changed

5 files changed

+8
-10
lines changed

Gruntfile.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ module.exports = function(grunt) {
6161
tslint: {
6262
build: {
6363
files: {
64-
src: ["lib/**/*.ts", "test/**/*.ts", "!lib/common/node_modules/**/*.ts", "!lib/common/messages/**/*.ts", "lib/common/test/unit-tests/**/*.ts", "definitions/**/*.ts", "!lib/**/*.d.ts" , "!test/**/*.ts"]
64+
src: ["lib/**/*.ts", "test/**/*.ts", "!lib/common/node_modules/**/*.ts", "!lib/common/messages/**/*.ts", "lib/common/test/unit-tests/**/*.ts", "definitions/**/*.ts", "!lib/**/*.d.ts" , "!test/**/*.d.ts"]
6565
},
6666
options: {
6767
configuration: grunt.file.readJSON("./tslint.json")

test/npm-support.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,6 @@ describe("Npm support tests", () => {
259259

260260
it("Ensures that tns_modules absent when bundling", () => {
261261
let fs = testInjector.resolve("fs");
262-
let lockfile = testInjector.resolve("lockfile");
263262
let options = testInjector.resolve("options");
264263
let tnsModulesFolderPath = path.join(appDestinationFolderPath, "app", "tns_modules");
265264

test/platform-service.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -264,16 +264,16 @@ describe('Platform Service Tests', () => {
264264

265265
platformService = testInjector.resolve("platformService");
266266
let options : IOptions = testInjector.resolve("options");
267-
options.release = release;
267+
options.release = release;
268268
platformService.preparePlatform(platformToTest).wait();
269-
269+
270270
let test1FileName = platformToTest.toLowerCase() === "ios" ? "test1.js" : "test2.js";
271271
let test2FileName = platformToTest.toLowerCase() === "ios" ? "test2.js" : "test1.js";
272272

273273
// Asserts that the files in app folder are process as platform specific
274274
assert.isTrue(fs.exists(path.join(appDestFolderPath, "app", test1FileName)).wait());
275275
assert.isFalse(fs.exists(path.join(appDestFolderPath, "app", "test1-js")).wait());
276-
276+
277277
assert.isFalse(fs.exists(path.join(appDestFolderPath, "app", test2FileName)).wait());
278278
assert.isFalse(fs.exists(path.join(appDestFolderPath, "app", "test2-js")).wait());
279279

@@ -293,7 +293,7 @@ describe('Platform Service Tests', () => {
293293
it("should process only files in app folder when preparing for Android platform", () => {
294294
testPreparePlatform("Android");
295295
});
296-
296+
297297
it("should process only files in app folder when preparing for iOS platform", () => {
298298
testPreparePlatform("iOS", true);
299299
});
@@ -348,4 +348,4 @@ describe('Platform Service Tests', () => {
348348
assert.isFalse(warnings.indexOf("has errors") !== -1);
349349
});
350350
});
351-
});
351+
});

test/project-service.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -382,8 +382,7 @@ describe("Project Service Tests", () => {
382382
return (() => {
383383
if (incorrectInputsCount < incorrectInputsLimit) {
384384
incorrectInputsCount++;
385-
}
386-
else {
385+
} else {
387386
hasPromptedForString = true;
388387

389388
return validProjectName;

0 commit comments

Comments
 (0)