fix: fix native change during livesync on iOS device

We need to execute full sync after install on iOS device in order to create LiveSync folder on device.

Author: Fatme

lib/controllers/run-controller.ts

@@ -352,6 +352,7 @@ export class RunController extends EventEmitter implements IRunController {
 					}
 
 					await this.$deviceInstallAppService.installOnDevice(device, deviceDescriptor.buildData, this.rebuiltInformation[platformData.platformNameLowerCase].packageFilePath);
+					await platformLiveSyncService.syncAfterInstall(device, watchInfo);
 					await platformLiveSyncService.restartApplication(projectData, { deviceAppData, modifiedFilesData: [], isFullSync: false, useHotModuleReload: liveSyncInfo.useHotModuleReload });
 				} else {
 					const isInHMRMode = liveSyncInfo.useHotModuleReload && data.hmrData && data.hmrData.hash;

lib/definitions/livesync.d.ts

@@ -251,6 +251,7 @@ declare global {
 		shouldRestart(projectData: IProjectData, liveSyncInfo: ILiveSyncResultInfo): Promise<boolean>;
 		getDeviceLiveSyncService(device: Mobile.IDevice, projectData: IProjectData): INativeScriptDeviceLiveSyncService;
 		getAppData(syncInfo: IFullSyncInfo): Promise<Mobile.IDeviceAppData>;
+		syncAfterInstall(device: Mobile.IDevice, liveSyncInfo: ILiveSyncWatchInfo): Promise<void>;
 	}
 
 	interface IRestartApplicationInfo {

lib/services/livesync/ios-livesync-service.ts

@@ -55,19 +55,16 @@ export class IOSLiveSyncService extends PlatformLiveSyncServiceBase implements I
 		};
 	}
 
-	@performanceLog()
-	public liveSyncWatchAction(device: Mobile.IDevice, liveSyncInfo: ILiveSyncWatchInfo): Promise<ILiveSyncResultInfo> {
-		if (liveSyncInfo.isReinstalled) {
+	public async syncAfterInstall(device: Mobile.IDevice, liveSyncInfo: ILiveSyncWatchInfo): Promise<void> {
+		if (!device.isEmulator) {
 			// In this case we should execute fullsync because iOS Runtime requires the full content of app dir to be extracted in the root of sync dir.
-			return this.fullSync({
+			await this.fullSync({
 				projectData: liveSyncInfo.projectData,
 				device,
 				liveSyncDeviceData: liveSyncInfo.liveSyncDeviceData,
 				watch: true,
 				useHotModuleReload: liveSyncInfo.useHotModuleReload
 			});
-		} else {
-			return super.liveSyncWatchAction(device, liveSyncInfo);
 		}
 	}
 

lib/services/livesync/platform-livesync-service-base.ts

@@ -2,6 +2,7 @@ import * as path from "path";
 import * as util from "util";
 import { APP_FOLDER_NAME } from "../../constants";
 import { getHash } from "../../common/helpers";
+import { performanceLog } from "../../common/decorators";
 
 export abstract class PlatformLiveSyncServiceBase {
 	private _deviceLiveSyncServicesCache: IDictionary<INativeScriptDeviceLiveSyncService> = {};
@@ -32,6 +33,8 @@ export abstract class PlatformLiveSyncServiceBase {
 		return shouldRestart;
 	}
 
+	public async syncAfterInstall(device: Mobile.IDevice, liveSyncInfo: ILiveSyncWatchInfo): Promise<void> { /* intentionally left blank */ }
+
 	public async restartApplication(projectData: IProjectData, liveSyncInfo: ILiveSyncResultInfo): Promise<void> {
 		const deviceLiveSyncService = this.getDeviceLiveSyncService(liveSyncInfo.deviceAppData.device, projectData);
 		this.$logger.info(`Restarting application on device ${liveSyncInfo.deviceAppData.device.deviceInfo.identifier}...`);
@@ -72,6 +75,7 @@ export abstract class PlatformLiveSyncServiceBase {
 		};
 	}
 
+	@performanceLog()
 	public async liveSyncWatchAction(device: Mobile.IDevice, liveSyncInfo: ILiveSyncWatchInfo): Promise<ILiveSyncResultInfo> {
 		const projectData = liveSyncInfo.projectData;
 		const deviceLiveSyncService = this.getDeviceLiveSyncService(device, projectData);