Skip to content

Commit e7a609e

Browse files
committed
removed obsolete logic from ios-project-service
there was code that used sed to replace __CFBUNDLEIDENTIFIER__ into the info.plist, but there's new logic that does the same thing
1 parent 5e08d6d commit e7a609e

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

lib/services/ios-project-service.ts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -119,12 +119,9 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
119119
}
120120
}).future<void>()();
121121
}
122-
122+
//TODO: plamen5kov: revisit this method, might have unnecessary/obsolete logic
123123
public interpolateData(): IFuture<void> {
124124
return (() => {
125-
let infoPlistFilePath = path.join(this.platformData.projectRoot, IOSProjectService.IOS_PROJECT_NAME_PLACEHOLDER, `${IOSProjectService.IOS_PROJECT_NAME_PLACEHOLDER}-Info.plist`);
126-
this.interpolateConfigurationFile(infoPlistFilePath).wait();
127-
128125
let projectRootFilePath = path.join(this.platformData.projectRoot, IOSProjectService.IOS_PROJECT_NAME_PLACEHOLDER);
129126
// Starting with NativeScript for iOS 1.6.0, the project Info.plist file resides not in the platform project,
130127
// but in the hello-world app template as a platform specific resource.
@@ -156,9 +153,7 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ
156153
}
157154

158155
public interpolateConfigurationFile(configurationFilePath?: string): IFuture<void> {
159-
return (() => {
160-
shell.sed('-i', "__CFBUNDLEIDENTIFIER__", this.$projectData.projectId, configurationFilePath || this.platformData.configurationFilePath);
161-
}).future<void>()();
156+
return Future.fromResult();
162157
}
163158

164159
public afterCreateProject(projectRoot: string): void {

0 commit comments

Comments
 (0)