Addressing linter issues and comments.

Author: Deyan Ginev

lib/services/ios-log-filter.ts

@@ -11,18 +11,16 @@ export class IOSLogFilter implements Mobile.IPlatformLogFilter {
 	// Example:
 	// This: "May 24 15:54:52 Dragons-iPhone NativeScript250(NativeScript)[356] <Notice>: CONSOLE ERROR file:///app/tns_modules/@angular/core/bundles/core.umd.js:3477:36: ORIGINAL STACKTRACE:"
 	// Becomes: CONSOLE ERROR file:///app/tns_modules/@angular/core/bundles/core.umd.js:3477:36: ORIGINAL STACKTRACE:
-	protected infoFilterRegex =  new RegExp(`^.*(?:<Notice>:|<Error>:|<Warning>:|\\(NativeScript\\)|${this.appOutputRegex.source}:){1}`);
+	protected infoFilterRegex = new RegExp(`^.*(?:<Notice>:|<Error>:|<Warning>:|\\(NativeScript\\)|${this.appOutputRegex.source}:){1}`);
 
 	private filterActive: boolean = true;
-	private projectName: string;
 
 	private partialLine: string = null;
 
 	constructor(
 		private $loggingLevels: Mobile.ILoggingLevels,
 		private $fs: IFileSystem,
 		private $projectData: IProjectData) {
-		this.projectName = this.$projectData.projectName;
 	}
 
 	public filterData(data: string, logLevel: string, pid?: string): string {
@@ -57,7 +55,10 @@ export class IOSLogFilter implements Mobile.IPlatformLogFilter {
 
 			if (matchResult && matchResult.length > 1) {
 				// Check if the name of the app equals the name of the CLI project and turn on the filter if not.
-				this.filterActive = matchResult[1] !== this.projectName;
+				// We call initializeProjectData in order to obtain the current project name as the instance
+				// of this filter may be used accross multiple projects.
+				this.$projectData.initializeProjectData();
+				this.filterActive = matchResult[1] !== this.$projectData.projectName;
 			}
 
 			if (this.filterActive) {
@@ -76,11 +77,11 @@ export class IOSLogFilter implements Mobile.IPlatformLogFilter {
 		return output.length === 0 ? null : output;
 	}
 
-	private preFilter(data:string, currentLine: string): boolean {
+	private preFilter(data: string, currentLine: string): boolean {
 		return currentLine.length < 1 ||
-				currentLine.indexOf("SecTaskCopyDebugDescription") !== -1 ||
-				currentLine.indexOf("NativeScript loaded bundle") !== -1 ||
-				(currentLine.indexOf("assertion failed:") !== -1 && data.indexOf("libxpc.dylib") !== -1);
+			currentLine.indexOf("SecTaskCopyDebugDescription") !== -1 ||
+			currentLine.indexOf("NativeScript loaded bundle") !== -1 ||
+			(currentLine.indexOf("assertion failed:") !== -1 && data.indexOf("libxpc.dylib") !== -1);
 	}
 
 	private getOriginalFileLocation(data: string): string {

test/services/ios-log-filter.ts

@@ -181,20 +181,20 @@ describe("iOSLogFilter", () => {
 			it(`returns correct data on iOS ${data.version} when data comes in chunks`, () => {
 				testInjector = createTestInjector(data.projectName);
 				logFilter = testInjector.resolve(IOSLogFilter);
-				
+
 				let currentStart = 0;
-				let maxRange = 50;
-				let output = ""
-				let input = data.originalDataArr.join("\n");
+				const maxRange = 50;
+				let output = "";
+				const input = data.originalDataArr.join("\n");
 				while (true) {
-					let currentRange = Math.floor(Math.random() * maxRange);
-					let currentFilterInput = input.substr(currentStart, currentRange);
-					let tempOutput = logFilter.filterData(currentFilterInput, infoLogLevel, null);
+					const currentRange = Math.floor(Math.random() * maxRange);
+					const currentFilterInput = input.substr(currentStart, currentRange);
+					const tempOutput = logFilter.filterData(currentFilterInput, infoLogLevel, null);
 					if (tempOutput !== null) {
 						output += tempOutput;
 					}
 					currentStart += currentRange;
-					if (currentStart == input.length) {
+					if (currentStart === input.length) {
 						break;
 					}
 					currentStart = Math.min(currentStart, input.length);
@@ -243,7 +243,7 @@ describe("iOSLogFilter", () => {
 				logFilter = testInjector.resolve(IOSLogFilter);
 				data.originalDataArr.forEach((line, index) => {
 					if (line.length > 0) {
-						line += "\n"
+						line += "\n";
 					}
 					const actualData = logFilter.filterData(line, infoLogLevel, null);
 					const expectedData = data.infoExpectedArr[index];