fix: fix "Could not open file Library/Application Support/LiveSync/app/tns_modules/tns-core-modules/inspector_modules.js for writing" error on iOS device when hmr fails

NativeScript CLI zips all files from application except the files from tns-modules. When the runtime unzip the uploaded archive on device, it symlinks the tns_modules folder. When hmr fails, CLI transfers fallback files on device in order to apply the change. The `inspector_modules.js` file is part of these fallback files which is located in `tns_modules` folder. In this situation CLI tries to write the file inside /Library/Application Support/LiveSync/app/tns_modules which is symlinked to app's bundle folder. As CLI is not able to write directly to app's bundle folder, the above error is thrown.

Author: Fatme

lib/services/livesync/ios-livesync-service.ts

@@ -3,7 +3,7 @@ import * as temp from "temp";
 
 import { IOSDeviceLiveSyncService } from "./ios-device-livesync-service";
 import { PlatformLiveSyncServiceBase } from "./platform-livesync-service-base";
-import { APP_FOLDER_NAME, TNS_MODULES_FOLDER_NAME } from "../../constants";
+import { APP_FOLDER_NAME } from "../../constants";
 import { performanceLog } from "../../common/decorators";
 
 export class IOSLiveSyncService extends PlatformLiveSyncServiceBase implements IPlatformLiveSyncService {
@@ -34,8 +34,6 @@ export class IOSLiveSyncService extends PlatformLiveSyncServiceBase implements I
 		this.$logger.trace("Creating zip file: " + tempZip);
 		this.$fs.copyFile(path.join(path.dirname(projectFilesPath), `${APP_FOLDER_NAME}/*`), tempApp);
 
-		this.$fs.deleteDirectory(path.join(tempApp, TNS_MODULES_FOLDER_NAME));
-
 		await this.$fs.zipFiles(tempZip, this.$fs.enumerateFilesInDirectorySync(tempApp), (res) => {
 			return path.join(APP_FOLDER_NAME, path.relative(tempApp, res));
 		});