Skip to content

Commit f9065d7

Browse files
chore: remove Project.I interfaces and implementations
Remove all `Project.` interfaces and their implementations as they were used in a product that is no longer supported - Proton.
1 parent 598ee22 commit f9065d7

File tree

4 files changed

+4
-228
lines changed

4 files changed

+4
-228
lines changed

lib/common/appbuilder/declarations.d.ts

Lines changed: 0 additions & 83 deletions
Original file line numberDiff line numberDiff line change
@@ -2,89 +2,6 @@ interface IDeployHelper {
22
deploy(platform?: string): Promise<void>;
33
}
44

5-
declare module Project {
6-
interface IData extends IDictionary<any> {
7-
ProjectName: string;
8-
ProjectGuid: string;
9-
projectVersion: number;
10-
AppIdentifier: string;
11-
DisplayName: string;
12-
Author: string;
13-
Description: string;
14-
BundleVersion: string;
15-
Framework: string;
16-
FrameworkVersion: string;
17-
CorePlugins: string[];
18-
AndroidPermissions: string[];
19-
DeviceOrientations: string[];
20-
AndroidHardwareAcceleration: string;
21-
AndroidVersionCode: string;
22-
iOSStatusBarStyle: string;
23-
iOSDeviceFamily: string[];
24-
iOSBackgroundMode: string[];
25-
iOSDeploymentTarget: string;
26-
WP8ProductID: string;
27-
WP8PublisherID: string;
28-
WP8Publisher: string;
29-
WP8TileTitle: string;
30-
WP8Capabilities: string[];
31-
WP8Requirements: string[];
32-
WP8SupportedResolutions: string[];
33-
WPSdk?: string;
34-
WP8PackageIdentityName?: string;
35-
WP8WindowsPublisherName?: string;
36-
CordovaPluginVariables?: any;
37-
}
38-
39-
interface IProjectBase {
40-
projectDir: string;
41-
42-
/**
43-
* Determines path to project dir.
44-
* @returns {string} Path to project directory.
45-
*/
46-
getProjectDir(): string;
47-
48-
projectData: IData;
49-
/**
50-
* Describes whether the project has separate debug/release build configurations.
51-
* @type {boolean}
52-
*/
53-
hasBuildConfigurations: boolean;
54-
capabilities: any;
55-
/**
56-
* Information about the current project.
57-
* @type {Project.IProjectInformation}
58-
*/
59-
projectInformation: Project.IProjectInformation;
60-
}
61-
62-
/**
63-
* Describes information gathered about the current project.
64-
*/
65-
interface IProjectInformation {
66-
/**
67-
* The data parsed from the project's configuration file
68-
* @type {Project.IData}
69-
*/
70-
projectData: Project.IData;
71-
/**
72-
* Data parsed from the project's configuration specific configuration files(e.g. .debug.abproject, .test.abproject, etc.).
73-
* @type {IDictionary<Project.IData>}
74-
*/
75-
configurationSpecificData: IDictionary<Project.IData>;
76-
/**
77-
* Whether or not the project has separate debug/release build configurations.
78-
* @type {boolean}
79-
*/
80-
hasBuildConfigurations: boolean;
81-
/**
82-
* The project's configurations - usually only debug and release, but the user may specify more by creating multiple custom configuration files.
83-
* @type {string[]}
84-
*/
85-
configurations: string[];
86-
}
87-
}
885
/**
896
* Describes available methods for LiveSync operation from Proton.
907
*/

lib/common/appbuilder/project/project-base.ts

Lines changed: 0 additions & 120 deletions
This file was deleted.

lib/common/appbuilder/project/project.ts

Lines changed: 0 additions & 18 deletions
This file was deleted.

lib/common/appbuilder/services/livesync/livesync-service.ts

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,16 @@ export class ProtonLiveSyncService implements IProtonLiveSyncService {
1010
constructor(private $devicesService: Mobile.IDevicesService,
1111
private $fs: IFileSystem,
1212
private $injector: IInjector,
13-
private $project: Project.IProjectBase,
1413
private $logger: ILogger) { }
1514

1615
@exported("liveSyncService")
1716
public livesync(deviceDescriptors: IDeviceLiveSyncInfo[], projectDir: string, filePaths?: string[]): Promise<IDeviceLiveSyncResult>[] {
18-
this.$project.projectDir = projectDir;
1917
this.$logger.trace(`Called livesync for identifiers ${_.map(deviceDescriptors, d => d.deviceIdentifier)}. Project dir is ${projectDir}. Files are: ${filePaths}`);
2018
return _.map(deviceDescriptors, deviceDescriptor => this.liveSyncOnDevice(deviceDescriptor, filePaths));
2119
}
2220

2321
@exported("liveSyncService")
2422
public deleteFiles(deviceDescriptors: IDeviceLiveSyncInfo[], projectDir: string, filePaths: string[]): Promise<IDeviceLiveSyncResult>[] {
25-
this.$project.projectDir = projectDir;
2623
this.$logger.trace(`Called deleteFiles for identifiers ${_.map(deviceDescriptors, d => d.deviceIdentifier)}. Project dir is ${projectDir}. Files are: ${filePaths}`);
2724
return _.map(deviceDescriptors, deviceDescriptor => this.liveSyncOnDevice(deviceDescriptor, filePaths, { isForDeletedFiles: true }));
2825
}
@@ -44,10 +41,10 @@ export class ProtonLiveSyncService implements IProtonLiveSyncService {
4441
return result;
4542
}
4643

47-
if (!this.$fs.exists(this.$project.projectDir)) {
44+
if (!this.$fs.exists("")) {
4845
result.liveSyncToApp = result.liveSyncToCompanion = {
4946
isResolved: false,
50-
error: new Error(`Cannot execute LiveSync operation as the project dir ${this.$project.projectDir} does not exist on the file system.`)
47+
error: new Error(`Cannot execute LiveSync operation as the project dir does not exist on the file system.`)
5148
};
5249

5350
return result;
@@ -70,8 +67,8 @@ export class ProtonLiveSyncService implements IProtonLiveSyncService {
7067
livesyncData: ILiveSyncData = {
7168
platform: device.deviceInfo.platform,
7269
appIdentifier: appIdentifier,
73-
projectFilesPath: this.$project.projectDir,
74-
syncWorkingDirectory: this.$project.projectDir,
70+
projectFilesPath: "",
71+
syncWorkingDirectory: "",
7572
excludedProjectDirsAndFiles: this.excludedProjectDirsAndFiles,
7673
};
7774

0 commit comments

Comments
 (0)