refactor: update webpack plugins to new plugin system (#523)

Author: sis0k0

nativescript-target/index.js

@@ -9,10 +9,8 @@ module.exports = function nativescriptTarget(compiler) {
     const NodeSourcePlugin = require(webpackLib + "/node/NodeSourcePlugin");
     const LoaderTargetPlugin = require(webpackLib + "/LoaderTargetPlugin");
 
-    compiler.apply(
-        new NsJsonpTemplatePlugin(options.output),
-        new FunctionModulePlugin(options.output),
-        new NodeSourcePlugin(options.node),
-        new LoaderTargetPlugin("web")
-    );
+    new NsJsonpTemplatePlugin(options.output).apply(compiler);
+    new FunctionModulePlugin(options.output).apply(compiler);
+    new NodeSourcePlugin(options.node).apply(compiler);
+    new LoaderTargetPlugin("web").apply(compiler);
 }

plugins/GenerateBundleStarterPlugin.js

@@ -10,7 +10,7 @@ exports.GenerateBundleStarterPlugin = (function() {
     GenerateBundleStarterPlugin.prototype.apply = function(compiler) {
         this.webpackContext = compiler.options.context;
 
-        compiler.plugin("emit", (compilation, cb) => {
+        compiler.hooks.emit.tapAsync("GenerateBundleStarterPlugin", (compilation, cb) => {
             this.addAsset(compilation, "package.json", this.generatePackageJson());
             this.addAsset(compilation, "starter.js", this.generateStarterModule());
             this.generateTnsJavaClasses(compilation);

plugins/NativeScriptAngularCompilerPlugin.ts

@@ -66,7 +66,7 @@ module.exports = (projectDir) => {
         apply(compiler) {
             super.apply(compiler);
             if (this.options.platformOptions && this.options.platformOptions.platform && this.options.platformOptions.platforms) {
-                compiler.plugin('environment', () => {
+                compiler.hooks.environment.tap("NativeScriptAngularCompilerPlugin", () => {
                     compiler.inputFileSystem = mapFileSystem({
                         fs: compiler.inputFileSystem,
                         context: compiler.context,

plugins/NativeScriptSnapshotPlugin/index.js

@@ -104,7 +104,7 @@ exports.NativeScriptSnapshotPlugin = (function() {
     NativeScriptSnapshotPlugin.prototype.apply = function (compiler) {
         const options = this.options;
 
-        compiler.plugin("after-emit", function (compilation, callback) {
+        compiler.hooks.afterEmit.tapAsync("NativeScriptSnapshotPlugin", function (compilation, callback) {
             const chunksToSnapshot = options.chunks
                 .map(name => ({ name, chunk: compilation.chunks.find(chunk => chunk.name === name) }));
             const unexistingChunks = chunksToSnapshot.filter(pair => !pair.chunk);

plugins/WatchStateLoggerPlugin.ts

@@ -13,15 +13,15 @@ export class WatchStateLoggerPlugin {
     isRunningWatching: boolean;
     apply(compiler) {
         const plugin = this;
-        compiler.plugin("watch-run", function (compiler, callback) {
+        compiler.hooks.watchRun.tapAsync("WatchStateLoggerPlugin", function (compiler, callback) {
             plugin.isRunningWatching = true;
             if (plugin.isRunningWatching) {
                 console.log(messages.changeDetected);
             }
             process.send && process.send(messages.changeDetected, error => null);
             callback();
         });
-        compiler.plugin("after-emit", function (compilation, callback) {
+        compiler.hooks.afterEmit.tapAsync("WatchStateLoggerPlugin", function (compilation, callback) {
             callback();
             if (plugin.isRunningWatching) {
                 console.log(messages.startWatching);