Add support for AsValueEnumerable() for implementations of IEnumerable<> with value type or reference type enumerators

Author: aalmada

NetFabric.Hyperlinq.SourceGenerator.UnitTests/GenerateSourceTests.cs

@@ -32,7 +32,11 @@ public static TheoryData<string[], string> GeneratorSources
                     new[] { "TestData/Source/AsValueEnumerable.TestEnumerableWithValueTypeEnumerator.cs" }, 
                     "TestData/Results/AsValueEnumerable.TestEnumerableWithValueTypeEnumerator.cs" 
                 },
-                { 
+                {
+                    new[] { "TestData/Source/AsValueEnumerable.TestEnumerableWithReferenceTypeEnumerator.cs" },
+                    "TestData/Results/AsValueEnumerable.TestEnumerableWithReferenceTypeEnumerator.cs"
+                },
+                {
                     new[] { "TestData/Source/AsValueEnumerable.TestValueEnumerable.cs" }, 
                     "TestData/Results/AsValueEnumerable.TestValueEnumerable.cs" 
                 },

NetFabric.Hyperlinq.SourceGenerator.UnitTests/TestData/Results/AsValueEnumerable.TestEnumerableWithReferenceTypeEnumerator.cs

@@ -0,0 +1,30 @@
+#nullable enable
+
+using System;
+using System.Collections;
+using System.Collections.Generic;
+using System.Runtime.CompilerServices;
+
+namespace NetFabric.Hyperlinq
+{
+    static partial class GeneratedExtensionMethods
+    {
+
+        [MethodImpl(MethodImplOptions.AggressiveInlining)]
+        public static TestEnumerableWithReferenceTypeEnumeratorAsValueEnumerable AsValueEnumerable(this TestEnumerableWithReferenceTypeEnumerator source) => new(source);
+
+        public readonly struct TestEnumerableWithReferenceTypeEnumeratorAsValueEnumerable: IValueEnumerable<int, ValueEnumerator<int>>
+        {
+            readonly TestEnumerableWithReferenceTypeEnumerator source;
+
+            public TestEnumerableWithReferenceTypeEnumeratorAsValueEnumerable(TestEnumerableWithReferenceTypeEnumerator source) => this.source = source;
+
+            [MethodImpl(MethodImplOptions.AggressiveInlining)]
+            public ValueEnumerator<int> GetEnumerator() => new(source.GetEnumerator());
+
+            IEnumerator<int> IEnumerable<int>.GetEnumerator() => source.GetEnumerator();
+
+            IEnumerator IEnumerable.GetEnumerator() => source.GetEnumerator();
+        }
+    }
+}

NetFabric.Hyperlinq.SourceGenerator.UnitTests/TestData/Results/AsValueEnumerable.TestEnumerableWithValueTypeEnumerator.cs

@@ -11,18 +11,20 @@ static partial class GeneratedExtensionMethods
     {
 
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public static EnumerableWithValueTypeEnumerator__ValueEnumerable AsValueEnumerable(this TestEnumerableWithValueTypeEnumerator source) => new(source);
+        public static TestEnumerableWithValueTypeEnumeratorAsValueEnumerable AsValueEnumerable(this TestEnumerableWithValueTypeEnumerator source) => new(source);
 
-        public readonly struct EnumerableWithValueTypeEnumerator__ValueEnumerable : IValueEnumerable<int, TestEnumerableWithValueTypeEnumerator.Enumerator>
+        public readonly struct TestEnumerableWithValueTypeEnumeratorAsValueEnumerable: IValueEnumerable<int, TestEnumerableWithValueTypeEnumerator.Enumerator>
         {
             readonly TestEnumerableWithValueTypeEnumerator source;
 
-            public EnumerableWithValueTypeEnumerator__ValueEnumerable(TestEnumerableWithValueTypeEnumerator source) => this.source = source;
+            public TestEnumerableWithValueTypeEnumeratorAsValueEnumerable(TestEnumerableWithValueTypeEnumerator source) => this.source = source;
 
+            [MethodImpl(MethodImplOptions.AggressiveInlining)]
             public TestEnumerableWithValueTypeEnumerator.Enumerator GetEnumerator() => source.GetEnumerator();
+
             IEnumerator<int> IEnumerable<int>.GetEnumerator() => source.GetEnumerator();
+
             IEnumerator IEnumerable.GetEnumerator() => source.GetEnumerator();
         }
-
     }
 }

NetFabric.Hyperlinq.SourceGenerator.UnitTests/TestData/Source/AsValueEnumerable.TestEnumerableWithReferenceTypeEnumerator.cs

@@ -0,0 +1,19 @@
+using System;
+using System.Collections;
+using System.Collections.Generic;
+using NetFabric.Hyperlinq;
+
+partial class TestsSource
+{
+    static void AsValueEnumerable_TestEnumerableWithReferenceTypeEnumerator()
+    {
+        // test calling AsValueEnumerable() for types that implement IEnumerable<> and the enumerator is not a value type
+
+        _ = new TestEnumerableWithReferenceTypeEnumerator().AsValueEnumerable();
+    }
+}
+
+
+
+
+

NetFabric.Hyperlinq.SourceGenerator.UnitTests/TestData/Source/AsValueEnumerable.TestEnumerableWithValueTypeEnumerator.cs

@@ -7,7 +7,7 @@ partial class TestsSource
 {
     static void AsValueEnumerable_EnumerableWithValueTypeEnumerator()
     {
-        // test calling AsValueEnumerable() for types that implement IEnumerable<>
+        // test calling AsValueEnumerable() for types that implement IEnumerable<> and the enumerator is a value type
 
         _ = new TestEnumerableWithValueTypeEnumerator().AsValueEnumerable();
     }

NetFabric.Hyperlinq.SourceGenerator/Generator.AsValueEnumerable.cs

@@ -48,7 +48,7 @@ static bool HandleAsValueEnumerable(Compilation compilation, TypeSymbolCache typ
 
             if (receiverTypeSymbol.IsEnumerable(compilation, out var enumerableSymbols))
             {
-                var enumerableTypeString = $"{receiverTypeString}__ValueEnumerable";
+                var enumerableTypeString = $"{receiverTypeString}AsValueEnumerable";
                 var enumeratorTypeString = "Enumerator";
                 var itemType = enumerableSymbols.EnumeratorSymbols.Current.Type;
                 var itemTypeString = itemType.ToDisplayString();
@@ -77,7 +77,7 @@ static bool HandleAsValueEnumerable(Compilation compilation, TypeSymbolCache typ
                     .AppendLine($"public static {enumerableTypeString} AsValueEnumerable(this {receiverTypeString} source) => new(source);")
                     .AppendLine();
 
-                using (builder.AppendBlock($"public readonly struct {enumerableTypeString} : IValueEnumerable<{itemType.ToDisplayString()}, {enumeratorTypeString}>"))
+                using (builder.AppendBlock($"public readonly struct {enumerableTypeString}: IValueEnumerable<{itemType.ToDisplayString()}, {enumeratorTypeString}>"))
                 {
                     _ = builder
                         .AppendLine($"readonly {receiverTypeString} source;") // source field