Make ArrayPoolExtensions public (#384)

aalmada · web-flow · commit 40a2e763effd · 2021-09-23T23:14:16.000+01:00
diff --git a/NetFabric.Hyperlinq/Conversion/AsValueEnumerable/AsValueEnumerable.ArraySegment.cs b/NetFabric.Hyperlinq/Conversion/AsValueEnumerable/AsValueEnumerable.ArraySegment.cs
@@ -131,7 +131,14 @@ readonly object? IEnumerator.Current
 
                 [MethodImpl(MethodImplOptions.AggressiveInlining)]
                 public bool MoveNext()
-                    => ++index < source.Count;
+                {
+                    if (index < source.Count)
+                    {
+                        index++;
+                        return index < source.Count;
+                    }
+                    return false;
+                }
 
                 [MethodImpl(MethodImplOptions.AggressiveInlining)]
                 [ExcludeFromCodeCoverage]
diff --git a/NetFabric.Hyperlinq/Filtering/Where/Where/Where.ArraySegment.cs b/NetFabric.Hyperlinq/Filtering/Where/Where/Where.ArraySegment.cs
@@ -78,10 +78,14 @@ readonly object? IEnumerator.Current
                 [MethodImpl(MethodImplOptions.AggressiveInlining)]
                 public bool MoveNext()
                 {
+                    var index = this.index;
                     while (++index <= end)
                     {
                         if (predicate.Invoke(source![index]))
+                        {
+                            this.index = index;
                             return true;
+                        }
                     }
                     return false;
                 }
diff --git a/NetFabric.Hyperlinq/Filtering/Where/Where/Where.ReadOnlyMemory.cs b/NetFabric.Hyperlinq/Filtering/Where/Where/Where.ReadOnlyMemory.cs
@@ -77,11 +77,15 @@ readonly object? IEnumerator.Current
                 public bool MoveNext()
                 {
                     var span = source.Span;
+                    var index = this.index;
                     while (++index < span.Length)
                     {
                         var item = span[index];
                         if (predicate.Invoke(item))
+                        {
+                            this.index = index;
                             return true;
+                        }
                     }
                     return false;
                 }
diff --git a/NetFabric.Hyperlinq/Filtering/Where/WhereAt/WhereAt.ArraySegment.cs b/NetFabric.Hyperlinq/Filtering/Where/WhereAt/WhereAt.ArraySegment.cs
@@ -84,10 +84,14 @@ readonly object? IEnumerator.Current
                 [MethodImpl(MethodImplOptions.AggressiveInlining)]
                 public bool MoveNext()
                 {
+                    var index = this.index;
                     while (++index <= end)
                     {
                         if (predicate.Invoke(source![index + offset], index))
+                        {
+                            this.index = index;
                             return true;
+                        }
                     }
                     return false;
                 }
diff --git a/NetFabric.Hyperlinq/Filtering/WhereSelect/WhereSelect/WhereSelect.ArraySegment.cs b/NetFabric.Hyperlinq/Filtering/WhereSelect/WhereSelect/WhereSelect.ArraySegment.cs
@@ -82,10 +82,14 @@ readonly object? IEnumerator.Current
                 [MethodImpl(MethodImplOptions.AggressiveInlining)]
                 public bool MoveNext()
                 {
+                    var index = this.index;
                     while (++index <= end)
                     {
                         if (predicate.Invoke(source![index]))
+                        {
+                            this.index = index;
                             return true;
+                        }
                     }
                     return false;
                 }
diff --git a/NetFabric.Hyperlinq/Lease.cs b/NetFabric.Hyperlinq/Lease.cs
@@ -28,7 +28,7 @@ public sealed class Lease<T>
         T[]? rented;
         int length;
         
-        public Lease(ArrayPool<T> pool, int length, bool clearOnDispose = false)
+        internal Lease(ArrayPool<T> pool, int length, bool clearOnDispose)
         {
             Debug.Assert(length >= 0);
 
@@ -37,7 +37,7 @@ public Lease(ArrayPool<T> pool, int length, bool clearOnDispose = false)
             this.clearOnDispose = clearOnDispose;
             rented = length is 0
                 ? Array.Empty<T>()
-                : this.pool.Rent(length);
+                : pool.Rent(length);
         }
 
         /// <summary>
@@ -163,7 +163,12 @@ public readonly T Current
 
             [MethodImpl(MethodImplOptions.AggressiveInlining)]
             public bool MoveNext()
-                => ++index < length;
+            {
+                if (index >= length) 
+                    return false;
+                index++;
+                return index < length;
+            }
         }
 
         public struct DisposableEnumerator
@@ -192,7 +197,12 @@ readonly object? IEnumerator.Current
             
             [MethodImpl(MethodImplOptions.AggressiveInlining)]
             public bool MoveNext()
-                => ++index < length;        
+            {
+                if (index >= length) 
+                    return false;
+                index++;
+                return index < length;
+            }
 
             public void Reset() 
                 => index = -1;
diff --git a/NetFabric.Hyperlinq/NetFabric.Hyperlinq.csproj b/NetFabric.Hyperlinq/NetFabric.Hyperlinq.csproj
@@ -5,7 +5,7 @@
     <PackageId>NetFabric.Hyperlinq</PackageId>
     <Title>NetFabric.Hyperlinq</Title>
     <Description> High performance LINQ implementation with minimal heap allocations. Supports enumerables, async enumerables, Memory, and Span.</Description>
-    <Version>3.0.0-beta47</Version>
+    <Version>3.0.0-beta48</Version>
     <PackageIcon>Icon.png</PackageIcon>
     <PackageLicenseFile>LICENSE</PackageLicenseFile>
     <PackageTags>netfabric, hyperlinq, linq, enumeration, extensions, performance</PackageTags>
diff --git a/NetFabric.Hyperlinq/Projection/Select/Select/Select.ArraySegment.cs b/NetFabric.Hyperlinq/Projection/Select/Select/Select.ArraySegment.cs
@@ -133,7 +133,14 @@ public TResult Current
 
                 [MethodImpl(MethodImplOptions.AggressiveInlining)]
                 public bool MoveNext()
-                    => ++index <= end;
+                {
+                    if (index <= end)
+                    {
+                        index++;
+                        return index <= end;
+                    }
+                    return false;
+                }
 
                 [ExcludeFromCodeCoverage]
                 [DoesNotReturn]
diff --git a/NetFabric.Hyperlinq/Projection/Select/SelectAt/SelectAt.ArraySegment.cs b/NetFabric.Hyperlinq/Projection/Select/SelectAt/SelectAt.ArraySegment.cs
@@ -125,8 +125,15 @@ public TResult Current
 
                 [MethodImpl(MethodImplOptions.AggressiveInlining)]
                 public bool MoveNext()
-                    => ++index <= end;
-
+                {
+                    if (index <= end)
+                    {
+                        index++;
+                        return index <= end;
+                    }
+                    return false;
+                }
+                
                 [ExcludeFromCodeCoverage]
                 [DoesNotReturn]
                 public readonly void Reset()
diff --git a/NetFabric.Hyperlinq/Set/Distinct/Distinct.ArraySegment.cs b/NetFabric.Hyperlinq/Set/Distinct/Distinct.ArraySegment.cs
@@ -67,10 +67,14 @@ readonly object? IEnumerator.Current
                 [MethodImpl(MethodImplOptions.AggressiveInlining)]
                 public bool MoveNext()
                 {
+                    var index = this.index;
                     while (++index <= end)
                     {
                         if (set.Add(source![index]))
+                        {
+                            this.index = index; 
                             return true;
+                        }
                     }
                     return false;
                 }
diff --git a/NetFabric.Hyperlinq/Utils/ArrayPoolExtensions.cs b/NetFabric.Hyperlinq/Utils/ArrayPoolExtensions.cs
@@ -4,10 +4,13 @@
 
 namespace NetFabric.Hyperlinq
 {
-    static class ArrayPoolExtensions
+    public static class ArrayPoolExtensions
     {
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public static Lease<T> Lease<T>(this ArrayPool<T> pool, int length, bool clearOnDispose)
-            => new(pool, length, clearOnDispose);
+        public static Lease<T> Lease<T>(this ArrayPool<T> pool, int length, bool clearOnDispose = default)
+            => length < 0
+                ? Throw.ArgumentOutOfRangeException<Lease<T>>(nameof(length))
+                // ReSharper disable once HeapView.ObjectAllocation.Evident
+                : new Lease<T>(pool, length, clearOnDispose);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -78,10 +78,14 @@ readonly object? IEnumerator.Current`
`78`	`78`	`[MethodImpl(MethodImplOptions.AggressiveInlining)]`
`79`	`79`	`public bool MoveNext()`
`80`	`80`	`{`
	`81`	`+ var index = this.index;`
`81`	`82`	`while (++index <= end)`
`82`	`83`	`{`
`83`	`84`	`if (predicate.Invoke(source![index]))`
	`85`	`+ {`
	`86`	`+ this.index = index;`
`84`	`87`	`return true;`
	`88`	`+ }`
`85`	`89`	`}`
`86`	`90`	`return false;`
`87`	`91`	`}`
Original file line number	Diff line number	Diff line change
`@@ -77,11 +77,15 @@ readonly object? IEnumerator.Current`
`77`	`77`	`public bool MoveNext()`
`78`	`78`	`{`
`79`	`79`	`var span = source.Span;`
	`80`	`+ var index = this.index;`
`80`	`81`	`while (++index < span.Length)`
`81`	`82`	`{`
`82`	`83`	`var item = span[index];`
`83`	`84`	`if (predicate.Invoke(item))`
	`85`	`+ {`
	`86`	`+ this.index = index;`
`84`	`87`	`return true;`
	`88`	`+ }`
`85`	`89`	`}`
`86`	`90`	`return false;`
`87`	`91`	`}`
Original file line number	Diff line number	Diff line change
`@@ -84,10 +84,14 @@ readonly object? IEnumerator.Current`
`84`	`84`	`[MethodImpl(MethodImplOptions.AggressiveInlining)]`
`85`	`85`	`public bool MoveNext()`
`86`	`86`	`{`
	`87`	`+ var index = this.index;`
`87`	`88`	`while (++index <= end)`
`88`	`89`	`{`
`89`	`90`	`if (predicate.Invoke(source![index + offset], index))`
	`91`	`+ {`
	`92`	`+ this.index = index;`
`90`	`93`	`return true;`
	`94`	`+ }`
`91`	`95`	`}`
`92`	`96`	`return false;`
`93`	`97`	`}`
Original file line number	Diff line number	Diff line change
`@@ -82,10 +82,14 @@ readonly object? IEnumerator.Current`
`82`	`82`	`[MethodImpl(MethodImplOptions.AggressiveInlining)]`
`83`	`83`	`public bool MoveNext()`
`84`	`84`	`{`
	`85`	`+ var index = this.index;`
`85`	`86`	`while (++index <= end)`
`86`	`87`	`{`
`87`	`88`	`if (predicate.Invoke(source![index]))`
	`89`	`+ {`
	`90`	`+ this.index = index;`
`88`	`91`	`return true;`
	`92`	`+ }`
`89`	`93`	`}`
`90`	`94`	`return false;`
`91`	`95`	`}`
Original file line number	Diff line number	Diff line change
`@@ -67,10 +67,14 @@ readonly object? IEnumerator.Current`
`67`	`67`	`[MethodImpl(MethodImplOptions.AggressiveInlining)]`
`68`	`68`	`public bool MoveNext()`
`69`	`69`	`{`
	`70`	`+ var index = this.index;`
`70`	`71`	`while (++index <= end)`
`71`	`72`	`{`
`72`	`73`	`if (set.Add(source![index]))`
	`74`	`+ {`
	`75`	`+ this.index = index;`
`73`	`76`	`return true;`
	`77`	`+ }`
`74`	`78`	`}`
`75`	`79`	`return false;`
`76`	`80`	`}`