Analyze IIFEs

Closes
#16

Author: NickvanDyke

src/rule.js

@@ -1,15 +1,13 @@
 import { messageIds, messages } from "./messages.js";
-import { getCallExpr, getDownstreamRefs } from "./util/ast.js";
+import { getCallExpr, getDownstreamRefs, findIIFE } from "./util/ast.js";
 import {
-  isFnRef,
   findPropUsedToResetAllState,
   isUseEffect,
   getUseStateNode,
   getEffectFnRefs,
   getDependenciesRefs,
   isStateSetter,
   isPropCallback,
-  getEffectFn,
   isDirectCall,
   getUpstreamReactVariables,
   isState,
@@ -75,7 +73,11 @@ export const rule = {
               // Don't analyze HOC prop callbacks -- we don't have control over them to lift state or logic
               !isHOCProp(ref.resolved)),
         )
-        .filter((ref) => isDirectCall(ref.identifier))
+        .filter(
+          (ref) =>
+            isDirectCall(ref.identifier) ||
+            isDirectCall(findIIFE(ref.identifier)),
+        )
         .forEach((ref) => {
           const callExpr = getCallExpr(ref);
 

src/util/ast.js

@@ -94,3 +94,18 @@ export const getCallExpr = (ref, current = ref.identifier.parent) => {
 
   return undefined;
 };
+
+export const findIIFE = (node) => {
+  if (!node) {
+    return undefined;
+  } else if (
+    node.type === "CallExpression" &&
+    (node.callee.type === "ArrowFunctionExpression" ||
+      node.callee.type === "FunctionExpression")
+  ) {
+    return node;
+  } else {
+    return findIIFE(node.parent);
+  }
+};
+

test/syntax.test.js

@@ -153,6 +153,24 @@ new MyRuleTester().run("/syntax", {
         };
       `,
     },
+    {
+      name: "Internal IIFE inside callback",
+      code: js`
+        import { useEffect, useState } from 'react';
+
+        export const MyComponent = () => {
+          const [state, setState] = useState();
+
+          useEffect(() => {
+            window.addEventListener('load', () => {
+              (async () => {
+                setState('Loaded');
+              })();
+            });
+          }, []);
+        };
+      `,
+    },
   ],
   invalid: [
     {
@@ -493,7 +511,6 @@ new MyRuleTester().run("/syntax", {
     {
       // https://github.com/NickvanDyke/eslint-plugin-react-you-might-not-need-an-effect/issues/16
       name: "Internal IIFE",
-      todo: true, // TODO: `isDirectCall` returns false for IIFEs, so we don't follow `iife`. Otherwise it works.
       code: js`
         import { useEffect, useState } from 'react';
 
@@ -515,7 +532,7 @@ new MyRuleTester().run("/syntax", {
       `,
       errors: [
         {
-          messageId: messageIds.avoidChainingState,
+          messageId: messageIds.avoidInitializingState,
         },
       ],
     },