Skip to content

Commit 6cd58d8

Browse files
Apply suggestions from code review
Co-authored-by: Dra Murphy <149679879+kmurphypolygon@users.noreply.github.com>
1 parent 0439c17 commit 6cd58d8

File tree

15 files changed

+36
-36
lines changed

15 files changed

+36
-36
lines changed

docs/pos/architecture/heimdall/key-management.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Each validator uses two keys to manage validator related activities on Polygon. The *signer* key is kept on the node and is generally considered a *hot* wallet, whereas the Owner key is supposed to kept very secure, is used infrequently, and is generally considered a *cold* wallet. The staked funds are controlled by the *owner* key.
1+
Each validator uses two keys to manage validator related activities on Polygon. The *signer* key is kept on the node and is generally considered a *hot* wallet, whereas the owner key is supposed to kept very secure, is used infrequently, and is generally considered a *cold* wallet. The staked funds are controlled by the *owner* key.
22

33
This separation of responsibilities has been done to ensure an efficient tradeoff between security and ease of use. Both keys are Ethereum compatible addresses and work exactly the same manner. And yes, it is possible to have same owner and signer keys.
44

docs/pos/concepts/tokens/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
The *Tokens* subsection focuses on the proposed Polygon PoS's native token POL and the soon to be replaced native token MATIC.
1+
This section focuses on the proposed Polygon PoS's native token POL and the soon to be replaced native token MATIC.
22

33
The *POL* subsection defines the POL token and continues to present, in a question-and-answer (Q&A) format, all the information that users need to know about the proposed transition.
44

docs/pos/get-started/becoming-a-validator.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ In return for their efforts, validators are rewarded with incentives, encouragin
2121
Polygon consists of the three following layers:
2222

2323
* Ethereum layer: A set of contracts on the Ethereum mainnet.
24-
* Heimdall layer: A set of proof-of-stake Heimdall nodes running in parallel to the Ethereum mainnet, monitoring the set of staking contracts deployed on the Ethereum mainnet, and committing the Polygon PoS network checkpoints to the Ethereum mainnet. Heimdall is based on Tendermint.
24+
* Heimdall layer: A set of proof-of-stake Heimdall nodes running in parallel to the Ethereum mainnet, monitoring the set of staking contracts deployed on the Ethereum mainnet, and committing the Polygon PoS network checkpoints to the Ethereum mainnet. Heimdall is based on Tendermint.
2525
* Bor layer: A set of block-producing Bor nodes shuffled by Heimdall nodes. Bor is based on Go Ethereum.
2626

2727
To be a validator on the Polygon PoS network, you must do the following:
@@ -67,7 +67,7 @@ Bor is the block producing node and layer for the Polygon PoS network. It is bas
6767

6868
Keep up with the latest node and validator updates from the Polygon team and the community by keeping an eye on the [announcements posed to Polygon forums](https://forum.polygon.technology/c/announcement/6).
6969

70-
A blockchain validator is someone who is responsible for validating transactions within a blockchain. On the Polygon PoS network, any participant can be qualified to become a Polygon's validator by running a **Validator Node (Sentry + Validator)** to earn rewards and collect transaction fees. To ensure the good participation by validators, they lock up at least 1 MATIC token as a stake in the ecosystem.
70+
A blockchain validator is someone who is responsible for validating transactions within a blockchain. On the Polygon PoS network, any participant can be qualified to become a Polygon's validator by running a validator node (sentry + validator) to earn rewards and collect transaction fees. To ensure the good participation by validators, they lock up at least 1 MATIC token as a stake in the ecosystem.
7171

7272
!!! info "Active validator limit"
7373

@@ -119,7 +119,7 @@ The following technical node operations are **done automatically by the nodes:**
119119

120120
The node uptime on the Polygon PoS network is based on the number of checkpoint transactions that the validator node has signed.
121121

122-
Approximately every 34 minutes a proposer submits a checkpoint transaction to the Ethereum mainnet. The checkpoint transaction must be signed by every validator on the Polygon PoS network. **Failure to sign a checkpoint transaction results in the decrease of your validator node performance**.
122+
Approximately every 34 minutes a proposer submits a checkpoint transaction to the Ethereum mainnet. The checkpoint transaction must be signed by every validator on the Polygon PoS network. Failure to sign a checkpoint transaction results in the decrease of your validator node performance.
123123

124124
The process of signing the checkpoint transactions is automated. To ensure your validator node is signing all valid checkpoint transactions, you must maintain and monitor your node health.
125125

docs/pos/how-to/bridging/ethereum-polygon/ethereum-to-matic.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ The sender and receiver contracts are required to be mapped on Ethereum — [Sta
1212

1313
---
1414

15-
In the following walkthrough, we'll be deploying a sender contract on Sepolia (Ethereum testnet) and a Receiver contract on Amoy (Polygon testnet). Then, we'll be sending data from the sender and reading data on the receiver via web3 calls in a node script.
15+
In the following walkthrough, we'll be deploying a sender contract on Sepolia (Ethereum testnet) and a receiver contract on Amoy (Polygon testnet). Then, we'll be sending data from the sender and reading data on the receiver via web3 calls in a node script.
1616

1717
### 1. Deploy sender contract
1818

@@ -51,7 +51,7 @@ In the above function, `stateSenderContract` is the address of the `StateSender`
5151
5252
It is recommended to use constructors to pass in variables, but for the purpose of this demo, we'll simply hardcode these two addresses:
5353
54-
Following is how our `Sender.sol` looks like:
54+
Following is what our `Sender.sol` looks like:
5555
5656
```jsx title="Sender.sol"
5757

@@ -84,7 +84,7 @@ Use Remix to deploy the contract and keep a note of the address and ABI.
8484
8585
The receiver contract is the one that is invoked by a validator when the `StateSynced` event is emitted. The validator invokes the function `onStateReceive`on the receiver contract to submit the data. To implement it, we first import [StateReceiver](https://github.com/maticnetwork/contracts/blob/release-betaV2/contracts/child/bor/StateReceiver.sol) interface and write down our custom logic — to interpret the transferred data inside onStateReceive.
8686
87-
Following is how our `Receiver.sol` looks like:
87+
The following is what our `Receiver.sol` looks like:
8888
8989
```jsx title="Receiver.sol"
9090

docs/pos/how-to/bridging/l1-l2-communication/state-transfer.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,12 @@ You need to inherit `FxBaseRootTunnel` contract in your root contract on Ethereu
4242
- Sepolia: [0x1707157b9221204869ED67705e42fB65e026586c](https://sepolia.etherscan.io/address/0x1707157b9221204869ED67705e42fB65e026586c)
4343
- Amoy: [0xf5D2463d0176462d797Afcd57eC477b7B0CcBE70](https://amoy.polygonscan.com/address/0xf5D2463d0176462d797Afcd57eC477b7B0CcBE70)
4444

45-
## State Transfer from Ethereum to Polygon
45+
## State transfer from Ethereum to Polygon
4646

4747
- You need to call `_sendMessageToChild()` internally in your root contract and pass the data as an argument to be sent to Polygon. Example: [0x00a1aa71593fec825b4b1ce1081b5a9848612fb21f9e56def2914b483f5f34f5](https://sepolia.etherscan.io/tx/0x00a1aa71593fec825b4b1ce1081b5a9848612fb21f9e56def2914b483f5f34f5)
4848
- In your child contract, implement `_processMessageFromRoot()` virtual function in `FxBaseChildTunnel` to retrieve data from Ethereum. The data will be received automatically from the state receiver when the state is synced.
4949

50-
## State Transfer from Polygon to Ethereum
50+
## State transfer from Polygon to Ethereum
5151

5252
1. Call `_sendMessageToRoot()` internally in your child contract with data as a parameter to be sent to Ethereum. Note down the transaction hash as it will be used to generate the proof after the transaction has been included as a checkpoint.
5353

docs/pos/how-to/full-node/full-node-ansible.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@ An [Ansible playbook](https://docs.ansible.com/ansible/latest/user_guide/playboo
66

77
## Prerequisites
88

9-
- Install Ansible on your local machine with Python3.x. The setup will not work if you have Python 2.x.
9+
- Install Ansible on your local machine with Python3.x. The setup doesn't run on Python 2.x.
1010
- To install Ansible with Python 3.x, you can use pip. If you do not have pip on your machine,
1111
follow the steps outlined [here](https://pip.pypa.io/en/stable/). Run `pip3 install ansible` to install
1212
Ansible.
1313
- Check the [Polygon PoS Ansible repository](https://github.com/maticnetwork/node-ansible#requirements) for
1414
requirements.
15-
- You will also need to ensure that Go is *not installed* in your environment. You will run into issues if you attempt to set up your full node through Ansible with Go installed as Ansible requires specific packages of Go to be installed.
15+
- You also need to ensure that Go is *not installed* in your environment. You will run into issues if you attempt to set up your full node through Ansible with Go installed as Ansible requires specific packages of Go.
1616
- You will also need to make sure that your VM / Machine does not have any previous setups for Polygon Validator or Heimdall or Bor. You will need to delete them as your setup will run into issues.
1717

1818
!!! info "Heimdall source enhancements"

docs/pos/how-to/full-node/full-node-binaries.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ Hex Byte representation - [171 205 18 52]
6161
Length in byte format - 4
6262
```
6363

64-
To install *Heimdall*, run the below commands:
64+
To install *Heimdall*, run the following commands:
6565

6666
```bash
6767
curl -L https://raw.githubusercontent.com/maticnetwork/install/main/heimdall.sh | bash -s -- <heimdall_version> <network_type> <node_type>

docs/pos/how-to/full-node/full-node-docker.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@ At this point, we should be ready to start Bor. We’re going to use this comman
380380
docker run -p 30303:30303 -p 8545:8545 -v /mnt/data/bor:/bor-home:rw --net polygon --name bor -d --restart unless-stopped 0xpolygon/bor:1.1.0 server --config /bor-home/config.toml
381381
```
382382

383-
If everything went well, you should see log entries that look like this:
383+
If everything goes well, you should see log entries that look like this:
384384

385385
```bash
386386
2022-12-14T19:53:51.989897291Z INFO [12-14|19:53:51.989] Fetching state updates from Heimdall fromID=4 to=2020-05-30T23:47:46Z

docs/pos/how-to/operate-validator-node/change-signer-address.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ For more information on what a signer address is, see
66

77
Make sure your new validator node is fully synced and is running with the new signer address.
88

9-
## Change the signer Address
9+
## Change the signer address
1010

1111
This guide refers to your current validator node as Node 1 and your new validator node as Node 2.
1212

docs/pos/how-to/operate-validator-node/topup-heimdall-fee.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ This document provides instructions on how to top up the Heimdall fee for a PoS
66

77
The easiest way is via the [Polygon Staking UI](https://staking.polygon.technology/account).
88

9-
You can also do it manually by following the steps below. This requires basic Etherscan knowledge and key details like the Validator signer address.
9+
You can also do it manually by following the steps below. This requires basic Etherscan knowledge and key details like the validator signer address.
1010

1111
1. Head over to [Etherscan.io](https://etherscan.io)
1212

0 commit comments

Comments
 (0)