Skip to content

Commit 0abbc94

Browse files
committed
Updating to use graphql-java:16 library.
Updated tests to work with immutable collections and stricter schema validation.
1 parent 832dffc commit 0abbc94

File tree

5 files changed

+10
-6
lines changed

5 files changed

+10
-6
lines changed

build.gradle

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ gradle.projectsEvaluated {
5656

5757
dependencies {
5858
compile 'javax.validation:validation-api:1.1.0.Final'
59-
compile 'com.graphql-java:graphql-java:15.0'
59+
compile 'com.graphql-java:graphql-java:16.0'
6060
implementation "jakarta.xml.bind:jakarta.xml.bind-api:2.3.2"
6161
implementation "org.glassfish.jaxb:jaxb-runtime:2.3.2"
6262

@@ -70,6 +70,7 @@ dependencies {
7070
testCompile 'org.testng:testng:6.9.10'
7171
testCompile 'org.hamcrest:hamcrest-all:1.3'
7272
testCompile 'org.mockito:mockito-core:2.+'
73+
testCompile 'com.google.guava:guava:30.0-jre'
7374
}
7475

7576
test.useTestNG()

src/main/java/graphql/annotations/strategies/EnhancedExecutionStrategy.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ protected CompletableFuture<ExecutionResult> resolveField(ExecutionContext execu
5454

5555
ExecutionStepInfo fieldTypeInfo = ExecutionStepInfo.newExecutionStepInfo().type(fieldDef.getType()).parentInfo(parameters.getExecutionStepInfo()).build();
5656
ExecutionStrategyParameters newParameters = ExecutionStrategyParameters.newParameters()
57-
.arguments(parameters.getArguments())
5857
.fields(parameters.getFields())
5958
.nonNullFieldValidator(parameters.getNonNullFieldValidator())
6059
.executionStepInfo(fieldTypeInfo)
@@ -88,7 +87,6 @@ protected FieldValueInfo completeValue(ExecutionContext executionContext, Execut
8887
*/
8988
private ExecutionStrategyParameters withSource(ExecutionStrategyParameters parameters, Object source) {
9089
return ExecutionStrategyParameters.newParameters()
91-
.arguments(parameters.getArguments())
9290
.fields(parameters.getFields())
9391
.nonNullFieldValidator(parameters.getNonNullFieldValidator())
9492
.executionStepInfo(parameters.getExecutionStepInfo())

src/test/java/graphql/annotations/AnnotationsSchemaCreatorTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,7 @@ public void build_directive_UsingDirectivesContainer_schemaIsCreatedWithDirectiv
220220

221221
@GraphQLName("additional")
222222
public static class AdditionalTypeTest {
223+
@GraphQLField
223224
public int getI() {
224225
return 4;
225226
}

src/test/java/graphql/annotations/GraphQLExtensionsTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@
3131
import static graphql.annotations.AnnotationsSchemaCreator.newAnnotationsSchema;
3232
import static org.testng.Assert.*;
3333

34+
import com.google.common.collect.ImmutableList;
35+
3436
public class GraphQLExtensionsTest {
3537

3638
@GraphQLDescription("TestObject object")
@@ -103,7 +105,7 @@ public void fields() {
103105
List<GraphQLFieldDefinition> fields = object.getFieldDefinitions();
104106
assertEquals(fields.size(), 5);
105107

106-
fields.sort(Comparator.comparing(GraphQLFieldDefinition::getName));
108+
fields = ImmutableList.sortedCopyOf(Comparator.comparing(GraphQLFieldDefinition::getName), fields);
107109

108110
assertEquals(fields.get(0).getName(), "field");
109111
assertEquals(fields.get(1).getName(), "field2");

src/test/java/graphql/annotations/GraphQLObjectTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,8 @@
4848
import static graphql.schema.GraphQLSchema.newSchema;
4949
import static org.testng.Assert.*;
5050

51+
import com.google.common.collect.ImmutableList;
52+
5153
@SuppressWarnings("unchecked")
5254
public class GraphQLObjectTest {
5355

@@ -275,7 +277,7 @@ public void fields() {
275277
List<GraphQLFieldDefinition> fields = object.getFieldDefinitions();
276278
assertEquals(fields.size(), 8);
277279

278-
fields.sort((o1, o2) -> o1.getName().compareTo(o2.getName()));
280+
fields = ImmutableList.sortedCopyOf((o1, o2) -> o1.getName().compareTo(o2.getName()), fields);
279281

280282
assertEquals(fields.get(2).getName(), "field0");
281283
assertEquals(fields.get(2).getDescription(), "field");
@@ -407,7 +409,7 @@ public void accessors() {
407409
GraphQLObjectType object = this.graphQLAnnotations.object(TestAccessors.class);
408410
List<GraphQLFieldDefinition> fields = object.getFieldDefinitions();
409411
assertEquals(fields.size(), 2);
410-
fields.sort(Comparator.comparing(GraphQLFieldDefinition::getName));
412+
fields = ImmutableList.sortedCopyOf(Comparator.comparing(GraphQLFieldDefinition::getName), fields);
411413

412414
assertEquals(fields.get(0).getName(), "getValue");
413415
assertEquals(fields.get(1).getName(), "setAnotherValue");

0 commit comments

Comments
 (0)