fix: use absolute paths for fail file placement

Fail files are now correctly placed in the same directory as the input
file, even when running from different working directories.

- Use Path.resolve() to get absolute path of input file
- Apply fix in importer.py for main fail file output
- Apply fix in writer.py for relational failures
- Add test to verify fail file uses absolute path

Author: bosd

src/odoo_data_flow/importer.py

@@ -151,7 +151,8 @@ def run_import(  # noqa: C901
 
     file_to_process = filename
     if fail:
-        fail_path = Path(filename).parent / _get_fail_filename(model, False)
+        # Use absolute path to find fail file in same directory as input file
+        fail_path = Path(filename).resolve().parent / _get_fail_filename(model, False)
         line_count = _count_lines(str(fail_path))
         if line_count <= 1:
             Console().print(
@@ -211,7 +212,10 @@ def run_import(  # noqa: C901
 
     final_deferred = deferred_fields or import_plan.get("deferred_fields", [])
     final_uid_field = unique_id_field or import_plan.get("unique_id_field") or "id"
-    fail_output_file = str(Path(filename).parent / _get_fail_filename(model, fail))
+    # Use absolute path to ensure fail file goes to same directory as input file
+    # even when running from different working directories
+    input_file_dir = Path(filename).resolve().parent
+    fail_output_file = str(input_file_dir / _get_fail_filename(model, fail))
 
     if fail:
         log.info("Single-record batching enabled for this import strategy.")

src/odoo_data_flow/lib/writer.py

@@ -24,8 +24,11 @@ def write_relational_failures_to_csv(
     if not failed_records:
         return
 
-    fail_filename = f"{Path(original_filename).stem}_relations_fail.csv"
-    fail_filepath = Path(original_filename).parent / fail_filename
+    # Use absolute path to ensure fail file goes to same directory as input file
+    # even when running from different working directories
+    original_path = Path(original_filename).resolve()
+    fail_filename = f"{original_path.stem}_relations_fail.csv"
+    fail_filepath = original_path.parent / fail_filename
 
     try:
         file_exists = fail_filepath.exists()

tests/test_importer.py

@@ -38,6 +38,61 @@ def test_get_fail_filename_recovery_mode(self) -> None:
         assert any(char.isdigit() for char in filename)
 
 
+class TestFailFilePath:
+    """Tests for fail file path resolution."""
+
+    @patch("odoo_data_flow.importer.import_threaded.import_data")
+    @patch("odoo_data_flow.importer._run_preflight_checks")
+    def test_fail_file_uses_absolute_path(
+        self,
+        mock_preflight: MagicMock,
+        mock_import_data: MagicMock,
+        tmp_path: Path,
+    ) -> None:
+        """Test that fail file path is resolved to absolute path."""
+        # Create a subdirectory to simulate environment folder
+        env_dir = tmp_path / "data" / "uat"
+        env_dir.mkdir(parents=True)
+        source_file = env_dir / "res_partner.csv"
+        source_file.write_text("id,name\n1,Test\n")
+
+        mock_preflight.return_value = True
+        mock_import_data.return_value = (True, {"total_records": 1})
+
+        # Run import with relative-style path
+        run_import(
+            config="dummy.conf",
+            filename=str(source_file),
+            model="res.partner",
+            deferred_fields=None,
+            auto_defer=False,
+            unique_id_field=None,
+            no_preflight_checks=False,
+            headless=False,
+            worker=1,
+            batch_size=10,
+            skip=0,
+            fail=False,
+            separator=";",
+            ignore=None,
+            context="{}",
+            encoding="utf-8",
+            o2m=False,
+            groupby=None,
+        )
+
+        # Verify the fail_file path passed to import_data is absolute
+        # and in the same directory as the input file
+        call_args = mock_import_data.call_args
+        fail_file_arg = call_args.kwargs.get("fail_file") or call_args[1].get(
+            "fail_file"
+        )
+        assert fail_file_arg is not None
+        fail_path = Path(fail_file_arg)
+        assert fail_path.is_absolute()
+        assert fail_path.parent == env_dir
+
+
 class TestRunImport:
     """Tests for the main run_import orchestrator function."""