-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[typescript-node] Fixes generation when parent contains TypeScript primitive #22401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| return "string".equals(lowerType) || | ||
| "boolean".equals(lowerType) || | ||
| "number".equals(lowerType) || | ||
| "any".equals(lowerType) || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any value comes when the schema has additionalProperties: true
|
I need help with CircleCI tests. The error looks disconnected from my changes |
macjohnny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix
|
@fetis can you merge the most recent master branch? |
|
@macjohnny updated from the master |
|
@macjohnny any update? I see random failures on CI, but I cannot connect them with my changes |
|
can you merge the master branch again? that one seems green for all CI workflows |
When the schema contains
additionalProperties, thetypevalue of it was transferred into theparentproperty of the model. This led to incorrect code generation, like thisThis fix filters out the known TS primitives from the parent property.
Closes #14661
Mentioning the TypeScript committee:
@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka @joscha
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)