Fix plot_goodness_of_fit scatter

dweindl · dweindl · commit 9641c38f6380 · 2025-09-19T22:08:22.000+02:00
Measurements and simulation were swapped in the scatter plot. The regression line was correct.
diff --git a/petab/v1/visualize/plot_residuals.py b/petab/v1/visualize/plot_residuals.py
@@ -184,8 +184,8 @@ def plot_goodness_of_fit(
         fig.set_layout_engine("tight")
 
     ax.scatter(
-        petab_problem.measurement_df["measurement"],
         simulations_df["simulation"],
+        petab_problem.measurement_df["measurement"],
         c=color,
     )
 

Original file line number	Diff line number	Diff line change
`@@ -184,8 +184,8 @@ def plot_goodness_of_fit(`
`184`	`184`	`fig.set_layout_engine("tight")`
`185`	`185`
`186`	`186`	`ax.scatter(`
`187`		`- petab_problem.measurement_df["measurement"],`
`188`	`187`	`simulations_df["simulation"],`
	`188`	`+ petab_problem.measurement_df["measurement"],`
`189`	`189`	`c=color,`
`190`	`190`	`)`
`191`	`191`